Fix golden snapshot virtio-net virtqueue corruption#64
Merged
Conversation
Bring the host-side TAP device down before flushing the guest eth0 during golden snapshot creation. Without this, the host can push ARP/IPv6 ND packets into the virtio-net RX ring between the guest flush and the VM pause, corrupting the virtqueue state. On restore every sandbox gets "input.0:id 0 is not a head!" (vq->broken=true) which permanently breaks networking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Preview Environment DestroyedThe preview environment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
virtio_net virtio2: input.0:id 0 is not a head!(vq->broken=true) which permanently breaks networking for every sandbox created from the golden snapshotRoot cause
During
PrepareGoldenSnapshot(), the quiesce sequence was:ip addr flush dev eth0 && ip link set eth0 downThe host-side TAP remained up, allowing packets to enter the RX ring during steps 1-3. The fix adds
ip link set <TAP> downon the host before step 1.Test plan
🤖 Generated with Claude Code