Revert "cmd: exit: Fix return value"

hpalacio · hpalacio · commit a68e7d06fca7 · 2022-11-21T17:44:22.000+01:00
This reverts commit 8c4e3b7. This commit is breaking the 'exit' cmd functionality of quiting a script. Revert it so 'exit' works as it is documented: it accepts no arguments and it always returns 0 (success). Signed-off-by: Hector Palacios <hector.palacios@digi.com>
diff --git a/cmd/exit.c b/cmd/exit.c
@@ -10,10 +10,13 @@
 static int do_exit(struct cmd_tbl *cmdtp, int flag, int argc,
 		   char *const argv[])
 {
+	int r;
+
+	r = 0;
 	if (argc > 1)
-		return dectoul(argv[1], NULL);
+		r = simple_strtoul(argv[1], NULL, 10);
 
-	return 0;
+	return -r - 2;
 }
 
 U_BOOT_CMD(

Original file line number	Diff line number	Diff line change
`@@ -10,10 +10,13 @@`
`10`	`10`	`static int do_exit(struct cmd_tbl *cmdtp, int flag, int argc,`
`11`	`11`	`char *const argv[])`
`12`	`12`	`{`
	`13`	`+ int r;`
	`14`	`+`
	`15`	`+ r = 0;`
`13`	`16`	`if (argc > 1)`
`14`		`- return dectoul(argv[1], NULL);`
	`17`	`+ r = simple_strtoul(argv[1], NULL, 10);`
`15`	`18`
`16`		`- return 0;`
	`19`	`+ return -r - 2;`
`17`	`20`	`}`
`18`	`21`
`19`	`22`	`U_BOOT_CMD(`