A few fixes after the javadocs work brought to light a few defect - issue #6

Author: stevewalton28

src/test/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredChromeDriverIT.java

@@ -4,8 +4,6 @@
 import org.junit.jupiter.api.Test;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.support.events.EventFiringWebDriver;
-import uk.co.evoco.webdriver.configuration.WebDriverConfig;
-import uk.co.evoco.webdriver.utils.JsonUtils;
 
 import java.io.IOException;
 
@@ -16,8 +14,7 @@ public class ConfiguredChromeDriverIT {
 
     @Test
     public void testReturnsLocalWebDriver() throws IOException {
-        WebDriverConfig webDriverConfig = JsonUtils.fromFile(ClassLoader.getSystemResourceAsStream("fixtures/sample-config.json"), WebDriverConfig.class);
-        ConfiguredChromeDriver configuredChromeDriver = new ConfiguredChromeDriver(webDriverConfig);
+        ConfiguredChromeDriver configuredChromeDriver = new ConfiguredChromeDriver();
         WebDriver webDriver = configuredChromeDriver.getDriver(FileUtils.getTempDirectory());
         assertThat(webDriver, instanceOf(EventFiringWebDriver.class));
     }

src/test/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredEdgeDriverIT.java

@@ -6,10 +6,6 @@
 import org.openqa.selenium.support.events.EventFiringWebDriver;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import uk.co.evoco.webdriver.configuration.WebDriverConfig;
-import uk.co.evoco.webdriver.utils.JsonUtils;
-
-import java.io.IOException;
 
 import static org.hamcrest.CoreMatchers.instanceOf;
 import static org.hamcrest.MatcherAssert.assertThat;
@@ -19,10 +15,9 @@ public class ConfiguredEdgeDriverIT {
     private static final Logger logger = LoggerFactory.getLogger(ConfiguredEdgeDriverIT.class);
 
     @Test
-    public void testReturnsLocalWebDriver() throws IOException {
+    public void testReturnsLocalWebDriver() {
         if(System.getProperty("os.name").contains("win")) {
-            WebDriverConfig webDriverConfig = JsonUtils.fromFile(ClassLoader.getSystemResourceAsStream("fixtures/sample-config.json"), WebDriverConfig.class);
-            ConfiguredEdgeDriver configuredEdgeDriver = new ConfiguredEdgeDriver(webDriverConfig);
+            ConfiguredEdgeDriver configuredEdgeDriver = new ConfiguredEdgeDriver();
             WebDriver webDriver = configuredEdgeDriver.getDriver(FileUtils.getTempDirectory());
             assertThat(webDriver, instanceOf(EventFiringWebDriver.class));
             webDriver.quit();

src/test/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredFirefoxDriverIT.java

@@ -4,8 +4,6 @@
 import org.junit.jupiter.api.Test;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.support.events.EventFiringWebDriver;
-import uk.co.evoco.webdriver.configuration.WebDriverConfig;
-import uk.co.evoco.webdriver.utils.JsonUtils;
 
 import java.io.IOException;
 
@@ -16,8 +14,7 @@ public class ConfiguredFirefoxDriverIT {
 
     @Test
     public void testReturnsLocalWebDriver() throws IOException {
-        WebDriverConfig webDriverConfig = JsonUtils.fromFile(ClassLoader.getSystemResourceAsStream("fixtures/sample-config.json"), WebDriverConfig.class);
-        ConfiguredFirefoxDriver configuredFirefoxDriver = new ConfiguredFirefoxDriver(webDriverConfig);
+        ConfiguredFirefoxDriver configuredFirefoxDriver = new ConfiguredFirefoxDriver();
         WebDriver webDriver = configuredFirefoxDriver.getDriver(FileUtils.getTempDirectory());
         assertThat(webDriver, instanceOf(EventFiringWebDriver.class));
     }

src/test/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredInternetExplorerDriverIT.java

@@ -6,10 +6,6 @@
 import org.openqa.selenium.support.events.EventFiringWebDriver;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import uk.co.evoco.webdriver.configuration.WebDriverConfig;
-import uk.co.evoco.webdriver.utils.JsonUtils;
-
-import java.io.IOException;
 
 import static org.hamcrest.CoreMatchers.instanceOf;
 import static org.hamcrest.MatcherAssert.assertThat;
@@ -19,10 +15,9 @@ public class ConfiguredInternetExplorerDriverIT {
     private static final Logger logger = LoggerFactory.getLogger(ConfiguredInternetExplorerDriverIT.class);
 
     @Test
-    public void testReturnsLocalWebDriver() throws IOException {
+    public void testReturnsLocalWebDriver() {
         if(System.getProperty("os.name").contains("win")) {
-            WebDriverConfig webDriverConfig = JsonUtils.fromFile(ClassLoader.getSystemResourceAsStream("fixtures/sample-config.json"), WebDriverConfig.class);
-            ConfiguredInternetExplorerDriver configuredIeDriver = new ConfiguredInternetExplorerDriver(webDriverConfig);
+            ConfiguredInternetExplorerDriver configuredIeDriver = new ConfiguredInternetExplorerDriver();
             WebDriver webDriver = configuredIeDriver.getDriver(FileUtils.getTempDirectory());
             assertThat(webDriver, instanceOf(EventFiringWebDriver.class));
             webDriver.quit();

src/test/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredSafariDriverIT.java

@@ -6,10 +6,6 @@
 import org.openqa.selenium.support.events.EventFiringWebDriver;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import uk.co.evoco.webdriver.configuration.WebDriverConfig;
-import uk.co.evoco.webdriver.utils.JsonUtils;
-
-import java.io.IOException;
 
 import static org.hamcrest.CoreMatchers.instanceOf;
 import static org.hamcrest.MatcherAssert.assertThat;
@@ -19,10 +15,9 @@ public class ConfiguredSafariDriverIT {
     private static final Logger logger = LoggerFactory.getLogger(ConfiguredSafariDriverIT.class);
 
     @Test
-    public void testReturnsLocalWebDriver() throws IOException {
+    public void testReturnsLocalWebDriver() {
         if(System.getProperty("os.name").contains("mac")) {
-            WebDriverConfig webDriverConfig = JsonUtils.fromFile(ClassLoader.getSystemResourceAsStream("fixtures/sample-config.json"), WebDriverConfig.class);
-            ConfiguredSafariDriver configuredSafariDriver = new ConfiguredSafariDriver(webDriverConfig);
+            ConfiguredSafariDriver configuredSafariDriver = new ConfiguredSafariDriver();
             WebDriver webDriver = configuredSafariDriver.getDriver(FileUtils.getTempDirectory());
             assertThat(webDriver, instanceOf(EventFiringWebDriver.class));
             webDriver.quit();