Skip to content

Commit 054b6d7

Browse files
author
travis-ci
committed
Fixing some small codacy issues
1 parent 19231df commit 054b6d7

File tree

6 files changed

+11
-5
lines changed

6 files changed

+11
-5
lines changed

src/main/java/uk/co/evoco/webdriver/WebDriverListener.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
package uk.co.evoco.webdriver;
22

33
import org.apache.commons.io.FileUtils;
4-
import org.openqa.selenium.*;
4+
import org.openqa.selenium.By;
5+
import org.openqa.selenium.TakesScreenshot;
6+
import org.openqa.selenium.OutputType;
7+
import org.openqa.selenium.WebDriver;
8+
import org.openqa.selenium.WebElement;
59
import org.openqa.selenium.support.events.WebDriverEventListener;
610
import org.openqa.selenium.support.ui.ExpectedConditions;
711
import org.openqa.selenium.support.ui.WebDriverWait;

src/main/java/uk/co/evoco/webdriver/configuration/TolerantActionExceptions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public class TolerantActionExceptions {
1313
*
1414
* @return the tolerant action wait time in seconds
1515
*/
16-
String getWaitTimeoutInSeconds() {
16+
public String getWaitTimeoutInSeconds() {
1717
return waitTimeoutInSeconds;
1818
}
1919

src/main/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredFirefoxDriver.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import com.fasterxml.jackson.databind.JsonNode;
44
import io.github.bonigarcia.wdm.WebDriverManager;
55
import org.openqa.selenium.WebDriver;
6+
import org.openqa.selenium.chrome.ChromeDriver;
7+
import org.openqa.selenium.chrome.ChromeOptions;
68
import org.openqa.selenium.firefox.FirefoxDriver;
79
import org.openqa.selenium.firefox.FirefoxOptions;
810
import org.openqa.selenium.remote.RemoteWebDriver;
@@ -59,6 +61,7 @@ public FirefoxOptions getOptions() {
5961
break;
6062
default:
6163
firefoxOptions.addPreference(key, value.asText());
64+
break;
6265
}
6366
}
6467

src/main/java/uk/co/evoco/webdriver/utils/TolerantInteraction.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,8 @@ private void interact(Select selectBox, String value, SelectBoxInteractionType s
181181
case BY_VISIBLE_TEXT:
182182
selectBox.selectByVisibleText(value);
183183
break;
184+
default:
185+
throw new WebDriverException("Must be one of BY_VALUE or BY_VISIBLE_TEXT");
184186
}
185187
}
186188

src/test/java/uk/co/evoco/testdata/DatesTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
import com.fasterxml.jackson.core.JsonProcessingException;
44
import org.junit.jupiter.api.Test;
55

6-
import java.util.Date;
7-
86
import static org.hamcrest.CoreMatchers.is;
97
import static org.hamcrest.MatcherAssert.assertThat;
108
import static uk.co.evoco.testdata.Dates.*;

src/test/java/uk/co/evoco/webdriver/utils/WebDriverUtilsIT.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import org.junit.jupiter.api.BeforeEach;
66
import org.junit.jupiter.api.Test;
77
import org.openqa.selenium.By;
8-
import org.openqa.selenium.StaleElementReferenceException;
98
import org.openqa.selenium.TimeoutException;
109
import org.openqa.selenium.WebElement;
1110
import uk.co.evoco.tests.BaseAbstractTest;

0 commit comments

Comments
 (0)