Skip to content

Commit b129073

Browse files
Fixing some SonarCloud inclusions (#67)
* Some minor documentation updates * Initial commit of the changes needed to integrsate ssaucelabs to the framework * Fixing some codacy complaints * Removing Codacy * Configuring SonarCloud * Fixing travis * Addressing SonarCloud issues and switching up project badges * Fixing some unit test issued * Moving ITs to Ts * Adding some more tests for the webdriver utils * Adding more tests * Removing some unneeded comments * Adding saucelabs username to build badge * Fixing unit test exclusion from sonarcloud * Attempting fix to saucelabs in CI
1 parent 39f9a92 commit b129073

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

src/test/java/uk/co/evoco/webdriver/configuration/SauceLabsConfigTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import com.saucelabs.saucebindings.PageLoadStrategy;
55
import com.saucelabs.saucebindings.SaucePlatform;
66
import com.saucelabs.saucebindings.UnhandledPromptBehavior;
7-
import org.junit.Test;
7+
import org.junit.jupiter.api.Test;
88
import uk.co.evoco.exceptions.SauceLabsCredentialsException;
99

1010
import java.net.MalformedURLException;

src/test/java/uk/co/evoco/webdriver/configuration/SauceLabsConfigurationLoaderTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package uk.co.evoco.webdriver.configuration;
22

33
import com.saucelabs.saucebindings.Browser;
4-
import org.junit.Test;
4+
import org.junit.jupiter.api.Test;
55

66
import static org.hamcrest.core.Is.is;
77
import static org.junit.Assert.assertThat;

src/test/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredSauceLabsDriverTests.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,19 @@
11
package uk.co.evoco.webdriver.configuration.driver;
22

3-
import org.apache.commons.io.FileUtils;
4-
import org.junit.Test;
3+
import org.junit.jupiter.api.Test;
54
import org.openqa.selenium.WebDriver;
65
import uk.co.evoco.exceptions.SauceLabsCredentialsException;
76

8-
import java.io.IOException;
9-
107
import static org.hamcrest.MatcherAssert.assertThat;
118
import static org.hamcrest.Matchers.containsString;
129

1310
public class ConfiguredSauceLabsDriverTests {
1411

1512
@Test
16-
public void testCanRunTestOnSauceLabsUsingConfigiration() throws SauceLabsCredentialsException, IOException {
13+
public void testCanRunTestOnSauceLabsUsingConfigiration() throws SauceLabsCredentialsException{
1714
System.setProperty("config", "config-saucelabs.json");
1815
ConfiguredDriver configuredSauceLabsGridDriver = new ConfiguredSauceLabsGridDriver();
19-
WebDriver webDriver = configuredSauceLabsGridDriver.getDriver(FileUtils.getTempDirectory());
16+
WebDriver webDriver = configuredSauceLabsGridDriver.getRemoteDriver();
2017
webDriver.get("https://www.evoco.co.uk");
2118
assertThat("Didn't make it to evoco.co.uk", webDriver.getCurrentUrl(), containsString("evoco.co.uk"));
2219
webDriver.quit();

0 commit comments

Comments
 (0)