Fixing a small defect in tolent radio button

Author: travis-ci

README.md

@@ -38,7 +38,7 @@ submit an issue ticket.
 ## Documentation
 
 - A full reference guide is here: https://github.com/digital-delivery-academy/selenium-pom-framework/wiki
-- Technical reference documentation (javadocs) are here: https://digital-delivery-academy.github.io/selenium-pom-framework/javadoc-0.0.10
+- Technical reference documentation (javadocs) are here: https://digital-delivery-academy.github.io/selenium-pom-framework/javadoc-0.0.11
 
 ## Example tests
 
@@ -52,7 +52,7 @@ Put this in your POM.xml.
 <dependency>
   <groupId>uk.co.evoco</groupId>
   <artifactId>selenium-pom-framework</artifactId>
-  <version>0.0.10</version>
+  <version>0.0.11</version>
 </dependency>
 ```
 

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>uk.co.evoco</groupId>
     <artifactId>selenium-pom-framework</artifactId>
-    <version>0.0.10</version>
+    <version>0.0.11</version>
 
     <contributors>
         <contributor>

src/main/java/uk/co/evoco/webdriver/utils/RadioButtonUtils.java

@@ -33,6 +33,6 @@ public static void selectByLabel(List<WebElement> webElements, String visibleLab
      */
     public static void tolerantSelectByLabel(List<WebElement> webElements, String visibleLabelText, int timeout)
             throws Throwable {
-        new RadioButtonUtils().tolerantInteraction(webElements, visibleLabelText, timeout).click();
+        new RadioButtonUtils().tolerantInteraction(webElements, visibleLabelText, timeout);
     }
 }

src/main/java/uk/co/evoco/webdriver/utils/SelectBoxUtils.java

@@ -70,6 +70,7 @@ public static void tolerantItemByVisibleText(WebElement webElement,  String visi
                 webElement, SelectBoxInteractionType.BY_VISIBLE_TEXT,
                 Optional.of(visibleText), Optional.empty(), timeout);
     }
+
     /**
      *
      * @param webElement active WebElement, already located

src/test/java/uk/co/evoco/webdriver/utils/WebDriverUtilsIT.java

@@ -5,11 +5,14 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.openqa.selenium.By;
+import org.openqa.selenium.StaleElementReferenceException;
+import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 import uk.co.evoco.tests.BaseAbstractTest;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 public class WebDriverUtilsIT extends BaseAbstractTest {
 
@@ -90,4 +93,12 @@ public void testCanClickOnHrefWithTolerantPollingWaitBeforeClickingHelperWhenEle
         ClickUtils.tolerantClick(element, 30);
         assertThat(webDriver.getCurrentUrl(), is("http://localhost:4442/hello-passed.html"));
     }
+
+    @Test
+    public void testCanClickOnHrefWithTolerantPollingWaitBeforeClickingHelperWhenElementIsDisabledAllTheTime() {
+        assertThrows(TimeoutException.class, () -> {
+            WebElement element = webDriver.findElement(By.id("clickutils-href-always-disabled"));
+            ClickUtils.tolerantClick(element, 5);
+        });
+    }
 }

src/test/resources/www/index.html

@@ -7,6 +7,9 @@
                 setTimeout(function() {
                     document.getElementById("clickutils-href-disabled").disabled = false;
                 }, 10000);
+                setTimeout(function() {
+                    document.getElementById("clickutils-staleelement").innerText("Text value has changed");
+                }, 1000);
             });
         </script>
     </head>
@@ -40,7 +43,9 @@
         </div>
         <div id="ClickUtils-elements">
             <a href="/hello-passed.html" id="clickutils-href">Click me</a>
-            <button onclick="window.location.href = '/hello-passed.html';" href="/hello-passed.html" id="clickutils-href-disabled" disabled>Click me</button>
+            <button onclick="window.location.href = '/hello-passed.html';" id="clickutils-href-disabled" disabled>Click me</button>
+            <button onclick="window.location.href = '/hello-passed.html';" id="clickutils-href-always-disabled" disabled>Click me</button>
+            <button onclick="window.location.href = '/hello-passed.html';" id="clickutils-staleelement">Click me</button>
         </div>
         <div id="WindowUtils-elements">
             <a id="out-of-viewport-link" href="hello-passed.html" stype="margin-top:2000px;">Link out of viewport on page load</a>