Skip to content

Commit be7467d

Browse files
author
travis-ci
committed
Addressing issues #21, #28, #24, #29 and #30. Adding some formatting for code to adhere to line length suggestions.
1 parent 0be86ca commit be7467d

25 files changed

+220
-41
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ dist: trusty
33
language: java
44

55
jdk:
6-
- openjdk12
6+
- openjdk8
77

88
cache:
99
directories:

pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
<jacoco.maven.plugin.version>0.8.5</jacoco.maven.plugin.version>
6666
<javadoc.maven.plugin.version>3.1.1</javadoc.maven.plugin.version>
6767
<joda.time.version>2.7</joda.time.version>
68+
<restassured.version>4.2.0</restassured.version>
6869
</properties>
6970

7071
<dependencies>
@@ -128,6 +129,11 @@
128129
<artifactId>junit-jupiter</artifactId>
129130
<version>${junit.jupiter.version}</version>
130131
</dependency>
132+
<dependency>
133+
<groupId>io.rest-assured</groupId>
134+
<artifactId>rest-assured</artifactId>
135+
<version>${restassured.version}</version>
136+
</dependency>
131137
<dependency>
132138
<groupId>org.hamcrest</groupId>
133139
<artifactId>hamcrest-library</artifactId>

src/main/java/uk/co/evoco/webdriver/configuration/ConfigurationLoader.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ public ConfigurationLoader decideWhichConfigurationToUse() {
3939
*/
4040
public WebDriverConfig build() {
4141
try {
42-
return JsonUtils.fromFile(FileLoaderUtils.loadFromClasspathOrFileSystem(targetConfigurationFile), WebDriverConfig.class);
42+
return JsonUtils.fromFile(
43+
FileLoaderUtils.loadFromClasspathOrFileSystem(targetConfigurationFile), WebDriverConfig.class);
4344
} catch (IOException e) {
4445
throw new RuntimeException("Unable to load configuration from " + targetConfigurationFile);
4546
}

src/main/java/uk/co/evoco/webdriver/configuration/WebDriverConfig.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ public void setWebDriverWaitTimeout(String webDriverWaitTimeout) {
8888
/**
8989
*
9090
* @param item the name of the key for which the value you want to retrieve
91-
* @return String returns the target item that exists in the list of open options that can be passed in the config file
91+
* @return String returns the target item that exists in the list of open options that can be passed in
92+
* the config file
9293
*/
9394
public String getTestConfigItem(String item) {
9495
return this.testConfig.get(item).textValue();
@@ -164,7 +165,8 @@ public List<String> getExceptionsToHandleOnTolerantActions() {
164165

165166
/**
166167
*
167-
* @param exceptionsToHandleOnTolerantActions sets the list of exceptions for WebDriver that we will retry on when using our tolerant wrapper
168+
* @param exceptionsToHandleOnTolerantActions sets the list of exceptions for WebDriver that we will retry
169+
* on when using our tolerant wrapper
168170
*/
169171
@JsonProperty("exceptionsToHandleOnTolerantActions")
170172
public void setExceptionsToHandleOnTolerantActions(List<String> exceptionsToHandleOnTolerantActions) {

src/main/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredChromeDriver.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ public class ConfiguredChromeDriver implements ConfiguredDriver {
1919
* @return WebDriver representing RemoteWebDriver grid
2020
*/
2121
public WebDriver getRemoteDriver() {
22-
return new RemoteWebDriver(TestConfigManager.getInstance().getWebDriverConfig().getGridConfig().getGridUrl(), this.getOptions());
22+
return new RemoteWebDriver(
23+
TestConfigManager.getInstance().getWebDriverConfig().getGridConfig().getGridUrl(), this.getOptions());
2324
}
2425

2526
/**

src/main/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredDriver.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ public interface ConfiguredDriver {
2525
* @param screenshotDirectory path to store screenshots
2626
* @return configured options object for target browser driver
2727
*/
28-
default EventFiringWebDriver configureEventFiringWebDriver(WebDriver webDriver, long timeout, File screenshotDirectory) {
28+
default EventFiringWebDriver configureEventFiringWebDriver(
29+
WebDriver webDriver, long timeout, File screenshotDirectory) {
2930
EventFiringWebDriver eventFiringWebDriver = new EventFiringWebDriver(webDriver);
3031
WebDriverListener eventListener = new WebDriverListener();
3132
eventListener.setWebdriverWaitTimeout(timeout);

src/main/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredEdgeDriver.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ public class ConfiguredEdgeDriver implements ConfiguredDriver {
1818
* @return WebDriver representing RemoteWebDriver grid
1919
*/
2020
public WebDriver getRemoteDriver() {
21-
return new RemoteWebDriver(TestConfigManager.getInstance().getWebDriverConfig().getGridConfig().getGridUrl(), this.getOptions());
21+
return new RemoteWebDriver(
22+
TestConfigManager.getInstance().getWebDriverConfig().getGridConfig().getGridUrl(), this.getOptions());
2223
}
2324

2425
/**

src/main/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredFirefoxDriver.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ public class ConfiguredFirefoxDriver implements ConfiguredDriver {
1919
* @return WebDriver representing RemoteWebDriver grid
2020
*/
2121
public WebDriver getRemoteDriver() {
22-
return new RemoteWebDriver(TestConfigManager.getInstance().getWebDriverConfig().getGridConfig().getGridUrl(), this.getOptions());
22+
return new RemoteWebDriver(
23+
TestConfigManager.getInstance().getWebDriverConfig().getGridConfig().getGridUrl(), this.getOptions());
2324
}
2425

2526
/**

src/main/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredInternetExplorerDriver.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ public class ConfiguredInternetExplorerDriver implements ConfiguredDriver {
1818
* @return WebDriver representing RemoteWebDriver grid
1919
*/
2020
public WebDriver getRemoteDriver() {
21-
return new RemoteWebDriver(TestConfigManager.getInstance().getWebDriverConfig().getGridConfig().getGridUrl(), this.getOptions());
21+
return new RemoteWebDriver(
22+
TestConfigManager.getInstance().getWebDriverConfig().getGridConfig().getGridUrl(), this.getOptions());
2223
}
2324

2425
/**

src/main/java/uk/co/evoco/webdriver/configuration/driver/ConfiguredSafariDriver.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ public class ConfiguredSafariDriver implements ConfiguredDriver {
1717
* @return WebDriver representing RemoteWebDriver grid
1818
*/
1919
public WebDriver getRemoteDriver() {
20-
return new RemoteWebDriver(TestConfigManager.getInstance().getWebDriverConfig().getGridConfig().getGridUrl(), this.getOptions());
20+
return new RemoteWebDriver(
21+
TestConfigManager.getInstance().getWebDriverConfig().getGridConfig().getGridUrl(), this.getOptions());
2122
}
2223

2324
/**

0 commit comments

Comments
 (0)