Ensure that language feature use and deprecated use is monitored

Author: adamretter

csv-validator-cmd/pom.xml

@@ -31,6 +31,8 @@
                     <useZincServer>true</useZincServer>          <!-- NOTE: if you have Zinc server installed and running, you can get faster compilation by enabling this -->
                     <args>
                         <arg>-Yrangepos</arg> <!-- recommended for Specs2 -->
+                        <arg>-feature</arg>
+                        <arg>-deprecation</arg>
                     </args>
                     <javacArgs>
                         <javacArg>-Xlint:unchecked</javacArg>

csv-validator-core/pom.xml

@@ -32,6 +32,8 @@
                     <useZincServer>true</useZincServer>          <!-- NOTE: if you have Zinc server installed and running, you can get faster compilation by enabling this -->
                     <args>
                         <arg>-Yrangepos</arg> <!-- recommended for Specs2 -->
+                        <arg>-feature</arg>
+                        <arg>-deprecation</arg>
                     </args>
                     <javacArgs>
                         <javacArg>-Xlint:unchecked</javacArg>
@@ -79,6 +81,10 @@
                     </includes>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-surefire-report-plugin</artifactId>
+            </plugin>
         </plugins>
     </build>
 

csv-validator-core/src/main/scala/uk/gov/nationalarchives/csv/validator/MetaDataValidator.scala

@@ -11,7 +11,7 @@ package uk.gov.nationalarchives.csv.validator
 
 import uk.gov.nationalarchives.utf8.validator.{Utf8Validator, ValidationHandler}
 
-import scala.language.postfixOps
+import scala.language.{postfixOps, reflectiveCalls}
 import scala.util.Try
 import scalaz._, Scalaz._
 import java.io.{IOException, Reader => JReader, InputStreamReader => JInputStreamReader, FileInputStream => JFileInputStream, LineNumberReader => JLineNumberReader}

csv-validator-core/src/main/scala/uk/gov/nationalarchives/csv/validator/Util.scala

@@ -8,7 +8,7 @@
  */
 package uk.gov.nationalarchives.csv.validator
 
-import scala.collection.mutable
+import scala.language.postfixOps
 import scalax.file.Path
 import scalaz._
 import Scalaz._

csv-validator-core/src/main/scala/uk/gov/nationalarchives/csv/validator/schema/v1_0/Rule.scala

@@ -384,7 +384,7 @@ case class ChecksumRule(rootPath: ArgProvider, file: ArgProvider, algorithm: Str
         .pipe(getHash(algorithm))
         .map(_.toHex)
         .runLast
-        .attemptRun
+        .unsafePerformSyncAttempt
         .validation
         .leftMap(_.getMessage)
         .rightMap(_.getOrElse("NO CHECKSUM"))

csv-validator-core/src/main/scala/uk/gov/nationalarchives/csv/validator/schema/v1_0/SchemaParser.scala

@@ -10,6 +10,7 @@ package uk.gov.nationalarchives.csv.validator.schema.v1_0
 
 import java.io.Reader
 
+import scala.language.reflectiveCalls
 import uk.gov.nationalarchives.csv.validator.schema.{SchemaParser => BaseSchemaParser, _}
 
 /**

csv-validator-core/src/main/scala/uk/gov/nationalarchives/csv/validator/schema/v1_1/SchemaParser.scala

@@ -8,6 +8,7 @@
  */
 package uk.gov.nationalarchives.csv.validator.schema.v1_1
 
+import scala.language.reflectiveCalls
 import uk.gov.nationalarchives.csv.validator.schema.v1_0.{SchemaParser => SchemaParser1_0}
 import uk.gov.nationalarchives.csv.validator.schema._
 

csv-validator-core/src/test/scala/uk/gov/nationalarchives/csv/validator/MetaDataValidatorSpec.scala

@@ -8,6 +8,7 @@
  */
 package uk.gov.nationalarchives.csv.validator
 
+import scala.language.reflectiveCalls
 import org.junit.runner.RunWith
 import org.specs2.mutable.Specification
 import org.specs2.runner.JUnitRunner

csv-validator-java-api/pom.xml

@@ -29,6 +29,10 @@
                 <configuration>
                     <recompileMode>incremental</recompileMode>   <!-- NOTE: incremental compilation although faster requires passing to MAVEN_OPTS="-XX:MaxPermSize=128m" -->
                     <useZincServer>true</useZincServer>          <!-- NOTE: if you have Zinc server installed and running, you can get faster compilation by enabling this -->
+                    <args>
+                        <arg>-feature</arg>
+                        <arg>-deprecation</arg>
+                    </args>
                     <javacArgs>
                         <javacArg>-Xlint:unchecked</javacArg>
                         <javacArg>-Xlint:deprecation</javacArg>

csv-validator-parent/pom.xml

@@ -130,6 +130,11 @@
                     <artifactId>maven-surefire-plugin</artifactId>
                     <version>2.19.1</version>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-surefire-report-plugin</artifactId>
+                    <version>2.19.1</version>
+                </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-javadoc-plugin</artifactId>