printing error message when using non-valid image size (#164)

Author: digitalghost-dev

cmd/pokemon/pokemon.go

@@ -104,8 +104,8 @@ func PokemonCommand() (string, error) {
 
 		// Call the ImageFlag function with the specified size
 		if err := flags.ImageFlag(&output, endpoint, pokemonName, size); err != nil {
-			output.WriteString(fmt.Sprintf("error parsing flags: %v\n", err))
-			return "", fmt.Errorf("error parsing flags: %w", err)
+			output.WriteString(fmt.Sprintf("%v\n", err))
+			return output.String(), fmt.Errorf("%w", err)
 		}
 	}
 

cmd/pokemon/pokemon_test.go

@@ -25,7 +25,7 @@ func TestPokemonCommand(t *testing.T) {
 		name           string
 		args           []string
 		expectedOutput string
-		wantError      bool
+		expectedError  bool
 	}{
 		{
 			name:           "Pokemon help flag",
@@ -43,10 +43,22 @@ func TestPokemonCommand(t *testing.T) {
 			expectedOutput: utils.LoadGolden(t, "pokemon_image.golden"),
 		},
 		{
-			name:           "Pokemon invalid image flag",
+			name:           "Pokemon image flag missing size",
 			args:           []string{"pokemon", "tryanitar", "--image="},
-			expectedOutput: utils.LoadGolden(t, "pokemon_invalid_image_flag.golden"),
-			wantError:      true,
+			expectedOutput: utils.LoadGolden(t, "pokemon_image_flag_missing_size.golden"),
+			expectedError:  true,
+		},
+		{
+			name:           "Pokemon image flag non-valid size",
+			args:           []string{"pokemon", "floatzel", "--image=xl"},
+			expectedOutput: utils.LoadGolden(t, "pokemon_image_flag_non-valid_size.golden"),
+			expectedError:  true,
+		},
+		{
+			name:           "Pokemon image flag empty flag",
+			args:           []string{"pokemon", "gastly", "--"},
+			expectedOutput: utils.LoadGolden(t, "pokemon_image_flag_empty_flag.golden"),
+			expectedError:  true,
 		},
 		{
 			name:           "Pokemon stats flag",