updating tests

Author: digitalghost-dev

card_data/pipelines/defs/extract/testing.py

@@ -1,7 +1,7 @@
 import pytest
 import polars as pl
 import responses
-from extract_data import extract_series_data
+from .extract_data import extract_series_data
 
 @pytest.fixture
 def mock_api_response():

cmd/card/cardlist.go

@@ -101,7 +101,7 @@ type cardData struct {
 // CardsList creates and returns a new CardsModel with cards from a specific set
 func CardsList(setID string) (CardsModel, error) {
 	url := fmt.Sprintf("https://uoddayfnfkebrijlpfbh.supabase.co/rest/v1/card_pricing_view?set_id=eq.%s&select=number_plus_name,market_price,image_url,illustrator&order=localId", setID)
-	body, err := CallCardData(url)
+	body, err := getCardData(url)
 	if err != nil {
 		return CardsModel{}, fmt.Errorf("failed to fetch card data: %w", err)
 	}
@@ -159,6 +159,9 @@ func CardsList(setID string) (CardsModel, error) {
 	}, nil
 }
 
+// creating a function variable to swap the implementation in tests
+var getCardData = CallCardData
+
 func CallCardData(url string) ([]byte, error) {
 	req, err := http.NewRequest("GET", url, nil)
 	if err != nil {

cmd/card/cardlist_test.go

@@ -1,6 +1,7 @@
 package card
 
 import (
+	"errors"
 	"strings"
 	"testing"
 
@@ -254,3 +255,113 @@ func TestCardsModel_View_MissingPrice(t *testing.T) {
 		t.Error("View() should display 'Price: Not available' for cards without pricing")
 	}
 }
+
+func TestCardsList_SuccessAndFallbacks(t *testing.T) {
+	// Save and restore getCardData stub
+	original := getCardData
+	defer func() { getCardData = original }()
+
+	var capturedURL string
+	getCardData = func(url string) ([]byte, error) {
+		capturedURL = url
+		// Return two cards: one with price + illustrator, one with fallbacks
+		json := `[
+            {"number_plus_name":"001/198 - Bulbasaur","market_price":1.5,"image_url":"https://example.com/bulba.png","illustrator":"Ken Sugimori"},
+            {"number_plus_name":"002/198 - Ivysaur","market_price":0,"image_url":"https://example.com/ivy.png","illustrator":""}
+        ]`
+		return []byte(json), nil
+	}
+
+	model, err := CardsList("set123")
+	if err != nil {
+		t.Fatalf("CardsList returned error: %v", err)
+	}
+
+	// URL should target the correct set id and select fields
+	if !strings.Contains(capturedURL, "set_id=eq.set123") {
+		t.Errorf("expected URL to contain set_id filter, got %s", capturedURL)
+	}
+	if !strings.Contains(capturedURL, "select=number_plus_name,market_price,image_url,illustrator") {
+		t.Errorf("expected URL to contain select fields, got %s", capturedURL)
+	}
+
+	// PriceMap expectations
+	if got := model.PriceMap["001/198 - Bulbasaur"]; got != "Price: $1.50" {
+		t.Errorf("unexpected price for Bulbasaur: %s", got)
+	}
+	if got := model.PriceMap["002/198 - Ivysaur"]; got != "Pricing not available" {
+		t.Errorf("unexpected price for Ivysaur: %s", got)
+	}
+
+	// IllustratorMap expectations
+	if got := model.IllustratorMap["001/198 - Bulbasaur"]; got != "Illustrator: Ken Sugimori" {
+		t.Errorf("unexpected illustrator for Bulbasaur: %s", got)
+	}
+	if got := model.IllustratorMap["002/198 - Ivysaur"]; got != "Illustrator not available" {
+		t.Errorf("unexpected illustrator for Ivysaur: %s", got)
+	}
+
+	// Image map
+	if model.ImageMap["001/198 - Bulbasaur"] != "https://example.com/bulba.png" {
+		t.Errorf("unexpected image url for Bulbasaur: %s", model.ImageMap["001/198 - Bulbasaur"])
+	}
+	if model.ImageMap["002/198 - Ivysaur"] != "https://example.com/ivy.png" {
+		t.Errorf("unexpected image url for Ivysaur: %s", model.ImageMap["002/198 - Ivysaur"])
+	}
+
+	if row := model.Table.SelectedRow(); len(row) == 0 {
+		if model.View() == "" {
+			t.Error("model view should render even if no row is selected")
+		}
+	}
+}
+
+func TestCardsList_FetchError(t *testing.T) {
+	original := getCardData
+	defer func() { getCardData = original }()
+
+	getCardData = func(url string) ([]byte, error) {
+		return nil, errors.New("network error")
+	}
+
+	_, err := CardsList("set123")
+	if err == nil {
+		t.Fatal("expected error when fetch fails")
+	}
+}
+
+func TestCardsList_BadJSON(t *testing.T) {
+	original := getCardData
+	defer func() { getCardData = original }()
+
+	getCardData = func(url string) ([]byte, error) {
+		return []byte("not-json"), nil
+	}
+
+	_, err := CardsList("set123")
+	if err == nil {
+		t.Fatal("expected error for bad JSON payload")
+	}
+}
+
+func TestCardsList_EmptyResult(t *testing.T) {
+	original := getCardData
+	defer func() { getCardData = original }()
+
+	getCardData = func(url string) ([]byte, error) {
+		return []byte("[]"), nil
+	}
+
+	model, err := CardsList("set123")
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+
+	if len(model.PriceMap) != 0 || len(model.IllustratorMap) != 0 || len(model.ImageMap) != 0 {
+		t.Errorf("expected empty maps, got price:%d illus:%d image:%d", len(model.PriceMap), len(model.IllustratorMap), len(model.ImageMap))
+	}
+
+	if model.View() == "" {
+		t.Error("expected view to render with empty data")
+	}
+}

cmd/card/serieslist_test.go

@@ -142,3 +142,26 @@ func TestSeriesModelView(t *testing.T) {
 		t.Errorf("Expected non-empty view for choice, got empty string")
 	}
 }
+
+func TestSeriesList(t *testing.T) {
+	model := SeriesList()
+	items := model.List.Items()
+
+	// Check that list has 3 items
+	if items == nil {
+		t.Error("SeriesList() should create a list with items")
+	}
+
+	if len(items) != 3 {
+		t.Errorf("Expected 3 items, got %d", len(items))
+	}
+
+	// Verify all three series are present
+	expectedSeries := []string{"Mega Evolution", "Scarlet & Violet", "Sword & Shield"}
+	for i, expected := range expectedSeries {
+		itemStr := string(items[i].(item))
+		if itemStr != expected {
+			t.Errorf("Expected item %d to be '%s', got '%s'", i, expected, itemStr)
+		}
+	}
+}