updating testability

Author: digitalghost-dev

flags/version.go

@@ -11,24 +11,22 @@ import (
 	"runtime"
 )
 
-func latestDockerImage() {
+type commandRunner func(name string, args ...string) *exec.Cmd
+
+func latestDockerImage(run commandRunner) {
 	var cmd *exec.Cmd
 
 	if runtime.GOOS == "windows" {
-		// Windows PowerShell equivalent
-		cmd = exec.Command("powershell", "-Command", `
-			$tags = Invoke-RestMethod -Uri "https://hub.docker.com/v2/repositories/digitalghostdev/poke-cli/tags/?page_size=1";
-			$tags.results[0].name
-		`)
+		cmd = run("powershell", "-Command", `
+            $tags = Invoke-RestMethod -Uri "https://hub.docker.com/v2/repositories/digitalghostdev/poke-cli/tags/?page_size=1";
+            $tags.results[0].name
+        `)
 	} else {
-		// Check if curl is available
 		_, err := exec.LookPath("curl")
 		if err == nil {
-			// Use curl if available
-			cmd = exec.Command("sh", "-c", `curl -s https://hub.docker.com/v2/repositories/digitalghostdev/poke-cli/tags/?page_size=1 | grep -o '"name":"[^"]*"' | cut -d '"' -f 4`)
+			cmd = run("sh", "-c", `curl -s https://hub.docker.com/v2/repositories/digitalghostdev/poke-cli/tags/?page_size=1 | grep -o '"name":"[^"]*"' | cut -d '"' -f 4`)
 		} else {
-			// Use wget as a fallback
-			cmd = exec.Command("sh", "-c", `wget -qO- https://hub.docker.com/v2/repositories/digitalghostdev/poke-cli/tags/?page_size=1 | grep -o '"name":"[^"]*"' | cut -d '"' -f 4`)
+			cmd = run("sh", "-c", `wget -qO- https://hub.docker.com/v2/repositories/digitalghostdev/poke-cli/tags/?page_size=1 | grep -o '"name":"[^"]*"' | cut -d '"' -f 4`)
 		}
 	}
 
@@ -90,6 +88,6 @@ func latestRelease(githubAPIURL string) {
 
 func LatestFlag() {
 	// cmd := exec.Command("git", "describe", "--tags", "--abbrev=0")
-	latestDockerImage()
+	latestDockerImage(exec.Command)
 	latestRelease("https://api.github.com/repos/digitalghost-dev/poke-cli/releases/latest")
 }

flags/version_test.go

@@ -7,7 +7,7 @@ import (
 	"net/http"
 	"net/http/httptest"
 	"os"
-	"runtime"
+	"os/exec"
 	"testing"
 )
 
@@ -36,17 +36,38 @@ func captureOutput(f func()) string {
 }
 
 func TestLatestDockerImage(t *testing.T) {
-	output := captureOutput(func() { latestDockerImage() })
-
-	assert.Contains(t, output, "Latest Docker image version:")
+	tests := []struct {
+		name        string
+		mockRunner  func(name string, args ...string) *exec.Cmd
+		expectError bool
+		expectText  string
+	}{
+		{
+			name: "success",
+			mockRunner: func(name string, args ...string) *exec.Cmd {
+				return exec.Command("echo", "v1.0.0\n")
+			},
+			expectError: false,
+			expectText:  "Latest Docker image version: v1.0.0",
+		},
+		{
+			name: "error from command",
+			mockRunner: func(name string, args ...string) *exec.Cmd {
+				return exec.Command("false") // returns error
+			},
+			expectError: true,
+			expectText:  "Error running command",
+		},
+	}
 
-	// Since the actual API response might change, avoid testing the exact version number.
-	// Instead, check if a non-empty version string is printed.
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			output := captureOutput(func() {
+				latestDockerImage(tt.mockRunner)
+			})
 
-	if runtime.GOOS == "windows" {
-		assert.Contains(t, output, "\n")
-	} else {
-		assert.Contains(t, output, "\n")
+			assert.Contains(t, output, tt.expectText)
+		})
 	}
 }