Merge pull request #228 from digitalghost-dev/1.8.5

1.8.5

Author: digitalghost-dev

.github/workflows/codspeed.yml

@@ -1,5 +1,10 @@
 name: Codspeed Benchmarks
 on:
+  push:
+    branches:
+      - main
+    paths:
+      - 'card_data/**'
   pull_request:
     types: [ opened, reopened, synchronize ]
     paths:
@@ -26,7 +31,7 @@ jobs:
           python-version: '3.12'
 
       - name: Install uv
-        uses: astral-sh/setup-uv@v4
+        uses: astral-sh/setup-uv@v7
 
       - name: Install dependencies
         run: uv sync --dev

.github/workflows/go_test.yml

@@ -1,4 +1,4 @@
-name: Test
+name: Golang Tests
 
 on:
   pull_request:
@@ -13,7 +13,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v6
 
-      - name: Set up Go
+      - name: Setup Go
         uses: actions/setup-go@v5
         with:
           go-version: 1.24

card_data/pipelines/definitions.py

@@ -6,6 +6,7 @@
 
 from .defs.extract.tcgcsv.extract_pricing import build_dataframe
 from .defs.load.tcgcsv.load_pricing import load_pricing_data, data_quality_checks_on_pricing
+from .sensors import discord_success_sensor, discord_failure_sensor
 
 
 @definitions
@@ -31,4 +32,5 @@ def defs() -> dg.Definitions:
     assets=[build_dataframe, load_pricing_data, data_quality_checks_on_pricing],
     jobs=[pricing_pipeline_job],
     schedules=[price_schedule],
+    sensors=[discord_success_sensor, discord_failure_sensor]
 )

card_data/pipelines/sensors.py

@@ -0,0 +1,40 @@
+import requests
+from dagster import DagsterRunStatus, RunStatusSensorContext, run_status_sensor
+
+from .utils.secret_retriever import fetch_n8n_webhook_secret
+
+
+@run_status_sensor(run_status=DagsterRunStatus.SUCCESS, name="discord_success_sensor")
+def discord_success_sensor(context: RunStatusSensorContext):
+    context.log.info(f"Detected successful run: {context.dagster_run.run_id}")
+    try:
+        response = requests.post(
+            fetch_n8n_webhook_secret(),
+            json={
+                "job_name": context.dagster_run.job_name,
+                "status": "SUCCESS",
+                "run_id": context.dagster_run.run_id,
+            },
+            timeout=10,
+        )
+        context.log.info(f"n8n response: {response.status_code}")
+    except Exception as e:
+        context.log.error(f"Failed to send notification: {e}")
+
+
+@run_status_sensor(run_status=DagsterRunStatus.FAILURE, name="discord_failure_sensor")
+def discord_failure_sensor(context: RunStatusSensorContext):
+    context.log.info(f"Detected failed run: {context.dagster_run.run_id}")
+    try:
+        response = requests.post(
+            fetch_n8n_webhook_secret(),
+            json={
+                "job_name": context.dagster_run.job_name,
+                "status": "FAILURE",
+                "run_id": context.dagster_run.run_id,
+            },
+            timeout=10,
+        )
+        context.log.info(f"n8n response: {response.status_code}")
+    except Exception as e:
+        context.log.error(f"Failed to send notification: {e}")

card_data/pipelines/utils/secret_retriever.py

@@ -21,3 +21,14 @@ def fetch_secret() -> str:
     secret_dict: SupabaseSecret = json.loads(secret)
 
     return secret_dict["database_uri"]
+
+
+def fetch_n8n_webhook_secret() -> str:
+    client = botocore.session.get_session().create_client("secretsmanager")
+    cache_config = SecretCacheConfig()
+    cache = SecretCache(config=cache_config, client=client)
+
+    secret = cast(str, cache.get_secret_string("n8n_webhook"))
+    secret_dict: dict[str, str] = json.loads(secret)
+
+    return secret_dict["n8n_webhook"]

cli.go

@@ -80,7 +80,7 @@ func runCLI(args []string) int {
 			fmt.Sprintf("\n\t%-15s %s", "search", "Search for a resource"),
 			fmt.Sprintf("\n\t%-15s %s", "speed", "Calculate the speed of a Pokémon in battle"),
 			fmt.Sprintf("\n\t%-15s %s", "types", "Get details about a typing"),
-			"\n\n", styling.StyleItalic.Render("hint: when calling a resource with a space, use a hyphen"),
+			"\n\n", styling.StyleItalic.Render(styling.HyphenHint),
 			"\n", styling.StyleItalic.Render("example: poke-cli ability strong-jaw"),
 			"\n", styling.StyleItalic.Render("example: poke-cli pokemon flutter-mane"),
 			"\n\n", fmt.Sprintf("%s %s", "↓ ctrl/cmd + click for docs/guides\n", styling.DocsLink),

cmd/ability/ability.go

@@ -10,8 +10,6 @@ import (
 	"github.com/digitalghost-dev/poke-cli/connections"
 	"github.com/digitalghost-dev/poke-cli/flags"
 	"github.com/digitalghost-dev/poke-cli/styling"
-	"golang.org/x/text/cases"
-	"golang.org/x/text/language"
 )
 
 func AbilityCommand() (string, error) {
@@ -22,7 +20,7 @@ func AbilityCommand() (string, error) {
 			"Get details about a specific ability.\n\n",
 			styling.StyleBold.Render("USAGE:"),
 			fmt.Sprintf("\n\t%s %s %s %s", "poke-cli", styling.StyleBold.Render("ability"), "<ability-name>", "[flag]"),
-			fmt.Sprintf("\n\t%-30s", styling.StyleItalic.Render("Use a hyphen when typing a name with a space.")),
+			fmt.Sprintf("\n\t%-30s", styling.StyleItalic.Render(styling.HyphenHint)),
 			"\n\n",
 			styling.StyleBold.Render("FLAGS:"),
 			fmt.Sprintf("\n\t%-30s %s", "-p, --pokemon", "Prints Pokémon that learn this ability."),
@@ -35,13 +33,12 @@ func AbilityCommand() (string, error) {
 
 	args := os.Args
 
-	flag.Parse()
-
-	if len(os.Args) == 3 && (os.Args[2] == "-h" || os.Args[2] == "--help") {
-		flag.Usage()
+	if utils.CheckHelpFlag(&output, flag.Usage) {
 		return output.String(), nil
 	}
 
+	flag.Parse()
+
 	if err := utils.ValidateAbilityArgs(args); err != nil {
 		output.WriteString(err.Error())
 		return output.String(), err
@@ -81,7 +78,7 @@ func AbilityCommand() (string, error) {
 		}
 	}
 
-	capitalizedAbility := cases.Title(language.English).String(strings.ReplaceAll(abilityName, "-", " "))
+	capitalizedAbility := styling.CapitalizeResourceName(abilityName)
 	output.WriteString(styling.StyleBold.Render(capitalizedAbility) + "\n")
 
 	generationParts := strings.Split(abilitiesStruct.Generation.Name, "-")

cmd/ability/ability_test.go

@@ -31,6 +31,11 @@ func TestAbilityCommand(t *testing.T) {
 			args:           []string{"ability", "clear-body"},
 			expectedOutput: utils.LoadGolden(t, "ability.golden"),
 		},
+		{
+			name:           "Ability command: beads-of-ruin",
+			args:           []string{"ability", "beads-of-ruin"},
+			expectedOutput: utils.LoadGolden(t, "ability-ii.golden"),
+		},
 		{
 			name:           "Misspelled ability name",
 			args:           []string{"ability", "bulletproff"},

cmd/berry/berry.go

@@ -30,14 +30,12 @@ func BerryCommand() (string, error) {
 		output.WriteString(helpMessage)
 	}
 
-	flag.Parse()
-
-	// Handle help flag
-	if len(os.Args) == 3 && (os.Args[2] == "-h" || os.Args[2] == "--help") {
-		flag.Usage()
+	if utils.CheckHelpFlag(&output, flag.Usage) {
 		return output.String(), nil
 	}
 
+	flag.Parse()
+
 	// Validate arguments
 	if err := utils.ValidateBerryArgs(os.Args); err != nil {
 		output.WriteString(err.Error())

cmd/card/card.go

@@ -26,14 +26,12 @@ func CardCommand() (string, error) {
 		output.WriteString(helpMessage)
 	}
 
-	flag.Parse()
-
-	// Handle help flag
-	if len(os.Args) == 3 && (os.Args[2] == "-h" || os.Args[2] == "--help") {
-		flag.Usage()
+	if utils.CheckHelpFlag(&output, flag.Usage) {
 		return output.String(), nil
 	}
 
+	flag.Parse()
+
 	// Validate arguments
 	if err := utils.ValidateCardArgs(os.Args); err != nil {
 		output.WriteString(err.Error())