updating tests

Author: digitalghost-dev

cmd/natures_test.go

@@ -2,32 +2,32 @@ package cmd
 
 import (
 	"bytes"
-	"fmt"
 	"github.com/digitalghost-dev/poke-cli/styling"
 	"github.com/stretchr/testify/assert"
 	"os"
 	"testing"
 )
 
+var exitCode int
+
+func fakeExit(code int) {
+	exitCode = code
+	panic("exit")
+}
+
 func captureNaturesOutput(f func()) string {
 	r, w, _ := os.Pipe()
-	defer func(r *os.File) {
-		err := r.Close()
-		if err != nil {
-			fmt.Println(err)
-		}
-	}(r)
+	defer func() {
+		_ = r.Close()
+	}()
 
 	oldStdout := os.Stdout
 	os.Stdout = w
 	defer func() { os.Stdout = oldStdout }()
 
 	f()
 
-	err := w.Close()
-	if err != nil {
-		return ""
-	}
+	_ = w.Close()
 
 	var buf bytes.Buffer
 	_, _ = buf.ReadFrom(r)
@@ -53,24 +53,59 @@ func TestNaturesCommand(t *testing.T) {
 					"╰──────────────────────────────╯\n"),
 			expectedError: false,
 		},
+		{
+			name:           "Invalid extra argument",
+			args:           []string{"natures", "extra"},
+			expectedOutput: styling.StripANSI(styling.ErrorBorder.Render(styling.ErrorColor.Render("Error!")+"\nThe only currently available options\nafter <natures> command are '-h' or '--help'")) + "\n",
+			expectedError:  true,
+		},
+		{
+			name: "Full Natures output with table",
+			args: []string{"natures"},
+			expectedOutput: `Natures affect the growth of a Pokémon.
+				Each nature increases one of its stats by 10% and decreases one by 10%.
+				Five natures increase and decrease the same stat and therefore have no effect.
+				
+				Nature Chart:
+				┌──────────┬─────────┬──────────┬──────────┬──────────┬─────────┐
+				│          │ -Attack │ -Defense │ -Sp. Atk │ -Sp. Def │ Speed   │
+				├──────────┼─────────┼──────────┼──────────┼──────────┼─────────┤
+				│ +Attack  │ Hardy   │ Lonely   │ Adamant  │ Naughty  │ Brave   │
+				├──────────┼─────────┼──────────┼──────────┼──────────┼─────────┤
+				│ +Defense │ Bold    │ Docile   │ Impish   │ Lax      │ Relaxed │
+				├──────────┼─────────┼──────────┼──────────┼──────────┼─────────┤
+				│ +Sp. Atk │ Modest  │ Mild     │ Bashful  │ Rash     │ Quiet   │
+				├──────────┼─────────┼──────────┼──────────┼──────────┼─────────┤
+				│ +Sp. Def │ Calm    │ Gentle   │ Careful  │ Quirky   │ Sassy   │
+				├──────────┼─────────┼──────────┼──────────┼──────────┼─────────┤
+				│ Speed    │ Timid   │ Hasty    │ Jolly    │ Naive    │ Serious │
+				└──────────┴─────────┴──────────┴──────────┴──────────┴─────────┘
+				`,
+			expectedError: false,
+		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			// Override osExit
+			oldExit := osExit
+			osExit = fakeExit
+			defer func() { osExit = oldExit }()
+
+			// Reset captured exit code
+			exitCode = 0
+
 			// Save original os.Args
 			originalArgs := os.Args
 			defer func() { os.Args = originalArgs }()
-
-			// Set os.Args for the test
 			os.Args = append([]string{"poke-cli"}, tt.args...)
 
-			// Capture the output
+			// Capture output
 			output := captureNaturesOutput(func() {
 				defer func() {
-					// Recover from os.Exit calls
 					if r := recover(); r != nil {
-						if !tt.expectedError {
-							t.Fatalf("Unexpected error: %v", r)
+						if r != "exit" {
+							t.Fatalf("Unexpected panic: %v", r)
 						}
 					}
 				}()
@@ -79,7 +114,17 @@ func TestNaturesCommand(t *testing.T) {
 
 			cleanOutput := styling.StripANSI(output)
 
-			assert.Equal(t, tt.expectedOutput, cleanOutput, "Output should equal the expected string")
+			// Logging expected vs actual
+			t.Logf("Expected Output:\n%s", tt.expectedOutput)
+			t.Logf("Actual Output:\n%s", cleanOutput)
+
+			// Assertions
+			assert.Equal(t, tt.expectedOutput, cleanOutput, "Output should match expected")
+			if tt.expectedError {
+				assert.Equal(t, 1, exitCode, "Expected exit code 1 on error")
+			} else {
+				assert.Equal(t, 0, exitCode, "Expected no exit (code 0) on success")
+			}
 		})
 	}
 }