improving error handling to flags.LatestFlag() (#198)

Author: digitalghost-dev

cli.go

@@ -130,7 +130,10 @@ func runCLI(args []string) int {
 		mainFlagSet.Usage()
 		return 1
 	case *latestFlag || *shortLatestFlag:
-		_, _ = flags.LatestFlag()
+		_, err := flags.LatestFlag()
+		if err != nil {
+			return 1
+		}
 		return 0
 	case *currentVersionFlag || *shortCurrentVersionFlag:
 		currentVersion()

flags/version.go

@@ -16,58 +16,62 @@ import (
 func LatestFlag() (string, error) {
 	var output strings.Builder
 
-	latestRelease(&output)
+	err := latestRelease(&output)
 
 	result := output.String()
 	fmt.Print(result)
 
-	return result, nil
+	return result, err
 }
 
-func latestRelease(output *strings.Builder) {
+func latestRelease(output *strings.Builder) error {
 	type Release struct {
 		TagName string `json:"tag_name"`
 	}
 
-	// Parse and validate the URL
 	parsedURL, err := url.Parse("https://api.github.com/repos/digitalghost-dev/poke-cli/releases/latest")
 	if err != nil {
-		fmt.Fprintf(output, "invalid URL: %v\n", err)
-		return
+		err = fmt.Errorf("invalid URL: %w", err)
+		fmt.Fprintln(output, err)
+		return err
 	}
 
-	// Implementing gosec error
 	if flag.Lookup("test.v") == nil {
 		if parsedURL.Scheme != "https" {
-			fmt.Fprint(output, "only HTTPS URLs are allowed for security reasons\n")
-			return
+			err := fmt.Errorf("only HTTPS URLs are allowed for security reasons")
+			fmt.Fprintln(output, err)
+			return err
 		}
 		if parsedURL.Host != "api.github.com" {
-			fmt.Fprint(output, "url host is not allowed\n")
-			return
+			err := fmt.Errorf("url host is not allowed")
+			fmt.Fprintln(output, err)
+			return err
 		}
 	}
 
 	response, err := http.Get(parsedURL.String())
 	if err != nil {
-		fmt.Fprintf(output, "error fetching data: %v\n", err)
-		return
+		err = fmt.Errorf("error fetching data: %w", err)
+		fmt.Fprintln(output, err)
+		return err
 	}
 	defer response.Body.Close()
 
 	body, err := io.ReadAll(response.Body)
 	if err != nil {
-		fmt.Fprintf(output, "error reading response body: %v\n", err)
-		return
+		err = fmt.Errorf("error reading response body: %w", err)
+		fmt.Fprintln(output, err)
+		return err
 	}
 
 	var release Release
 	if err := json.Unmarshal(body, &release); err != nil {
-		fmt.Fprintf(output, "error unmarshalling JSON: %v\n", err)
-		return
+		err = fmt.Errorf("error unmarshalling JSON: %w", err)
+		fmt.Fprintln(output, err)
+		return err
 	}
 
-	releaseString := "Latest available version:"
+	releaseString := "Latest available release on GitHub:"
 	releaseTag := styling.ColoredBullet.Render("") + release.TagName
 
 	docStyle := lipgloss.NewStyle().
@@ -80,4 +84,6 @@ func latestRelease(output *strings.Builder) {
 
 	output.WriteString(docStyle.Render(fullDoc))
 	output.WriteString("\n")
+
+	return nil
 }

flags/version_test.go

@@ -32,11 +32,13 @@ func TestLatestVersionFlag(t *testing.T) {
 			name:           "Get latest version with short flag",
 			args:           []string{"-l"},
 			expectedOutput: utils.LoadGolden(t, "main_latest_flag.golden"),
+			expectedError:  false,
 		},
 		{
 			name:           "Get latest version with long flag",
 			args:           []string{"--latest"},
 			expectedOutput: utils.LoadGolden(t, "main_latest_flag.golden"),
+			expectedError:  false,
 		},
 	}
 
@@ -46,9 +48,15 @@ func TestLatestVersionFlag(t *testing.T) {
 			os.Args = append([]string{"poke-cli"}, tt.args...)
 			defer func() { os.Args = originalArgs }()
 
-			output, _ := LatestFlag()
+			output, err := LatestFlag()
 			cleanOutput := styling.StripANSI(output)
 
+			if tt.expectedError {
+				assert.Error(t, err, "Expected an error")
+			} else {
+				assert.NoError(t, err, "Expected no error")
+			}
+
 			assert.Equal(t, tt.expectedOutput, cleanOutput, "Output should match expected")
 		})
 	}