DODX-13917: Undo final Twitter Markdown URL to twitter.com, instead of x.com (#138)

* Undo final Twitter Markdown URL to `twitter.com`

* Fixed README.md file content

---------

Co-authored-by: rdalal-do <rohitdalal67@gmail.com>

Author: rdalal-do

README.md

@@ -726,11 +726,11 @@ _No options are available for this plugin._
 ### twitter
 
 <details>
-<summary>Add support for <a href="https://x.com/">X</a> embeds in Markdown, as block syntax.</summary>
+<summary>Add support for <a href="https://twitter.com/">X</a> embeds in Markdown, as block syntax.</summary>
 
 The basic syntax is `[twitter <tweet>]`.
 E.g. `[twitter https://twitter.com/MattIPv4/status/1576415168426573825]`.
-Input may use either the legacy `twitter.com` or the new `x.com` domain; both are accepted.
+Input may use either `twitter.com` or `x.com` domain for the tweet.
 After the tweet, assorted space-separated flags can be added (in any combination/order):
 
 - Add `light` or `dark` to set the card theme (default is `light`).
@@ -753,13 +753,13 @@ If a width outside the range of 250-550 is selected, a clamped value will be use
 
     <div class="twitter">
         <blockquote class="twitter-tweet" data-dnt="true" data-width="550" data-theme="light">
-            <a href="https://x.com/MattIPv4/status/1576415168426573825">View tweet by @MattIPv4</a>
+            <a href="https://twitter.com/MattIPv4/status/1576415168426573825">View tweet by @MattIPv4</a>
         </blockquote>
     </div>
 
     <div class="twitter" align="left">
         <blockquote class="twitter-tweet" data-dnt="true" data-width="400" data-theme="dark">
-            <a href="https://x.com/MattIPv4/status/1576415168426573825">View tweet by @MattIPv4</a>
+            <a href="https://twitter.com/MattIPv4/status/1576415168426573825">View tweet by @MattIPv4</a>
         </blockquote>
     </div>
     <script async defer src="https://platform.twitter.com/widgets.js" type="text/javascript"></script>

fixtures/full-input.md

@@ -333,8 +333,9 @@ Embedding a terminal recording from Asciinema (id, cols, rows):
 
 You can also embed a tweet from Twitter by passing the URL for the tweet:
 
-[twitter https://x.com/MattIPv4/status/1576415168426573825]
+[twitter https://twitter.com/MattIPv4/status/1576415168426573825]
 
+Input may use either `twitter.com` or `x.com` domain
 Like a few other embeds, you can also pass optional flags to customize the embed:
 
 - Pass any integer value (between 250 and 550) to set a custom width for the embed (e.g. `[twitter https://twitter.com/MattIPv4/status/1576415168426573825 400]`)

fixtures/full-output.html

@@ -346,10 +346,11 @@ <h3 id="twitter"><a class="hash-anchor" href="#twitter" aria-hidden="true" oncli
 <p>You can also embed a tweet from Twitter by passing the URL for the tweet:</p>
 <div class="twitter">
     <blockquote class="twitter-tweet" data-dnt="true" data-width="550" data-theme="light">
-        <a href="https://x.com/MattIPv4/status/1576415168426573825">View tweet by @MattIPv4</a>
+        <a href="https://twitter.com/MattIPv4/status/1576415168426573825">View tweet by @MattIPv4</a>
     </blockquote>
 </div>
-<p>Like a few other embeds, you can also pass optional flags to customize the embed:</p>
+<p>Input may use either <code>twitter.com</code> or <code>x.com</code> domain
+Like a few other embeds, you can also pass optional flags to customize the embed:</p>
 <ul>
 <li>Pass any integer value (between 250 and 550) to set a custom width for the embed (e.g. <code>[twitter https://twitter.com/MattIPv4/status/1576415168426573825 400]</code>)</li>
 <li>Pass <code>light</code> or <code>dark</code> to switch the theme of the embed (e.g. <code>[twitter https://twitter.com/MattIPv4/status/1576415168426573825 dark]</code>)</li>

rules/embeds/twitter.js

@@ -28,7 +28,7 @@ const safeObject = require('../../util/safe_object');
  *
  * The basic syntax is `[twitter <tweet>]`.
  * E.g. `[twitter https://twitter.com/MattIPv4/status/1576415168426573825]`.
- * Rendered output always canonicalizes the link to `https://x.com/<user>/status/<id>`.
+ * Rendered output always canonicalizes the link to `https://twitter.com/<user>/status/<id>`.
  * After the tweet, assorted space-separated flags can be added (in any combination/order):
  *
  * - Add `light` or `dark` to set the card theme (default is `light`).
@@ -48,13 +48,13 @@ const safeObject = require('../../util/safe_object');
  *
  * <div class="twitter">
  *     <blockquote class="twitter-tweet" data-dnt="true" data-width="550" data-theme="light">
- *         <a href="https://x.com/MattIPv4/status/1576415168426573825">View tweet by @MattIPv4</a>
+ *         <a href="https://twitter.com/MattIPv4/status/1576415168426573825">View tweet by @MattIPv4</a>
  *     </blockquote>
  * </div>
  *
  * <div class="twitter" align="left">
  *     <blockquote class="twitter-tweet" data-dnt="true" data-width="400" data-theme="dark">
- *         <a href="https://x.com/MattIPv4/status/1576415168426573825">View tweet by @MattIPv4</a>
+ *         <a href="https://twitter.com/MattIPv4/status/1576415168426573825">View tweet by @MattIPv4</a>
  *     </blockquote>
  * </div>
  * <script async defer src="https://platform.twitter.com/widgets.js" type="text/javascript"></script>
@@ -174,7 +174,7 @@ module.exports = md => {
         // Apply the alignment to the parent div, as Twitter does float-based alignment
         return `<div class="twitter"${attrAlign}>
     <blockquote class="twitter-tweet" data-dnt="true"${attrWidth}${attrTheme}>
-        <a href="https://x.com/${user}/status/${id}">View tweet by @${user}</a>
+        <a href="https://twitter.com/${user}/status/${id}">View tweet by @${user}</a>
     </blockquote>
 </div>\n`;
     };