Merge pull request #93 from digitalsadhu/BenjaminHorn/config.js

do not override config.js's remotes.options.json

Author: digitalsadhu

lib/headers.js

@@ -30,11 +30,12 @@ module.exports = function (app, options) {
   ]);
 
   //extend rest body parser to also parse application/vnd.api+json
-  remotes.options.json = {
+  remotes.options.json = remotes.options.json || {};
+  remotes.options.json = _.extend(remotes.options.json, {
     strict: false,
     type: function (req) {
       //if Content-Type is any of the following, then parse otherwise don't
       return !!is(req, ['json', 'application/json', 'application/vnd.api+json']);
     }
-  };
+  });
 };

test/config.test.js

@@ -0,0 +1,66 @@
+var request = require('supertest');
+var loopback = require('loopback');
+var expect = require('chai').expect;
+var JSONAPIComponent = require('../');
+
+var app;
+var Image;
+
+describe('Dont override config.js ', function () {
+  beforeEach(function () {
+    app = loopback();
+    app.set('legacyExplorer', false);
+    app.use(loopback.rest());
+
+    var remotes = app.remotes();
+    remotes.options.json = {limit: '100B'};
+    var ds = loopback.createDataSource('memory');
+    Image = ds.createModel('image', {
+      id: {type: Number, id: true},
+      source: String
+    });
+
+    app.model(Image);
+
+    JSONAPIComponent(app);
+  });
+
+  it('should have limit property', function (done) {
+    var remotes = app.remotes();
+    expect(remotes.options.json).to.have.any.keys('limit');
+    done();
+  });
+
+  it('should accept payload < 100B', function (done) {
+    request(app).post('/images')
+      .send({
+        data: {
+          type: 'images',
+          attributes: {
+            source: 'a'
+          }
+        }
+      })
+      .set('Accept', 'application/vnd.api+json')
+      .set('Content-Type', 'application/json')
+      .expect(201)
+      .end(done);
+  });
+
+  it('should not accept payload > 100B', function (done) {
+    request(app).post('/images')
+      .send({
+        data: {
+          type: 'images',
+          attributes: {
+            source: 'A long text to make the payload greater then 100B'
+          }
+        }
+      })
+      .set('Accept', 'application/vnd.api+json')
+      .set('Content-Type', 'application/json')
+      .expect(400)
+      .end(done);
+  });
+
+});