Merge pull request #106 from digitalsadhu/fix/http-status-codes

Fix/http status codes

Author: listepo

lib/create.js

@@ -1,5 +1,6 @@
 var url = require('url');
 var utils = require('./utils');
+var statusCodes = require('http-status-codes');
 
 module.exports = function (app, options) {
   //get remote methods.
@@ -18,7 +19,7 @@ module.exports = function (app, options) {
     if (ctx.method.name === 'create') {
       //JSON API specifies that created resources should have the
       //http status code of 201
-      ctx.res.statusCode = 201;
+      ctx.res.statusCode = statusCodes.CREATED;
 
       //build the location url for the created resource.
       var location = url.format({

lib/delete.js

@@ -1,4 +1,5 @@
 var utils = require('./utils');
+var statusCodes = require('http-status-codes');
 
 module.exports = function (app, options) {
   //get remote methods.
@@ -17,8 +18,8 @@ module.exports = function (app, options) {
     if (ctx.method.name === 'deleteById') {
       //JSON API specifies that successful
       //deletes with no content returned should be 204
-      if (ctx.res.statusCode === 200) {
-        ctx.res.status(204);
+      if (ctx.res.statusCode === statusCodes.OK) {
+        ctx.res.status(statusCodes.NO_CONTENT);
       }
     }
     next();

lib/errors.js

@@ -1,4 +1,5 @@
 var debug;
+var statusCodes = require('http-status-codes');
 
 module.exports = function (app, options) {
   debug = options.debug;
@@ -26,7 +27,7 @@ function JSONAPIErrorHandler (err, req, res, next) {
   res.set('Content-Type', 'application/vnd.api+json');
 
   var errors = [];
-  var statusCode = err.statusCode || err.status || 500;
+  var statusCode = err.statusCode || err.status || statusCodes.INTERNAL_SERVER_ERROR;
   debug('Error thrown:');
   debug('Raw error object:', err);
 
@@ -61,14 +62,14 @@ function JSONAPIErrorHandler (err, req, res, next) {
 
     if (additionalValidationErrors.indexOf(err.message) !== -1) {
       debug('Recasting error as a validation error.');
-      statusCode = 422;
+      statusCode = statusCodes.UNPROCESSABLE_ENTITY;
       err.code = 'presence';
       err.name = 'ValidationError';
     }
 
     debug('Handling invalid relationship specified in url');
     if (/Relation (.*) is not defined for (.*) model/.test(err.message)) {
-      statusCode = 400;
+      statusCode = statusCodes.BAD_REQUEST;
       err.message = 'Bad Request';
       err.code = 'INVALID_INCLUDE_TARGET';
       err.name = 'BadRequest';
@@ -78,7 +79,7 @@ function JSONAPIErrorHandler (err, req, res, next) {
   } else {
     debug('Unable to determin error type. Treating error as a general 500 server error.');
     //catch all server 500 error if we were unable to understand the error.
-    errors.push(buildErrorResponse(500, 'Internal Server error', 'GENERAL_SERVER_ERROR'));
+    errors.push(buildErrorResponse(statusCodes.INTERNAL_SERVER_ERROR, 'Internal Server error', 'GENERAL_SERVER_ERROR'));
   }
 
   //generalise the error code. More specific error codes are kept
@@ -104,9 +105,9 @@ function JSONAPIErrorHandler (err, req, res, next) {
 function generalizeStatusCode (statusCode) {
   switch (String(statusCode)[0]) {
     case '4':
-      return 400;
+      return statusCodes.BAD_REQUEST;
     case '5':
-      return 500;
+      return statusCodes.INTERNAL_SERVER_ERROR;
   }
 
   return statusCode;
@@ -125,7 +126,7 @@ function generalizeStatusCode (statusCode) {
  */
 function buildErrorResponse (httpStatusCode, errorDetail, errorCode, errorName, propertyName) {
   return {
-    status: httpStatusCode || 500,
+    status: httpStatusCode || statusCodes.INTERNAL_SERVER_ERROR,
     source: (propertyName) ? { pointer: 'data/attributes/' + propertyName } : '',
     title: errorName || '',
     code: errorCode || '',

lib/patch.js

@@ -1,3 +1,5 @@
+var statusCodes = require('http-status-codes');
+
 module.exports = function (app, options) {
   //iterate over all loopback models. This gives us a constructor function
   //and allows us to overwrite the relationship methods:
@@ -57,7 +59,7 @@ function convertNullToNotFoundError (toModelName, ctx, cb) {
   var fk = ctx.getArgByName('fk');
   var msg = 'Unknown "' + toModelName + '" id "' + fk + '".';
   var error = new Error(msg);
-  error.statusCode = error.status = 404;
+  error.statusCode = error.status = statusCodes.NOT_FOUND;
   error.code = 'MODEL_NOT_FOUND';
   cb(error);
 }

lib/utilities/relationship-utils.js

@@ -1,4 +1,5 @@
 var _ = require('lodash');
+var statusCodes = require('http-status-codes');
 
 /* global module */
 module.exports = {
@@ -18,9 +19,9 @@ module.exports = {
  */
 function getInvalidIncludesError (message) {
   var error = new Error(message || 'JSON API resource does not support `include`');
-  error.statusCode = 400;
-  error.code = 400;
-  error.status = 400;
+  error.statusCode = statusCodes.BAD_REQUEST;
+  error.code = statusCodes.BAD_REQUEST;
+  error.status = statusCodes.BAD_REQUEST;
 
   return error;
 }

package.json

@@ -33,6 +33,7 @@
   "dependencies": {
     "body-parser": "^1.14.1",
     "debug": "^2.2.0",
+    "http-status-codes": "^1.0.5",
     "inflection": "^1.7.2",
     "lodash": "^4.0.0",
     "type-is": "^1.6.9"