navigation discovery

Author: shalom938

ide-common/src/main/java/org/digma/intellij/plugin/common/Backgroundable.java

@@ -58,8 +58,6 @@ public void run(@NotNull ProgressIndicator indicator) {
     }
 
 
-
-
     public static void runInNewBackgroundThread(Project project, String name, Runnable task) {
 
         new Task.Backgroundable(project, name) {
@@ -109,7 +107,7 @@ public static <T> Future<T> executeOnPooledThread(@NotNull Callable<T> action) {
             try {
                 return action.call();
             } catch (Throwable e) {
-                Log.warnWithException(LOGGER, e, "Exception in action");
+                Log.warnWithException(LOGGER, e, "Exception in task {}", e);
                 ErrorReporter.getInstance().reportError("executeOnPooledThread", e);
                 throw e;
             }
@@ -121,16 +119,16 @@ private static void runWithErrorReporting(Project project, String name, Runnable
         try {
             task.run();
         } catch (Throwable e) {
-            Log.warnWithException(LOGGER, e, "Exception in task {}", name);
-            ErrorReporter.getInstance().reportError(project, "Backgroundable.runWithErrorReporting(Project,Runnable)" + name, e);
+            Log.warnWithException(LOGGER, e, "Exception in task {},{}", name, e);
+            ErrorReporter.getInstance().reportError(project, "Backgroundable.runWithErrorReporting(Project,name,Runnable)" + name, e);
         }
     }
 
     private static void runWithErrorReporting(Runnable task) {
         try {
             task.run();
         } catch (Throwable e) {
-            Log.warnWithException(LOGGER, e, "Exception in action");
+            Log.warnWithException(LOGGER, e, "Exception in task {}", e);
             ErrorReporter.getInstance().reportError("Backgroundable.runWithErrorReporting(Runnable)", e);
         }
     }
@@ -140,7 +138,7 @@ private static <T> Future<T> runWithErrorReporting(@NotNull Callable<T> action)
         try {
             return new FutureResult<>(action.call());
         } catch (Exception e) {
-            Log.warnWithException(LOGGER, e, "Exception in action");
+            Log.warnWithException(LOGGER, e, "Exception in task {}", e);
             ErrorReporter.getInstance().reportError("Backgroundable.runWithErrorReporting(Callable)", e);
             return new FutureResult<>();
         }

ide-common/src/main/java/org/digma/intellij/plugin/log/Log.java

@@ -102,6 +102,17 @@ public static void log(Consumer<String> consumer, String msg) {
 
 
     // **********  New API
+
+    public static void info(Logger logger, Project project, String format, Object... args) {
+        logger.info(DIGMA_PROJECT + project.getName() + ": " + format(format, args));
+    }
+
+    public static void info(Logger logger, String format, Object... args) {
+        logger.info(DIGMA + ": " + format(format, args));
+    }
+
+
+
     public static void warn(Logger logger, Project project, String format, Object... args) {
         logger.warn(DIGMA_PROJECT + project.getName() + ": " + format(format, args));
     }

src/main/kotlin/org/digma/intellij/plugin/ui/notificationcenter/RegistrationRequestNotifications.kt

@@ -11,7 +11,6 @@ import com.intellij.openapi.project.Project
 import com.intellij.openapi.util.Disposer
 import org.digma.intellij.plugin.PluginId
 import org.digma.intellij.plugin.activation.UserActivationService
-import org.digma.intellij.plugin.common.Backgroundable
 import org.digma.intellij.plugin.common.findActiveProject
 import org.digma.intellij.plugin.errorreporting.ErrorReporter
 import org.digma.intellij.plugin.log.Log
@@ -119,7 +118,7 @@ class RegisterAction(
     override fun actionPerformed(e: AnActionEvent) {
 
         try {
-            Log.log(AppNotificationCenter.logger::info, "in RegisterAction, action clicked")
+            Log.info(AppNotificationCenter.logger, "in RegisterAction, action clicked")
 
             ActivityMonitor.getInstance(project).registerUserAction(
                 "RegisterAction link clicked",
@@ -130,19 +129,11 @@ class RegisterAction(
 
             ActivityMonitor.getInstance(project).registerNotificationCenterEvent("$notificationName.clicked", mapOf())
 
-            openRegistrationDialog(project)
+            project.service<RecentActivityService>().openRegistrationDialog()
 
             notification.expire()
         } catch (e: Throwable) {
-            ErrorReporter.getInstance().reportError(project, "ShowTypeformAction.actionPerformed", e)
-        }
-    }
-
-    private fun openRegistrationDialog(project: Project) {
-        //this is called on EDT, start background and release the EDT thread
-        Backgroundable.ensurePooledThreadWithoutReadAccess {
-            project.service<RecentActivityService>().openRegistrationDialog()
+            ErrorReporter.getInstance().reportError(project, "RegisterAction.actionPerformed", e)
         }
     }
-
 }

src/main/kotlin/org/digma/intellij/plugin/ui/recentactivity/RecentActivityService.kt

@@ -105,6 +105,7 @@ class RecentActivityService(val project: Project, private val cs: CoroutineScope
     }
 
 
+    //Runs on EDT!
     fun openRegistrationDialog() {
 
         RecentActivityToolWindowShower.getInstance(project).showToolWindow()