Background thread on settings change (#1968)

* background-thread-on-settings-change

* background-thread-on-settings-change

Author: shalom938

ide-common/src/main/java/org/digma/intellij/plugin/common/EDT.java

@@ -47,10 +47,10 @@ public static void assertIsDispatchThread(){
 
     public static void assertNonDispatchThread(){
         if (ApplicationManager.getApplication().isDispatchThread()) {
-            RuntimeException runtimeException = new RuntimeException("Must not run on EDT");
-            LOGGER.error("Must not run on EDT", runtimeException);
-            ErrorReporter.getInstance().reportInternalFatalError("assertNonDispatchThread", runtimeException, Collections.emptyMap());
-            throw runtimeException;
+            EDTAccessException edtAccessException = new EDTAccessException("Must not run on EDT");
+            LOGGER.error("Must not run on EDT", edtAccessException);
+            ErrorReporter.getInstance().reportInternalFatalError("assertNonDispatchThread", edtAccessException, Collections.emptyMap());
+            throw edtAccessException;
         }
     }
 
@@ -63,4 +63,12 @@ public static boolean isEdt() {
     public static void invokeAndWait(@NotNull Runnable task) {
         ApplicationManager.getApplication().invokeAndWait(task);
     }
+
+
+    public static class EDTAccessException extends RuntimeException {
+        public EDTAccessException(String message) {
+            super(message);
+        }
+    }
+
 }

ide-common/src/main/java/org/digma/intellij/plugin/common/ReadActions.java

@@ -17,10 +17,10 @@ public static void assertReadAccessAllowed() {
 
     public static void assertNotInReadAccess() {
         if (ApplicationManager.getApplication().isReadAccessAllowed()) {
-            RuntimeException runtimeException = new RuntimeException("Must not run in read access");
-            LOGGER.error("Must not run in read access", runtimeException);
-            ErrorReporter.getInstance().reportInternalFatalError("assertNotInReadAccess", runtimeException, Collections.emptyMap());
-            throw runtimeException;
+            ReadAccessException readAccessException = new ReadAccessException("Must not run in read access");
+            LOGGER.error("Must not run in read access", readAccessException);
+            ErrorReporter.getInstance().reportInternalFatalError("assertNotInReadAccess", readAccessException, Collections.emptyMap());
+            throw readAccessException;
         }
     }
 
@@ -47,4 +47,11 @@ public static void ensureReadAction(Runnable runnable){
     public static boolean isReadAccessAllowed() {
         return ApplicationManager.getApplication().isReadAccessAllowed();
     }
+
+
+    public static class ReadAccessException extends RuntimeException {
+        public ReadAccessException(String message) {
+            super(message);
+        }
+    }
 }

ide-common/src/main/kotlin/org/digma/intellij/plugin/posthog/SettingsChangeTracker.kt

@@ -1,5 +1,6 @@
 package org.digma.intellij.plugin.posthog
 
+import org.digma.intellij.plugin.common.Backgroundable
 import org.digma.intellij.plugin.settings.SettingsState
 
 class SettingsChangeTracker {
@@ -12,18 +13,20 @@ class SettingsChangeTracker {
 
     fun start(activityMonitor: ActivityMonitor) {
 
-        activityMonitor.registerSettingsEvent("initial",myTrackedSettings)
+        activityMonitor.registerSettingsEvent("initial", myTrackedSettings)
 
         SettingsState.getInstance().addChangeListener(
             {
-                val oldSettings = mutableMapOf<String,String>()
-                oldSettings.putAll(myTrackedSettings)
-                updateTrackedSettings()
-                val diff = getDiff(oldSettings,myTrackedSettings)
-                activityMonitor.registerSettingsEvent("change",diff)
-
+                Backgroundable.executeOnPooledThread {
+                    val oldSettings = mutableMapOf<String, String>()
+                    oldSettings.putAll(myTrackedSettings)
+                    updateTrackedSettings()
+                    val diff = getDiff(oldSettings, myTrackedSettings)
+                    activityMonitor.registerSettingsEvent("change", diff)
+                }
             },
-            activityMonitor)
+            activityMonitor
+        )
     }
 
     private fun getDiff(oldSettings: MutableMap<String, String>, myTrackedSettings: MutableMap<String, String>): Map<String,String> {

src/main/kotlin/org/digma/intellij/plugin/ui/jcef/JCefComponent.kt

@@ -17,6 +17,7 @@ import org.cef.handler.CefLifeSpanHandlerAdapter
 import org.digma.intellij.plugin.analytics.AnalyticsService
 import org.digma.intellij.plugin.analytics.AnalyticsServiceConnectionEvent
 import org.digma.intellij.plugin.analytics.EnvironmentChanged
+import org.digma.intellij.plugin.common.Backgroundable
 import org.digma.intellij.plugin.docker.DockerService
 import org.digma.intellij.plugin.env.Env
 import org.digma.intellij.plugin.errorreporting.ErrorReporter
@@ -111,16 +112,19 @@ private constructor(
 
 
         SettingsState.getInstance().addChangeListener({ settings ->
-            try {
-                val apiUrl = settings.apiUrl
-                sendApiUrl(jbCefBrowser.cefBrowser, apiUrl)
-                sendIsMicrometerProject(jbCefBrowser.cefBrowser, SpringBootMicrometerConfigureDepsService.isSpringBootWithMicrometer())
-                sendIsJaegerButtonEnabledMessage(jbCefBrowser.cefBrowser)
-                sendBackendAboutInfo(jbCefBrowser.cefBrowser, project)
-                val status = service<DockerService>().getCurrentDigmaInstallationStatusOnConnectionLost()
-                updateDigmaEngineStatus(jbCefBrowser.cefBrowser, status)
-            } catch (e: Throwable) {
-                ErrorReporter.getInstance().reportError("JCefComponent.settingsChanged", e)
+            //this event run on EDT
+            Backgroundable.executeOnPooledThread {
+                try {
+                    val apiUrl = settings.apiUrl
+                    sendApiUrl(jbCefBrowser.cefBrowser, apiUrl)
+                    sendIsMicrometerProject(jbCefBrowser.cefBrowser, SpringBootMicrometerConfigureDepsService.isSpringBootWithMicrometer())
+                    sendIsJaegerButtonEnabledMessage(jbCefBrowser.cefBrowser)
+                    sendBackendAboutInfo(jbCefBrowser.cefBrowser, project)
+                    val status = service<DockerService>().getCurrentDigmaInstallationStatusOnConnectionLost()
+                    updateDigmaEngineStatus(jbCefBrowser.cefBrowser, status)
+                } catch (e: Throwable) {
+                    ErrorReporter.getInstance().reportError("JCefComponent.settingsChanged", e)
+                }
             }
         }, settingsListenerParentDisposable)