Skip to content

Commit 21246fb

Browse files
authored
Removed unused CodeObjectId field from SpanHistogramQuery (#267)
1 parent 9209bfc commit 21246fb

File tree

3 files changed

+4
-15
lines changed

3 files changed

+4
-15
lines changed

analytics-provider/src/test/java/org/digma/intellij/plugin/analytics/InsightsTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public void actualGetInsightsTempViaSsl() {
5353
//@Test
5454
public void actualgetHtmlGraphForSpanPercentiles() {
5555
final SpanHistogramQuery query = new SpanHistogramQuery(
56-
"ARIK-LAPTOP[LOCAL]", "SampleInsights/Error", "OpenTelemetry.Instrumentation.AspNetCore", "", "dark", null);
56+
"ARIK-LAPTOP[LOCAL]", "SampleInsights/Error", "OpenTelemetry.Instrumentation.AspNetCore", "dark", null);
5757
AnalyticsProvider analyticsProvider = new RestAnalyticsProvider("https://localhost:5051");
5858

5959
String htmlBody = analyticsProvider.getHtmlGraphForSpanPercentiles(query);

ide-common/src/main/java/org/digma/intellij/plugin/analytics/AnalyticsService.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,7 @@
1313
import org.digma.intellij.plugin.model.rest.debugger.DebuggerEventRequest;
1414
import org.digma.intellij.plugin.model.rest.errordetails.CodeObjectErrorDetails;
1515
import org.digma.intellij.plugin.model.rest.errors.CodeObjectError;
16-
import org.digma.intellij.plugin.model.rest.insights.CodeObjectInsight;
17-
import org.digma.intellij.plugin.model.rest.insights.CustomStartTimeInsightRequest;
18-
import org.digma.intellij.plugin.model.rest.insights.GlobalInsight;
19-
import org.digma.intellij.plugin.model.rest.insights.InsightsRequest;
20-
import org.digma.intellij.plugin.model.rest.insights.SpanHistogramQuery;
16+
import org.digma.intellij.plugin.model.rest.insights.*;
2117
import org.digma.intellij.plugin.model.rest.usage.UsageStatusRequest;
2218
import org.digma.intellij.plugin.model.rest.usage.UsageStatusResult;
2319
import org.digma.intellij.plugin.notifications.NotificationUtil;
@@ -38,13 +34,7 @@
3834
import java.net.UnknownHostException;
3935
import java.net.http.HttpTimeoutException;
4036
import java.time.Instant;
41-
import java.util.ArrayList;
42-
import java.util.Arrays;
43-
import java.util.Collections;
44-
import java.util.HashMap;
45-
import java.util.List;
46-
import java.util.Map;
47-
import java.util.Objects;
37+
import java.util.*;
4838
import java.util.concurrent.TimeUnit;
4939
import java.util.function.Supplier;
5040
import java.util.stream.Collectors;
@@ -211,7 +201,7 @@ public UsageStatusResult getUsageStatusOfErrors(List<String> objectIds) throws A
211201
}
212202

213203
public String getHtmlGraphForSpanPercentiles(String instrumentationLibrary, String spanName, String backgroundColor) throws AnalyticsServiceException {
214-
final SpanHistogramQuery spanHistogramQuery = new SpanHistogramQuery(getCurrentEnvironment(), spanName, instrumentationLibrary, "", JBColor.isBright() ? "light" : "dark", backgroundColor);
204+
final SpanHistogramQuery spanHistogramQuery = new SpanHistogramQuery(getCurrentEnvironment(), spanName, instrumentationLibrary, JBColor.isBright() ? "light" : "dark", backgroundColor);
215205
return executeCatching(() -> analyticsProviderProxy.getHtmlGraphForSpanPercentiles(spanHistogramQuery));
216206
}
217207

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/SpanHistogramQuery.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ constructor(
88
val environment: String,
99
val spanName: String,
1010
val instrumentationLibrary: String,
11-
val codeObjectId: String,
1211
val theme: String?,
1312
val backgroundColor: String?,
1413
)

0 commit comments

Comments
 (0)