Feature/add bottleneck span insight (#145)

Author: arik-dig

ide-common/src/main/java/org/digma/intellij/plugin/insights/view/BuildersHolder.java

@@ -10,6 +10,7 @@
 import org.digma.intellij.plugin.model.rest.insights.SlowEndpointInsight;
 import org.digma.intellij.plugin.model.rest.insights.SlowestSpansInsight;
 import org.digma.intellij.plugin.model.rest.insights.SpanDurationsInsight;
+import org.digma.intellij.plugin.model.rest.insights.SpanSlowEndpointsInsight;
 import org.digma.intellij.plugin.model.rest.insights.SpanUsagesInsight;
 import org.digma.intellij.plugin.model.rest.insights.UnmappedInsight;
 import org.digma.intellij.plugin.ui.model.insights.InsightGroupType;
@@ -49,6 +50,8 @@ private ListViewItemBuilder<? extends CodeObjectInsight> newBuilder(InsightType
                 return new GroupListViewItemBuilder<SpanUsagesInsight>(InsightGroupType.Span, SpanUsagesInsight::getSpan);
             case SpanDurations:
                 return new GroupListViewItemBuilder<SpanDurationsInsight>(InsightGroupType.Span, spanDurationsInsight -> spanDurationsInsight.getSpan().getName());
+            case SpanEndpointBottleneck:
+                return new GroupListViewItemBuilder<SpanSlowEndpointsInsight>(InsightGroupType.Span, insight -> insight.getSpan().getName());
             case SlowestSpans:
                 return new GroupListViewItemBuilder<SlowestSpansInsight>(InsightGroupType.HttpEndpoint, SlowestSpansInsight::getRoute);
             case LowUsage:

model/src/main/kotlin/org/digma/intellij/plugin/model/model.kt

@@ -30,5 +30,7 @@ enum class InsightType {
     SlowEndpoint,
     Unmapped,
     TopErrorFlows,
-    SpanDurationChange
+    SpanDurationChange,
+    SpanEndpointBottleneck,
+    ;
 }

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/CodeObjectInsight.kt

@@ -23,7 +23,8 @@ import org.digma.intellij.plugin.model.InsightType
     JsonSubTypes.Type(value = NormalUsageInsight::class, name = "NormalUsage"),
     JsonSubTypes.Type(value = HighUsageInsight::class, name = "HighUsage"),
     JsonSubTypes.Type(value = SlowEndpointInsight::class, name = "SlowEndpoint"),
-    JsonSubTypes.Type(value = SpanDurationsInsight::class, name = "SpanDurations")
+    JsonSubTypes.Type(value = SpanDurationsInsight::class, name = "SpanDurations"),
+    JsonSubTypes.Type(value = SpanSlowEndpointsInsight::class, name = "SpanEndpointBottleneck"),
 )
 interface CodeObjectInsight {
     val type: InsightType

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/EndpointInfo.kt

@@ -0,0 +1,15 @@
+package org.digma.intellij.plugin.model.rest.insights
+
+import com.fasterxml.jackson.annotation.JsonCreator
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties
+import java.beans.ConstructorProperties
+
+@JsonIgnoreProperties(ignoreUnknown = true)
+data class EndpointInfo
+@JsonCreator(mode = JsonCreator.Mode.PROPERTIES)
+@ConstructorProperties("route", "serviceName", "instrumentationLibrary")
+constructor(
+    val route: String,
+    val serviceName: String,
+    val instrumentationLibrary: String,
+)

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/SlowEndpointInfo.kt

@@ -0,0 +1,16 @@
+package org.digma.intellij.plugin.model.rest.insights
+
+import com.fasterxml.jackson.annotation.JsonCreator
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties
+import java.beans.ConstructorProperties
+
+@JsonIgnoreProperties(ignoreUnknown = true)
+data class SlowEndpointInfo
+@JsonCreator(mode = JsonCreator.Mode.PROPERTIES)
+@ConstructorProperties("endpointInfo", "p50", "p95", "p99")
+constructor(
+    val endpointInfo: EndpointInfo,
+    val p50: Percentile,
+    val p95: Percentile,
+    val p99: Percentile,
+)

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/SpanSlowEndpointsInsight.kt

@@ -0,0 +1,17 @@
+package org.digma.intellij.plugin.model.rest.insights
+
+import com.fasterxml.jackson.annotation.JsonCreator
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties
+import org.digma.intellij.plugin.model.InsightType
+import java.beans.ConstructorProperties
+
+@JsonIgnoreProperties(ignoreUnknown = true)
+data class SpanSlowEndpointsInsight@JsonCreator(mode = JsonCreator.Mode.PROPERTIES)
+@ConstructorProperties("codeObjectId", "span", "slowEndpoints")
+constructor(
+    override val codeObjectId: String,
+    val span: SpanInfo,
+    val slowEndpoints: List<SlowEndpointInfo>,
+) : CodeObjectInsight {
+    override val type: InsightType = InsightType.SpanEndpointBottleneck
+}

model/src/main/kotlin/org/digma/intellij/plugin/ui/model/insights/InsightListViewItem.kt

@@ -18,6 +18,7 @@ open class InsightListViewItem<INSIGHT : CodeObjectInsight>(insight: INSIGHT) :
                 InsightType.SpanUsages -> 60
                 InsightType.SpanDurations -> 65
                 InsightType.SpanDurationChange -> 66
+                InsightType.SpanEndpointBottleneck -> 67
                 // HTTP Endpoints
                 InsightType.SlowestSpans -> 40
                 InsightType.LowUsage -> 30

src/main/kotlin/org/digma/intellij/plugin/ui/list/insights/InsightsListCellRenderer.kt

@@ -17,6 +17,7 @@ import org.digma.intellij.plugin.model.rest.insights.NormalUsageInsight
 import org.digma.intellij.plugin.model.rest.insights.SlowEndpointInsight
 import org.digma.intellij.plugin.model.rest.insights.SlowestSpansInsight
 import org.digma.intellij.plugin.model.rest.insights.SpanDurationsInsight
+import org.digma.intellij.plugin.model.rest.insights.SpanSlowEndpointsInsight
 import org.digma.intellij.plugin.model.rest.insights.SpanUsagesInsight
 import org.digma.intellij.plugin.model.rest.insights.UnmappedInsight
 import org.digma.intellij.plugin.ui.common.CopyableLabelHtml
@@ -65,6 +66,8 @@ class InsightsListCellRenderer : AbstractPanelListCellRenderer() {
             is SpanUsagesInsight -> spanUsagesPanel(project, value.modelObject as SpanUsagesInsight)
             is SpanDurationsInsight -> spanDurationPanel(project, value.modelObject as SpanDurationsInsight,
                 panelsLayoutHelper)
+            is SpanSlowEndpointsInsight -> spanSlowEndpointsPanel(project, value.modelObject as SpanSlowEndpointsInsight,
+                panelsLayoutHelper)
             is UnmappedInsight -> unmappedInsightPanel(value.modelObject as UnmappedInsight,
                 panelsLayoutHelper)
             else -> genericPanelForSingleInsight(value.modelObject, panelsLayoutHelper)

src/main/kotlin/org/digma/intellij/plugin/ui/list/insights/SlowestSpansPanel.kt

@@ -3,26 +3,24 @@ package org.digma.intellij.plugin.ui.list.insights
 import com.intellij.openapi.project.Project
 import com.intellij.ui.components.ActionLink
 import com.intellij.ui.components.JBLabel
-import com.intellij.ui.components.JBPanel
-import com.intellij.ui.dsl.builder.RowLayout
-import com.intellij.ui.dsl.builder.panel
-import com.intellij.ui.dsl.gridLayout.HorizontalAlign
 import com.intellij.util.ui.JBUI
 import org.digma.intellij.plugin.document.CodeObjectsUtil
+import org.digma.intellij.plugin.model.rest.insights.EndpointSchema
 import org.digma.intellij.plugin.model.rest.insights.Percentile
+import org.digma.intellij.plugin.model.rest.insights.SlowEndpointInfo
 import org.digma.intellij.plugin.model.rest.insights.SlowSpanInfo
 import org.digma.intellij.plugin.model.rest.insights.SlowestSpansInsight
+import org.digma.intellij.plugin.model.rest.insights.SpanSlowEndpointsInsight
 import org.digma.intellij.plugin.service.InsightsActionsService
-import org.digma.intellij.plugin.ui.common.*
+import org.digma.intellij.plugin.ui.common.Laf
+import org.digma.intellij.plugin.ui.common.asHtml
+import org.digma.intellij.plugin.ui.common.buildBoldTitleGrayedComment
+import org.digma.intellij.plugin.ui.common.buildLinkTextWithTitleAndGrayedComment
 import org.digma.intellij.plugin.ui.list.PanelsLayoutHelper
-import java.awt.BorderLayout
 import java.awt.GridLayout
 import java.math.BigDecimal
 import java.math.RoundingMode
-import javax.swing.BorderFactory
-import javax.swing.JLabel
 import javax.swing.JPanel
-import javax.swing.SwingConstants
 
 fun slowestSpansPanel(project: Project, insight: SlowestSpansInsight, moreData: HashMap<String, Any>, panelsLayoutHelper: PanelsLayoutHelper): JPanel {
 
@@ -63,6 +61,48 @@ fun slowestSpansPanel(project: Project, insight: SlowestSpansInsight, moreData:
             panelsLayoutHelper)
 }
 
+fun spanSlowEndpointsPanel(project: Project, insight: SpanSlowEndpointsInsight, panelsLayoutHelper: PanelsLayoutHelper): JPanel {
+    val endpointsListPanel = JPanel()
+    endpointsListPanel.layout = GridLayout(insight.slowEndpoints.size, 1, 0, 3)
+    endpointsListPanel.border = JBUI.Borders.empty()
+    endpointsListPanel.isOpaque = false
+
+    insight.slowEndpoints.forEach {slowEndpointInfo ->
+        val currContainerPanel = JPanel(GridLayout(2, 1, 0, 3))
+        endpointsListPanel.border = JBUI.Borders.empty()
+        currContainerPanel.isOpaque = false
+
+        val routeInfo = EndpointSchema.getRouteInfo(slowEndpointInfo.endpointInfo.route)
+        val shortRouteName =  routeInfo.shortName
+
+        val line1 = JBLabel(asHtml("${slowEndpointInfo.endpointInfo.serviceName}: <b>$shortRouteName</b>"))
+        val line2 = JBLabel(asHtml(descriptionOf(slowEndpointInfo)))
+
+        currContainerPanel.add(line1)
+        currContainerPanel.add(line2)
+        endpointsListPanel.add(currContainerPanel);
+    }
+
+    return createInsightPanel(
+        "Bottleneck",
+        "The following trace sources spend a significant portion here:",
+        Laf.Icons.Insight.BOTTLENECK,
+        endpointsListPanel,
+        null,
+        panelsLayoutHelper)
+}
+
+fun descriptionOf(sei: SlowEndpointInfo): String {
+    if (sei.p95.fraction > 0) {
+        return "Up to ~${percentageForDisplaySlowSpanInfo(sei.p95)} of entire of the entire request time ${durationText(sei.p95)}"
+    }
+
+    return "Up to ~${percentageForDisplaySlowSpanInfo(sei.p50)} of entire of the entire request time ${durationText(sei.p50)}"
+}
+
+fun durationText(percentile: Percentile): String {
+    return "${percentile.maxDuration.value}${percentile.maxDuration.unit}"
+}
 
 fun descriptionOf(span: SlowSpanInfo): String {
     if (span.p50.fraction > 0.4)
@@ -74,6 +114,11 @@ fun descriptionOf(span: SlowSpanInfo): String {
     return "1% of the users by up to ${span.p99.maxDuration.value}${span.p99.maxDuration.unit}"
 }
 
+private fun percentageForDisplaySlowSpanInfo(percentile: Percentile): String {
+    val decimal = BigDecimal(percentile.fraction * 100).setScale(3, RoundingMode.HALF_DOWN)
+    return decimal.toPlainString()
+}
+
 fun genToolTip(span: SlowSpanInfo): String {
     return asHtml(
         """