Merge pull request #2292 from digma-ai/unique-user-id

unique user id Closes #2256

Author: shalom938

ide-common/src/main/kotlin/org/digma/intellij/plugin/common/UniqueGeneratedUserId.kt

@@ -1,24 +1,58 @@
 package org.digma.intellij.plugin.common
 
 import com.intellij.openapi.components.service
+import org.apache.commons.codec.digest.DigestUtils
 import org.digma.intellij.plugin.persistence.PersistenceService
+import java.net.NetworkInterface
+import java.util.UUID
 
 object UniqueGeneratedUserId {
 
     val userId: String
     val isDevUser: Boolean
 
     init {
-        val hostname = CommonUtils.getLocalHostname()
         if (System.getenv("devenv") == "digma") {
-            userId = hostname
+            userId = CommonUtils.getLocalHostname()
             isDevUser = true
         } else {
             if (service<PersistenceService>().getUserId() == null) {
-                service<PersistenceService>().setUserId(Integer.toHexString(hostname.hashCode()))
+                service<PersistenceService>().setUserId(generateUniqueUserId())
             }
             userId = service<PersistenceService>().getUserId()!!
             isDevUser = false
         }
     }
+}
+
+
+//this method is outside the class so that it can be tested,UniqueGeneratedUserId can not be instantiated in regular unit tests
+fun generateUniqueUserId(): String {
+    try {
+        val userName = System.getProperty("user.name")
+        val userHome = System.getProperty("user.home")
+        val osName = System.getProperty("os.name")
+        val osArch = System.getProperty("os.arch")
+        //MUST BE SORTED
+        val ni = NetworkInterface.networkInterfaces().toList().mapNotNull { it.hardwareAddress }.map { macAddressToString(it) }.sorted()
+            .joinToString("-")
+        val baseString = userName + userHome + osName + osArch + ni
+        return DigestUtils.sha1Hex(baseString)
+    } catch (e: Throwable) {
+        return DigestUtils.sha1Hex(UUID.randomUUID().toString())
+    }
+}
+
+
+private fun macAddressToString(hardwareAddress: ByteArray?): String {
+
+    if (hardwareAddress == null) {
+        return ""
+    }
+
+    val sb = StringBuilder()
+    for (i in hardwareAddress.indices) {
+        sb.append(java.lang.String.format("%02X%s", hardwareAddress[i], if ((i < hardwareAddress.size - 1)) "-" else ""))
+    }
+    return sb.toString()
 }

ide-common/src/test/kotlin/org/digma/intellij/plugin/common/UserIdTests.kt

@@ -0,0 +1,17 @@
+package org.digma.intellij.plugin.common
+
+import kotlin.test.Test
+import kotlin.test.assertEquals
+
+class UserIdTests {
+
+    @Test
+    fun testUniqueness() {
+        val myId = generateUniqueUserId()
+        repeat(10) {
+            val id = generateUniqueUserId()
+            assertEquals(myId, id)
+        }
+    }
+
+}