Implement links and pagination for N+1 endpoint insight

Author: MykolaYaremchuk

ide-common/src/main/java/org/digma/intellij/plugin/insights/view/GroupListViewItemBuilder.java

@@ -41,7 +41,11 @@ public List<ListViewItem<?>> build(Project project, T insight, ListGroupManager
                 break;
             }
             case SpanDurationBreakdown:{
-                WorkspaceUrisHelper.findWorkspaceUrisForSpans(project,theListView, getSpanIds((SpanDurationBreakdownInsight) insight), insight.getCodeObjectId());
+                WorkspaceUrisHelper.findWorkspaceUrisForSpans(project, theListView, getSpanIds((SpanDurationBreakdownInsight) insight), insight.getCodeObjectId());
+                break;
+            }
+            case EndpointSpaNPlusOne:{
+                WorkspaceUrisHelper.findWorkspaceUrisForSpans(project, theListView, getSpanIds((EPNPlusSpansInsight) insight), insight.getCodeObjectId());
                 break;
             }
             case SpanScaling:{
@@ -74,4 +78,12 @@ private List<String> getSpanIds(SpanDurationBreakdownInsight insight) {
                 .collect(Collectors.toList());
     }
 
+    private List<String> getSpanIds(EPNPlusSpansInsight insight) {
+        return insight.getSpans().stream().filter(it -> it.getInternalSpan() != null)
+                .map(it -> CodeObjectsUtil.createSpanId(
+                        it.getInternalSpan().getInstrumentationLibrary(),
+                        it.getInternalSpan().getName()))
+                .collect(Collectors.toList());
+    }
+
 }

ide-common/src/main/kotlin/org/digma/intellij/plugin/editor/PaginationUtil.kt

@@ -14,9 +14,9 @@ fun addInsightPaginationInfo(focusedDocumentName: String, uniqueInsightId: Strin
             filesAndInsightsPaginationInfosMap[uniqueInsightId] = activePage
             insightsPaginationInfo[focusedDocumentName] = filesAndInsightsPaginationInfosMap
         }
-    } else if (insightsPaginationInfo.contains(uniqueInsightId)) {
+    } else if (insightsPaginationInfo[focusedDocumentName] != null && insightsPaginationInfo[focusedDocumentName]!!.containsKey(uniqueInsightId)) {
         // remove pagination info for insights which had some page selected before
-        insightsPaginationInfo.remove(uniqueInsightId)
+        insightsPaginationInfo[focusedDocumentName]!!.remove(uniqueInsightId)
     }
 }
 
@@ -28,4 +28,32 @@ fun removeInsightsPaginationInfoForClosedDocument(documentName: String) {
     if (insightsPaginationInfo.isNotEmpty()) {
         insightsPaginationInfo.remove(documentName)
     }
+}
+
+fun <T> updateListOfEntriesToDisplay(
+        entries: List<T>,
+        entriesToDisplay: ArrayList<T>,
+        currPageNum: Int,
+        recordsPerPage: Int
+) {
+    entriesToDisplay.clear()
+    if (entries.isNotEmpty()) {
+        val start = (currPageNum - 1) * recordsPerPage
+        var end = start + recordsPerPage
+        if (end >= entries.size) {
+            end = entries.size
+        }
+        for (i in start until end) {
+            entriesToDisplay.add(entries[i])
+        }
+    }
+}
+
+fun getCurrentPageNumberForInsight(uniqueInsightId: String, lastPageNum: Int): Int {
+    var currPageNum = 0
+    getInsightPaginationInfo(uniqueInsightId)?.let { currPageNum = getInsightPaginationInfo(uniqueInsightId)!! }
+    if (currPageNum < 1) {
+        currPageNum = if (lastPageNum > 0) 1 else 0
+    }
+    return currPageNum
 }

src/main/kotlin/org/digma/intellij/plugin/ui/list/insights/DurationBreakdownPanel.kt

@@ -6,9 +6,8 @@ import com.intellij.ui.components.JBPanel
 import com.intellij.util.ui.JBUI.Borders.empty
 import org.apache.commons.lang3.StringUtils
 import org.digma.intellij.plugin.document.CodeObjectsUtil
-import org.digma.intellij.plugin.editor.addInsightPaginationInfo
-import org.digma.intellij.plugin.editor.getFocusedDocumentName
-import org.digma.intellij.plugin.editor.getInsightPaginationInfo
+import org.digma.intellij.plugin.editor.getCurrentPageNumberForInsight
+import org.digma.intellij.plugin.editor.updateListOfEntriesToDisplay
 import org.digma.intellij.plugin.model.rest.insights.SpanDurationBreakdown
 import org.digma.intellij.plugin.model.rest.insights.SpanDurationBreakdownInsight
 import org.digma.intellij.plugin.ui.common.Laf
@@ -21,6 +20,7 @@ import javax.swing.*
 
 
 private const val P_50: Float = 0.5F
+private const val RECORDS_PER_PAGE_DURATION_BREAKDOWN = 3
 
 fun spanDurationBreakdownPanel(
         project: Project,
@@ -30,48 +30,33 @@ fun spanDurationBreakdownPanel(
 
     val uniqueInsightId = insight.codeObjectId + insight.type
     val lastPageNum: Int
-    var currPageNum = 0
     var resultBreakdownPanel: DigmaResettablePanel? = null
     val paginationPanel = JPanel()
     val durationBreakdownEntriesToDisplay = ArrayList<SpanDurationBreakdown>()
-    val prev = ActionLink("Prev")
-    val next = ActionLink("Next")
 
     val validBreakdownEntries = insight.breakdownEntries
             .filter { entry -> entry.percentiles.any { breakdown -> breakdown.percentile.equals(P_50) } }
             .sortedWith(compareByDescending { getValueOfPercentile(it, P_50) })
 
     //calculate how many pages there are
-    lastPageNum = validBreakdownEntries.size / RECORDS_PER_PAGE + if (validBreakdownEntries.size % RECORDS_PER_PAGE != 0) 1 else 0
-    getInsightPaginationInfo(uniqueInsightId)?.let { currPageNum = getInsightPaginationInfo(uniqueInsightId)!! }
-    if (currPageNum < 1) {
-        currPageNum = if (lastPageNum > 0) 1 else 0
-    }
-
+    lastPageNum = validBreakdownEntries.size / RECORDS_PER_PAGE_DURATION_BREAKDOWN + if (validBreakdownEntries.size % RECORDS_PER_PAGE_DURATION_BREAKDOWN != 0) 1 else 0
 
     resultBreakdownPanel = object : DigmaResettablePanel() {
         override fun reset() {
-            buildDurationBreakdownRowPanel(
+            rebuildDurationBreakdownRowPanel(
                     resultBreakdownPanel!!,
                     durationBreakdownEntriesToDisplay,
                     project,
                     moreData
             )
-            rebuildPaginationPanel(paginationPanel, currPageNum, lastPageNum, prev, next)
+            rebuildPaginationPanel(paginationPanel, lastPageNum,
+                    validBreakdownEntries, resultBreakdownPanel, durationBreakdownEntriesToDisplay, uniqueInsightId, RECORDS_PER_PAGE_DURATION_BREAKDOWN)
         }
     }
 
-    prev.addActionListener {
-        if (--currPageNum <= 0) currPageNum = 1
-        updateDurationBreakdownPanel(validBreakdownEntries, resultBreakdownPanel, durationBreakdownEntriesToDisplay, uniqueInsightId, currPageNum)
-    }
-    next.addActionListener {
-        if (++currPageNum > lastPageNum) currPageNum = lastPageNum
-        updateDurationBreakdownPanel(validBreakdownEntries, resultBreakdownPanel, durationBreakdownEntriesToDisplay, uniqueInsightId, currPageNum)
-    }
+    updateListOfEntriesToDisplay(validBreakdownEntries, durationBreakdownEntriesToDisplay, getCurrentPageNumberForInsight(uniqueInsightId, lastPageNum), RECORDS_PER_PAGE_DURATION_BREAKDOWN)
+    buildDurationBreakdownRowPanel(resultBreakdownPanel, durationBreakdownEntriesToDisplay, project, moreData)
 
-    updateDurationBreakdownPanel(validBreakdownEntries, resultBreakdownPanel, durationBreakdownEntriesToDisplay,
-            uniqueInsightId, currPageNum)
     return createInsightPanel(
             project = project,
             insight = insight,
@@ -80,25 +65,35 @@ fun spanDurationBreakdownPanel(
             iconsList = listOf(Laf.Icons.Insight.DURATION),
             bodyPanel = resultBreakdownPanel,
             buttons = null,
-            paginationComponent = buildPaginationRowPanel(currPageNum, lastPageNum, paginationPanel, prev, next),
+            paginationComponent = buildPaginationRowPanel(lastPageNum, paginationPanel,
+                    validBreakdownEntries, resultBreakdownPanel, durationBreakdownEntriesToDisplay, uniqueInsightId, RECORDS_PER_PAGE_DURATION_BREAKDOWN),
     )
 }
 
 private fun buildDurationBreakdownRowPanel(
         durationBreakdownPanel: DigmaResettablePanel,
-        durationBreakdownEntries: List<SpanDurationBreakdown>,
+        durationBreakdownEntriesToDisplay: List<SpanDurationBreakdown>,
         project: Project,
         moreData: HashMap<String, Any>
 ) {
-    durationBreakdownPanel.removeAll()
     durationBreakdownPanel.layout = BoxLayout(durationBreakdownPanel, BoxLayout.Y_AXIS)
     durationBreakdownPanel.isOpaque = false
 
-    durationBreakdownEntries.forEach { durationBreakdown: SpanDurationBreakdown ->
+    durationBreakdownEntriesToDisplay.forEach { durationBreakdown: SpanDurationBreakdown ->
         durationBreakdownPanel.add(durationBreakdownRowPanel(durationBreakdown, project, moreData))
     }
 }
 
+private fun rebuildDurationBreakdownRowPanel(
+        durationBreakdownPanel: DigmaResettablePanel,
+        durationBreakdownEntriesToDisplay: List<SpanDurationBreakdown>,
+        project: Project,
+        moreData: HashMap<String, Any>
+) {
+    durationBreakdownPanel.removeAll()
+    buildDurationBreakdownRowPanel(durationBreakdownPanel, durationBreakdownEntriesToDisplay, project, moreData)
+}
+
 private fun durationBreakdownRowPanel(
         durationBreakdown: SpanDurationBreakdown,
         project: Project,
@@ -116,31 +111,6 @@ private fun durationBreakdownRowPanel(
     return durationBreakdownPanel
 }
 
-private fun updateDurationBreakdownPanel(
-        durationBreakdownEntries: List<SpanDurationBreakdown>,
-        resultBreakdownPanel: DigmaResettablePanel,
-        durationBreakdownEntriesToDisplay: ArrayList<SpanDurationBreakdown>,
-        uniqueInsightId: String,
-        currPageNum: Int
-) {
-    val focusedDocumentName = getFocusedDocumentName()
-    addInsightPaginationInfo(focusedDocumentName, uniqueInsightId, currPageNum)
-    durationBreakdownEntriesToDisplay.clear()
-
-    if (durationBreakdownEntries.isNotEmpty()) {
-        val start = (currPageNum - 1) * RECORDS_PER_PAGE
-        var end = start + RECORDS_PER_PAGE
-        if (end >= durationBreakdownEntries.size) {
-            end = durationBreakdownEntries.size
-        }
-        for (i in start until end) {
-            durationBreakdownEntriesToDisplay.add(durationBreakdownEntries[i])
-        }
-    }
-
-    resultBreakdownPanel.reset()
-}
-
 private fun getDurationBreakdownPanel(): JPanel {
     val durationBreakdownPanel = JBPanel<JBPanel<*>>()
     durationBreakdownPanel.layout = BorderLayout(5, 0)