Move duplicated code to PanelUtil file

Author: MykolaYaremchuk

ide-common/src/main/java/org/digma/intellij/plugin/errors/ErrorsProvider.java

@@ -59,7 +59,7 @@ public ErrorsListContainer getErrors(@NotNull MethodInfo methodInfo) {
             Log.log(LOGGER::debug, "UsageStatus for {}: {}", methodInfo.getId(), usageStatus);
 
             return new ErrorsListContainer(errorsListViewItems, usageStatus);
-        }catch (AnalyticsServiceException e){
+        } catch (AnalyticsServiceException e){
             //if analyticsService.getErrorsOfCodeObject throws exception it means errors could not be loaded, usually when
             //the backend is not available. return an empty ErrorsListContainer to keep everything running and don't
             //crash the plugin. don't log the exception, it was logged in AnalyticsService, keep the log quite because

ide-common/src/main/kotlin/org/digma/intellij/plugin/ui/service/ErrorsViewService.kt

@@ -49,6 +49,7 @@ class ErrorsViewService(project: Project) : AbstractViewService(project) {
             Log.log(logger::debug, "contextChanged to {}. ", methodInfo)
 
             val errorsListContainer = errorsProvider.getErrors(methodInfo)
+
             model.listViewItems = errorsListContainer.listViewItems
             model.usageStatusResult = errorsListContainer.usageStatus
             model.scope = MethodScope(methodInfo)

ide-common/src/main/kotlin/org/digma/intellij/plugin/ui/service/SummaryViewService.kt

@@ -74,11 +74,11 @@ class SummaryViewService(project: Project) : AbstractViewService(project) {
 
     private fun reload() {
         Log.log(logger::debug, "reload called")
-        val insights = summariesProvider.getGlobalInsights()
-        val environmentStatuses = summariesProvider.getEnvironmentStatuses()
+        val insights = summariesProvider.globalInsights
+        val environmentStatuses = summariesProvider.environmentStatuses
         model.insights = insights
         model.usageStatusResult = UsageStatusResult(emptyList(), environmentStatuses)
-        model.count = insights.sumOf { it.modelObject.count() }
+        model.count = insights.size
         updateUi()
     }
 

src/main/kotlin/org/digma/intellij/plugin/ui/list/PanelUtil.kt

@@ -0,0 +1,16 @@
+package org.digma.intellij.plugin.ui.list
+
+import com.intellij.openapi.project.Project
+import org.digma.intellij.plugin.service.InsightsActionsService
+
+fun openWorkspaceFileForSpan(
+        project: Project,
+        moreData: HashMap<String, Any>,
+        spanId: String,
+) {
+    val actionListener: InsightsActionsService = project.getService(InsightsActionsService::class.java)
+
+    @Suppress("UNCHECKED_CAST")
+    val workspaceUri: Pair<String, Int> = moreData[spanId] as Pair<String, Int>
+    actionListener.openWorkspaceFileForSpan(workspaceUri.first, workspaceUri.second)
+}

src/main/kotlin/org/digma/intellij/plugin/ui/list/insights/DurationBreakdownPanel.kt

@@ -7,9 +7,9 @@ import com.intellij.util.ui.JBUI.Borders.empty
 import org.digma.intellij.plugin.document.CodeObjectsUtil
 import org.digma.intellij.plugin.model.rest.insights.SpanDurationBreakdown
 import org.digma.intellij.plugin.model.rest.insights.SpanDurationBreakdownInsight
-import org.digma.intellij.plugin.service.InsightsActionsService
 import org.digma.intellij.plugin.ui.common.*
 import org.digma.intellij.plugin.ui.list.PanelsLayoutHelper
+import org.digma.intellij.plugin.ui.list.openWorkspaceFileForSpan
 import org.digma.intellij.plugin.ui.panels.DigmaResettablePanel
 import java.awt.BorderLayout
 import java.awt.GridLayout
@@ -186,11 +186,7 @@ private fun getSpanDisplayNameLabel(
 
     val messageLabel = if (moreData.contains(spanId)) {
         ActionLink(asHtml(displayName)) {
-            val actionListener: InsightsActionsService = project.getService(InsightsActionsService::class.java)
-
-            @Suppress("UNCHECKED_CAST")
-            val workspaceUri: Pair<String, Int> = moreData[spanId] as Pair<String, Int>
-            actionListener.openWorkspaceFileForSpan(workspaceUri.first, workspaceUri.second)
+            openWorkspaceFileForSpan(project, moreData, spanId)
         }
     } else {
         JLabel(asHtml(displayName), SwingConstants.LEFT)

src/main/kotlin/org/digma/intellij/plugin/ui/list/insights/SlowestSpansPanel.kt

@@ -6,11 +6,11 @@ import com.intellij.ui.components.JBLabel
 import com.intellij.util.ui.JBUI
 import org.digma.intellij.plugin.document.CodeObjectsUtil
 import org.digma.intellij.plugin.model.rest.insights.*
-import org.digma.intellij.plugin.service.InsightsActionsService
 import org.digma.intellij.plugin.ui.common.Laf
 import org.digma.intellij.plugin.ui.common.asHtml
 import org.digma.intellij.plugin.ui.common.buildBoldTitleGrayedComment
 import org.digma.intellij.plugin.ui.common.buildLinkTextWithTitleAndGrayedComment
+import org.digma.intellij.plugin.ui.list.openWorkspaceFileForSpan
 import java.awt.GridLayout
 import java.math.BigDecimal
 import java.math.RoundingMode
@@ -31,10 +31,7 @@ fun slowestSpansPanel(project: Project, insight: SlowestSpansInsight, moreData:
         if (moreData.contains(spanId)) {
             val spanText = buildLinkTextWithTitleAndGrayedComment(displayName,description)
             val link = ActionLink(spanText) {
-                val actionListener: InsightsActionsService = project.getService(InsightsActionsService::class.java)
-                @Suppress("UNCHECKED_CAST")
-                val workspaceUri: Pair<String, Int> = moreData[spanId] as Pair<String, Int>
-                actionListener.openWorkspaceFileForSpan(workspaceUri.first, workspaceUri.second)
+                openWorkspaceFileForSpan(project, moreData, spanId)
             }
             link.toolTipText = genToolTip(slowSpan)
             spansListPanel.add(link)

src/main/kotlin/org/digma/intellij/plugin/ui/list/summaries/SummaryPanelListCellRenderer.kt

@@ -11,15 +11,11 @@ import org.digma.intellij.plugin.model.rest.insights.SpanDurationChangeInsight
 import org.digma.intellij.plugin.model.rest.insights.SpanDurationsPercentile
 import org.digma.intellij.plugin.model.rest.insights.TopErrorFlowsInsight
 import org.digma.intellij.plugin.service.ErrorsActionsService
-import org.digma.intellij.plugin.service.InsightsActionsService
 import org.digma.intellij.plugin.ui.common.CopyableLabelHtml
 import org.digma.intellij.plugin.ui.common.Laf
 import org.digma.intellij.plugin.ui.common.asHtml
 import org.digma.intellij.plugin.ui.common.buildLinkTextWithGrayedAndDefaultLabelColorPart
-import org.digma.intellij.plugin.ui.list.AbstractPanelListCellRenderer
-import org.digma.intellij.plugin.ui.list.PanelsLayoutHelper
-import org.digma.intellij.plugin.ui.list.RoundedPanel
-import org.digma.intellij.plugin.ui.list.commonListItemPanel
+import org.digma.intellij.plugin.ui.list.*
 import org.digma.intellij.plugin.ui.list.errors.contentOfFirstAndLast
 import org.digma.intellij.plugin.ui.list.insights.genericPanelForSingleInsight
 import org.digma.intellij.plugin.ui.list.insights.percentileRowPanel
@@ -115,11 +111,7 @@ private fun buildSpanDuration(value: SpanDurationChangeInsight.Change, moreData:
     val spanId = CodeObjectsUtil.createSpanId(value.span.instrumentationLibrary, value.span.name)
     val title = if (moreData.contains(spanId)) {
         ActionLink(asHtml(value.span.displayName)) {
-            val actionListener: InsightsActionsService = project.getService(InsightsActionsService::class.java)
-
-            @Suppress("UNCHECKED_CAST")
-            val workspaceUri: Pair<String, Int> = moreData[spanId] as Pair<String, Int>
-            actionListener.openWorkspaceFileForSpan(workspaceUri.first, workspaceUri.second)
+            openWorkspaceFileForSpan(project, moreData, spanId)
         }
     } else{
         JLabel(asHtml(value.span.displayName), SwingConstants.LEFT)