Merge pull request #2652 from digma-ai/fix-update-loop-in-backend-info-holder

fix-update-loop-in-backend-info-holder

Author: shalom938

ide-common/src/main/kotlin/org/digma/intellij/plugin/analytics/BackendInfoHolder.kt

@@ -15,14 +15,18 @@ import org.digma.intellij.plugin.log.Log
 import org.digma.intellij.plugin.model.rest.AboutResult
 import org.digma.intellij.plugin.persistence.PersistenceService
 import org.digma.intellij.plugin.posthog.ActivityMonitor
+import org.digma.intellij.plugin.scheduling.disposingOneShotDelayedTask
 import org.digma.intellij.plugin.scheduling.disposingPeriodicTask
 import org.digma.intellij.plugin.scheduling.oneShotTask
 import java.util.concurrent.atomic.AtomicReference
+import kotlin.jvm.Throws
 import kotlin.time.Duration.Companion.minutes
+import kotlin.time.Duration.Companion.seconds
 
 /**
  * keep the backend info and tracks it on connection events.
  */
+//TODO: convert backend info to application service
 @Service(Service.Level.PROJECT)
 class BackendInfoHolder(val project: Project) : DisposableAdaptor {
 
@@ -127,8 +131,26 @@ class BackendInfoHolder(val project: Project) : DisposableAdaptor {
     }
 
 
-    //must be called in background coroutine
+    //must be called in background coroutine.
+    //if failed update will try again after 5 seconds
     private fun update() {
+        try {
+            updateImpl()
+        } catch (e: Throwable) {
+            Log.log(logger::trace, "update failed  trying again in 5 seconds")
+            //if update fails run another try after 2 seconds. maybe it was a momentary error from AnalyticsService.
+            // if that will not succeed there will be another periodic update soon
+            disposingOneShotDelayedTask("BackendInfoHolder.update-fallback", 5.seconds.inWholeMilliseconds) {
+                Log.log(logger::trace, "calling updateImpl after 5 seconds delay")
+                updateImpl()
+            }
+        }
+    }
+
+
+    //Note that updateImpl rethrows exceptions
+    @Throws(Throwable::class)
+    private fun updateImpl(){
         try {
             if (isProjectValid(project)) {
                 Log.log(logger::trace, "updating backend info")
@@ -139,16 +161,12 @@ class BackendInfoHolder(val project: Project) : DisposableAdaptor {
                 Log.log(logger::trace, "backend info updated {}", aboutRef.get())
             }
         } catch (e: Throwable) {
-            Log.warnWithException(logger, project, e, "error in update")
+            Log.warnWithException(logger, project, e, "error in update {}",e)
             val isConnectionException = ExceptionUtils.isAnyConnectionException(e)
             if (!isConnectionException) {
                 ErrorReporter.getInstance().reportError(project, "BackendInfoHolder.update", e)
             }
-
-            //if update fails run another try immediately. maybe it was a momentary error from AnalyticsService.
-            // if that will not succeed then the next execution in 1 minute will hopefully succeed
-            updateInBackground()
-
+            throw e;
         }
     }