#282 Implement N+1 insight V1 (endpoint version without links)

Author: MykolaYaremchuk

ide-common/src/main/java/org/digma/intellij/plugin/insights/view/BuildersHolder.java

@@ -55,6 +55,8 @@ private ListViewItemBuilder<? extends CodeObjectInsight> newBuilder(InsightType
                 return new GroupListViewItemBuilder<HighUsageInsight>(InsightGroupType.HttpEndpoint, HighUsageInsight::getRoute, HighUsageInsight::getEndpointSpan);
             case SlowEndpoint:
                 return new GroupListViewItemBuilder<SlowEndpointInsight>(InsightGroupType.HttpEndpoint, SlowEndpointInsight::getRoute, SlowEndpointInsight::getEndpointSpan);
+            case EndpointSpaNPlusOne:
+                return new GroupListViewItemBuilder<EPNPlusSpansInsight>(InsightGroupType.HttpEndpoint, EPNPlusSpansInsight::getRoute, EPNPlusSpansInsight::getEndpointSpan);
             case Unmapped:
                 return new NoGroupListViewItemBuilder<UnmappedInsight>();
             default:

model/src/main/kotlin/org/digma/intellij/plugin/model/model.kt

@@ -27,6 +27,7 @@ enum class InsightType {
     NormalUsage,
     HighUsage,
     SlowEndpoint,
+    EndpointSpaNPlusOne,
     Unmapped,
     TopErrorFlows,
     SpanDurationChange,

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/CodeObjectInsight.kt

@@ -23,6 +23,7 @@ import java.util.*
     JsonSubTypes.Type(value = LowUsageInsight::class, name = "LowUsage"),
     JsonSubTypes.Type(value = NormalUsageInsight::class, name = "NormalUsage"),
     JsonSubTypes.Type(value = HighUsageInsight::class, name = "HighUsage"),
+    JsonSubTypes.Type(value = EPNPlusSpansInsight::class, name = "EndpointSpaNPlusOne"),
     JsonSubTypes.Type(value = SlowEndpointInsight::class, name = "SlowEndpoint"),
     JsonSubTypes.Type(value = SpanScalingInsight::class, name = "SpanScaling"),
     JsonSubTypes.Type(value = SpanDurationsInsight::class, name = "SpanDurations"),

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/EPNPlusSpansInsight.kt

@@ -0,0 +1,37 @@
+package org.digma.intellij.plugin.model.rest.insights
+
+import com.fasterxml.jackson.annotation.JsonCreator
+import org.digma.intellij.plugin.model.InsightType
+import java.beans.ConstructorProperties
+import java.util.*
+
+data class EPNPlusSpansInsight
+@JsonCreator(mode = JsonCreator.Mode.PROPERTIES)
+@ConstructorProperties(
+        "codeObjectId",
+        "environment",
+        "scope",
+        "importance",
+        "decorators",
+        "route",
+        "endpointSpan",
+        "actualStartTime",
+        "customStartTime",
+        "prefixedCodeObjectId",
+        "spans",
+)
+constructor(
+        override val codeObjectId: String,
+        override val environment: String,
+        override val scope: String,
+        override val importance: Int,
+        override val decorators: List<CodeObjectDecorator>?,
+        override var route: String,
+        override var endpointSpan: String,
+        override val actualStartTime: Date?,
+        override val customStartTime: Date?,
+        override val prefixedCodeObjectId: String?,
+        val spans: List<HighlyOccurringSpanInfo>,
+) : EndpointInsight {
+        override val type: InsightType = InsightType.EndpointSpaNPlusOne
+}

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/HighlyOccurringSpanInfo.kt

@@ -0,0 +1,18 @@
+package org.digma.intellij.plugin.model.rest.insights
+
+import com.fasterxml.jackson.annotation.JsonCreator
+import com.fasterxml.jackson.annotation.JsonIgnoreProperties
+import java.beans.ConstructorProperties
+
+@JsonIgnoreProperties(ignoreUnknown = true)
+data class HighlyOccurringSpanInfo
+@JsonCreator(mode = JsonCreator.Mode.PROPERTIES)
+@ConstructorProperties("occurrences", "internalSpan", "clientSpan", "traceId", "duration", "fraction")
+constructor(
+        val occurrences: Double,
+        val internalSpan: SpanInfo,
+        val clientSpan: SpanInfo,
+        val traceId: String,
+        val duration: Duration,
+        val fraction: Double,
+)

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/SlowSpanInfo.kt

@@ -12,5 +12,5 @@ constructor(val spanInfo: SpanInfo,
             val p50: Percentile, // Obsolete
             val p95: Percentile, // Obsolete
             val p99: Percentile, // Obsolete
-            val ProbabilityOfBeingBottleneck: Double?,
-            val AvgDurationWhenBeingBottleneck: Duration?)
+            val probabilityOfBeingBottleneck: Double?,
+            val avgDurationWhenBeingBottleneck: Duration?)

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/SpanInfo.kt

@@ -10,6 +10,6 @@ data class SpanInfo
 @ConstructorProperties("instrumentationLibrary", "name", "displayName", "serviceName", "codeObjectId")
 constructor(val instrumentationLibrary: String,
             val name: String,
-            val displayName: String,
+            val displayName: String?,
             val serviceName: String?,
             val codeObjectId: String?)

model/src/main/kotlin/org/digma/intellij/plugin/ui/model/insights/InsightListViewItem.kt

@@ -22,6 +22,7 @@ open class InsightListViewItem<INSIGHT : CodeObjectInsight>(insight: INSIGHT) :
                 InsightType.SpanEndpointBottleneck -> 67
                 InsightType.SpanDurationBreakdown -> 68
                 // HTTP Endpoints
+                InsightType.EndpointSpaNPlusOne -> 55
                 InsightType.SlowestSpans -> 40
                 InsightType.LowUsage -> 30
                 InsightType.NormalUsage -> 50

src/main/kotlin/org/digma/intellij/plugin/ui/common/HtmlUtil.kt

@@ -14,8 +14,8 @@ fun asHtmlNoBoby(value: String): String{
 }
 
 
-fun asHtml(content: String): String {
-    return "<html><body>${content}</body>"
+fun asHtml(content: String?): String {
+    return "<html><body>${content.orEmpty()}</body>"
 }
 
 

src/main/kotlin/org/digma/intellij/plugin/ui/common/Laf.kt

@@ -4,6 +4,7 @@ import com.intellij.icons.AllIcons
 import com.intellij.ui.JBColor
 import com.intellij.util.ui.JBUI
 import org.digma.intellij.plugin.icons.IconsUtil
+import org.digma.intellij.plugin.ui.common.Laf.Sizes.Companion.BUTTON_SIZE_24
 import org.digma.intellij.plugin.ui.common.Laf.Sizes.Companion.INSIGHT_ICON_SIZE_32
 import org.digma.intellij.plugin.ui.list.insights.ThreeDotsIcon
 import java.awt.Color
@@ -93,6 +94,7 @@ object Laf  {
                 @JvmStatic val ERRORS = SvgIcon.asIs("/icons/errors.svg")
                 @JvmStatic val HOTSPOT = SvgIcon.asIs("/icons/hotspot.svg")
                 @JvmStatic val LOW_USAGE = SvgIcon.asIs("/icons/traffic-low.svg")
+                @JvmStatic val N_PLUS_ONE = loadAndScaleIconByWidth("/icons/sql.png", BUTTON_SIZE_24)
                 @JvmStatic val NORMAL_USAGE = SvgIcon.asIs("/icons/traffic-normal.svg")
                 @JvmStatic val HIGH_USAGE = SvgIcon.asIs("/icons/traffic-high.svg")
                 @JvmStatic val WAITING_DATA = SvgIcon.asIs("/icons/sand-watch.svg")