don't log NoSelectedEnvironmentException in warn level

Author: shalom938

ide-common/src/main/java/org/digma/intellij/plugin/common/EDT.java

@@ -36,7 +36,7 @@ public static void assertEDT(String message) {
         }
         //log an error here, intellij will pop up an error message. usually we don't want an error message
         // but this should be caught in development time.
-        Log.log(LOGGER::error,message);
+        LOGGER.error(message);
     }
 
 

ide-common/src/main/java/org/digma/intellij/plugin/log/Log.java

@@ -2,6 +2,7 @@
 
 import com.intellij.openapi.diagnostic.Logger;
 import com.intellij.openapi.project.Project;
+import org.digma.intellij.plugin.analytics.NoSelectedEnvironmentException;
 import org.digma.intellij.plugin.errorreporting.*;
 
 import java.time.Duration;
@@ -31,6 +32,11 @@ public static void log(Consumer<String> consumer, String format, Object... args)
     }
 
     public static void debugWithException(Logger logger,Throwable e, String format, Object... args) {
+
+        if (!logger.isDebugEnabled()) {
+            return;
+        }
+
         if (FREQUENT_ERROR_DETECTOR.isTooFrequentException(format, e)) {
             return;
         }
@@ -39,24 +45,43 @@ public static void debugWithException(Logger logger,Throwable e, String format,
     }
 
     public static void debugWithException(Logger logger, Project project,Throwable e, String format, Object... args) {
+
+        if (!logger.isDebugEnabled()) {
+            return;
+        }
+
         if (FREQUENT_ERROR_DETECTOR.isTooFrequentException(format, e)) {
             return;
         }
+
         logger.debug(DIGMA_PROJECT + project.getName() + ": " + String.format(format.replace("{}", "%s"), args),e);
     }
 
+
     public static void warnWithException(Logger logger,Throwable e, String format, Object... args) {
-        if (FREQUENT_ERROR_DETECTOR.isTooFrequentException(format, e)) {
-            return;
+
+        //don't log NoSelectedEnvironmentException in warn level
+        if (e instanceof NoSelectedEnvironmentException) {
+            debugWithException(logger, e, format, args);
+        } else {
+            if (FREQUENT_ERROR_DETECTOR.isTooFrequentException(format, e)) {
+                return;
+            }
+            logger.warn(DIGMA + String.format(format.replace("{}", "%s"), args), e);
         }
-        logger.warn(DIGMA + String.format(format.replace("{}", "%s"), args),e);
     }
 
     public static void warnWithException(Logger logger, Project project,Throwable e, String format, Object... args) {
-        if (FREQUENT_ERROR_DETECTOR.isTooFrequentException(format, e)) {
-            return;
+
+        //don't log NoSelectedEnvironmentException in warn level
+        if (e instanceof NoSelectedEnvironmentException) {
+            debugWithException(logger, project, e, format, args);
+        } else {
+            if (FREQUENT_ERROR_DETECTOR.isTooFrequentException(format, e)) {
+                return;
+            }
+            logger.warn(DIGMA_PROJECT + project.getName() + ": " + String.format(format.replace("{}", "%s"), args), e);
         }
-        logger.warn(DIGMA_PROJECT + project.getName() + ": " + String.format(format.replace("{}", "%s"), args),e);
     }
 
 
@@ -68,30 +93,40 @@ public static void log(Consumer<String> consumer, String msg) {
         consumer.accept(DIGMA + msg);
     }
 
-    public static void error(Logger logger,Project project, Exception exception, String format, Object... args) {
-        if (FREQUENT_ERROR_DETECTOR.isTooFrequentException(format, exception)) {
-            return;
-        }
 
-        var msg = String.format(format.replace("{}", "%s"), args);
-        error(logger, exception, DIGMA_PROJECT + project.getName() + ": " + msg);
-        ErrorReporter.getInstance().reportError(project, "Log.error", exception);
+    //Note: We should never log error in intellij because logging error will popup a red error to the user.
+
+    private static void error(Logger logger, Project project, Exception exception, String format, Object... args) {
+
+        if (exception instanceof NoSelectedEnvironmentException) {
+            debugWithException(logger, exception, format, args);
+        } else {
+
+            if (FREQUENT_ERROR_DETECTOR.isTooFrequentException(format, exception)) {
+                return;
+            }
+
+            var msg = String.format(format.replace("{}", "%s"), args);
+            error(logger, exception, DIGMA_PROJECT + project.getName() + ": " + msg);
+            ErrorReporter.getInstance().reportError(project, "Log.error", exception);
+        }
     }
-    public static void error(Logger logger, Exception exception, String format, Object... args) {
+
+    private static void error(Logger logger, Exception exception, String format, Object... args) {
         if (FREQUENT_ERROR_DETECTOR.isTooFrequentException(format, exception)) {
             return;
         }
         error(logger, exception, DIGMA + String.format(format.replace("{}", "%s"), args));
     }
 
-    public static void error(Logger logger, Exception exception, String msg) {
+    private static void error(Logger logger, Exception exception, String msg) {
         if (FREQUENT_ERROR_DETECTOR.isTooFrequentException(msg, exception)) {
             return;
         }
         logger.error(DIGMA + msg, exception);
     }
 
-    public static void error(Logger logger, String msg) {
+    private static void error(Logger logger, String msg) {
         logger.error(DIGMA + msg);
     }