Skip to content

Commit 732e94e

Browse files
authored
Fixed span scaling histogram link (#299)
* Fixed scaling histogram * fixed auto import optimizer
1 parent ddbb460 commit 732e94e

File tree

4 files changed

+25
-2
lines changed

4 files changed

+25
-2
lines changed

analytics-provider/src/main/java/org/digma/intellij/plugin/analytics/AnalyticsProvider.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,6 @@ public interface AnalyticsProvider extends Closeable {
3333
UsageStatusResult getUsageStatus(UsageStatusRequest usageStatusRequest);
3434

3535
String getHtmlGraphForSpanPercentiles(SpanHistogramQuery request);
36+
37+
String getHtmlGraphForSpanScaling(SpanHistogramQuery request);
3638
}

analytics-provider/src/main/java/org/digma/intellij/plugin/analytics/RestAnalyticsProvider.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,12 @@ public String getHtmlGraphForSpanPercentiles(SpanHistogramQuery request) {
106106
return readEntire(responseBody);
107107
}
108108

109+
@Override
110+
public String getHtmlGraphForSpanScaling(SpanHistogramQuery request) {
111+
final ResponseBody responseBody = execute(() -> client.analyticsProvider.getHtmlGraphForSpanScaling(request));
112+
return readEntire(responseBody);
113+
}
114+
109115
protected static String readEntire(ResponseBody responseBody) {
110116
try (Reader reader = responseBody.charStream()) {
111117
return CharStreams.toString(reader);
@@ -323,6 +329,16 @@ private interface AnalyticsProviderRetrofit {
323329
Call<ResponseBody> getHtmlGraphForSpanPercentiles(@Body SpanHistogramQuery request);
324330

325331

332+
@Headers({
333+
"Accept: application/+json",
334+
"Content-Type:application/json"
335+
})
336+
@POST("/Graphs/graphForSpanScaling")
337+
// @Streaming means ResponseBody as is, without conversion
338+
@Streaming
339+
Call<ResponseBody> getHtmlGraphForSpanScaling(@Body SpanHistogramQuery request);
340+
341+
326342
@Headers({
327343
"Accept: application/+json",
328344
"Content-Type:application/json"

ide-common/src/main/java/org/digma/intellij/plugin/analytics/AnalyticsService.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,11 @@ public String getHtmlGraphForSpanPercentiles(String instrumentationLibrary, Stri
208208
return executeCatching(() -> analyticsProviderProxy.getHtmlGraphForSpanPercentiles(spanHistogramQuery));
209209
}
210210

211+
public String getHtmlGraphForSpanScaling(String instrumentationLibrary, String spanName, String backgroundColor) throws AnalyticsServiceException {
212+
final SpanHistogramQuery spanHistogramQuery = new SpanHistogramQuery(getCurrentEnvironment(), spanName, instrumentationLibrary, JBColor.isBright() ? "light" : "dark", backgroundColor);
213+
return executeCatching(() -> analyticsProviderProxy.getHtmlGraphForSpanScaling(spanHistogramQuery));
214+
}
215+
211216
@Override
212217
public void dispose() {
213218
try {

src/main/kotlin/org/digma/intellij/plugin/ui/list/insights/ScalingListViewItemsPanel.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ private fun buildButtonToPercentilesGraph(project: Project, spanName: String,ins
122122
val analyticsService = AnalyticsService.getInstance(project)
123123
val button = ListItemActionButton("Histogram")
124124
button.addActionListener {
125-
val htmlContent = analyticsService.getHtmlGraphForSpanPercentiles(instLibrary, spanName, Laf.Colors.PLUGIN_BACKGROUND.getHex())
126-
HTMLEditorProvider.openEditor(project, "Percentiles Graph of Span $spanName", htmlContent)
125+
val htmlContent = analyticsService.getHtmlGraphForSpanScaling(instLibrary, spanName, Laf.Colors.PLUGIN_BACKGROUND.getHex())
126+
HTMLEditorProvider.openEditor(project, "Scaling Graph of Span $spanName", htmlContent)
127127
}
128128

129129
return button

0 commit comments

Comments
 (0)