Skip to content

Commit 76baccc

Browse files
committed
kotlin 2
1 parent 35997bf commit 76baccc

File tree

3 files changed

+24
-15
lines changed

3 files changed

+24
-15
lines changed

common-build-logic/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ dependencies {
1414
//when updating intellij-platform-gradle-plugin update also org.jetbrains.intellij.platform.settings plugin
1515
// in settings file to the same version. we need to maintain it in two places, unfortunately.
1616
implementation("org.jetbrains.intellij.platform:intellij-platform-gradle-plugin:2.0.1") // Update also org.jetbrains.intellij.platform.settings in settings.gradle.kts
17-
// implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.24")
1817
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.20")
1918
implementation("com.glovoapp.gradle:versioning:1.1.10")
2019
implementation("de.undercouch:gradle-download-task:5.6.0")

common-build-logic/src/main/kotlin/common-kotlin.gradle.kts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,17 @@ tasks {
4242
withType<KotlinCompile> {
4343

4444
doFirst {
45-
//todo: migrate to 2.0.20, see https://kotlinlang.org/docs/gradle-compiler-options.html#target-the-jvm
4645
logger.lifecycle("compiling kotlin with jdk: ${kotlinJavaToolchain.javaVersion}")
47-
logger.lifecycle("Compiling kotlin with jvmTarget:${kotlinOptions.jvmTarget},apiVersion:${kotlinOptions.apiVersion},languageVersion:${kotlinOptions.languageVersion}")
46+
logger.lifecycle("Compiling kotlin with jvmTarget:${compilerOptions.jvmTarget.get()},apiVersion:${compilerOptions.apiVersion.get()},languageVersion:${compilerOptions.languageVersion.get()}")
4847
}
4948

50-
//todo: migrate to 2.0.20, see https://kotlinlang.org/docs/gradle-compiler-options.html#target-the-jvm
51-
kotlinOptions {
49+
compilerOptions {
5250
verbose = true
53-
jvmTarget = project.currentProfile().javaVersion
54-
apiVersion = project.currentProfile().kotlinTarget
55-
languageVersion = project.currentProfile().kotlinTarget
51+
apiVersion.set(project.currentProfile().kotlinTarget)
52+
languageVersion.set(project.currentProfile().kotlinTarget)
53+
jvmTarget.set(project.currentProfile().kotlinJvmTarget)
5654
}
55+
5756
}
5857

5958
}

common-build-logic/src/main/kotlin/common/BuildProfile.kt

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
1+
@file:Suppress("unused")
2+
13
package common
24

35
import org.gradle.api.GradleException
46
import org.gradle.api.JavaVersion
57
import org.gradle.api.Project
68
import org.jetbrains.intellij.platform.gradle.IntelliJPlatformType
9+
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
710
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion
811

912
//todo: some functions here are marked as not used but they are used. its an intellij issue.
@@ -74,6 +77,7 @@ fun Project.useBinaryInstaller(): Boolean = !this.currentProfile().isEAP
7477

7578
object BuildProfiles {
7679

80+
@Suppress("EnumEntryName")
7781
enum class Profile { p231, p232, p233, p241, p242, p243 }
7882

7983
fun Profile.greaterThan(other:Profile):Boolean{
@@ -143,7 +147,8 @@ object BuildProfiles {
143147
platformVersionCode = "231",
144148
pluginSinceBuild = "231",
145149
pluginUntilBuild = "231.*",
146-
kotlinTarget = KotlinVersion.KOTLIN_1_8.version,
150+
kotlinTarget = KotlinVersion.KOTLIN_1_8,
151+
kotlinJvmTarget = JvmTarget.JVM_17,
147152
javaVersion = JavaVersion.VERSION_17.majorVersion
148153
),
149154

@@ -157,7 +162,8 @@ object BuildProfiles {
157162
platformVersionCode = "232",
158163
pluginSinceBuild = "232",
159164
pluginUntilBuild = "232.*",
160-
kotlinTarget = KotlinVersion.KOTLIN_1_8.version,
165+
kotlinTarget = KotlinVersion.KOTLIN_1_8,
166+
kotlinJvmTarget = JvmTarget.JVM_17,
161167
javaVersion = JavaVersion.VERSION_17.majorVersion
162168
),
163169

@@ -172,7 +178,8 @@ object BuildProfiles {
172178
platformVersionCode = "233",
173179
pluginSinceBuild = "233",
174180
pluginUntilBuild = "233.*",
175-
kotlinTarget = KotlinVersion.KOTLIN_1_9.version,
181+
kotlinTarget = KotlinVersion.KOTLIN_1_9,
182+
kotlinJvmTarget = JvmTarget.JVM_17,
176183
javaVersion = JavaVersion.VERSION_17.majorVersion
177184
),
178185

@@ -187,7 +194,8 @@ object BuildProfiles {
187194
platformVersionCode = "241",
188195
pluginSinceBuild = "241",
189196
pluginUntilBuild = "241.*",
190-
kotlinTarget = KotlinVersion.KOTLIN_1_9.version,
197+
kotlinTarget = KotlinVersion.KOTLIN_1_9,
198+
kotlinJvmTarget = JvmTarget.JVM_17,
191199
javaVersion = JavaVersion.VERSION_17.majorVersion,
192200
),
193201

@@ -203,7 +211,8 @@ object BuildProfiles {
203211
platformVersionCode = "242",
204212
pluginSinceBuild = "242",
205213
pluginUntilBuild = "242.*",
206-
kotlinTarget = KotlinVersion.KOTLIN_1_9.version,
214+
kotlinTarget = KotlinVersion.KOTLIN_1_9,
215+
kotlinJvmTarget = JvmTarget.JVM_17,
207216
javaVersion = JavaVersion.VERSION_17.majorVersion,
208217
),
209218

@@ -225,7 +234,8 @@ object BuildProfiles {
225234
platformVersionCode = "243",
226235
pluginSinceBuild = "243",
227236
pluginUntilBuild = "243.*",
228-
kotlinTarget = KotlinVersion.KOTLIN_2_0.version,
237+
kotlinTarget = KotlinVersion.KOTLIN_2_0,
238+
kotlinJvmTarget = JvmTarget.JVM_21,
229239
javaVersion = JavaVersion.VERSION_21.majorVersion,
230240
)
231241

@@ -244,6 +254,7 @@ data class BuildProfile(
244254
val platformVersionCode: String,
245255
val pluginSinceBuild: String,
246256
val pluginUntilBuild: String,
247-
val kotlinTarget: String,
257+
val kotlinTarget: KotlinVersion,
258+
val kotlinJvmTarget: JvmTarget,
248259
val javaVersion: String,
249260
)

0 commit comments

Comments
 (0)