catch exceptions in settings changed

Author: shalom938

ide-common/src/main/kotlin/org/digma/intellij/plugin/updates/AggressiveUpdateService.kt

@@ -116,12 +116,22 @@ class AggressiveUpdateService : Disposable {
 
                 @Suppress("UnstableApiUsage")
                 disposingScope().launch {
-                    //update state immediately after settings change. we are interested in api url change but it will
-                    // do no harm to call it on any settings change
-                    updateState()
+                    try {
+                        //update state immediately after settings change. we are interested in api url change, but it will
+                        // do no harm to call it on any settings change
+                        updateState()
+                    } catch (c: CancellationException) {
+                        Log.debugWithException(logger, c, "settings change canceled {}", c)
+                    } catch (e: Throwable) {
+                        val message = ExceptionUtils.getNonEmptyMessage(e)
+                        Log.debugWithException(logger, e, "error in settings changed {}", message)
+                        errorReporter.reportError("${this::class.simpleName}.settingsChange", e)
+                    }
+
                     //and call startMonitoring just in case it is stopped by a previous connectionLost but there was no connection gained
                     startMonitoring()
                 }
+
             }, this)
 
         } else {

ide-common/src/main/kotlin/org/digma/intellij/plugin/updates/UpdatesService.kt

@@ -93,18 +93,33 @@ class UpdatesService(private val project: Project) : Disposable {
 
                 override fun connectionGained() {
                     Log.log(logger::debug, "got connectionGained")
-                    //update state immediately after connectionGained, so it will not wait the delay for checking the versions.
-                    checkForNewerVersions()
+
+                    try {
+                        //update state immediately after connectionGained, so it will not wait the delay for checking the versions.
+                        checkForNewerVersions()
+                    } catch (e: CancellationException) {
+                        Log.debugWithException(logger, e, "Exception in checkForNewerVersions")
+                    } catch (e: Throwable) {
+                        Log.debugWithException(logger, e, "Exception in checkForNewerVersions {}", ExceptionUtils.getNonEmptyMessage(e))
+                        ErrorReporter.getInstance().reportError("UpdatesService.connectionGained", e)
+                    }
                 }
             })
 
 
         SettingsState.getInstance().addChangeListener({
             @Suppress("UnstableApiUsage")
             disposingScope().launch {
-                //update state immediately after settings change. we are interested in api url change, but it will
-                // do no harm to call it on any settings change
-                checkForNewerVersions()
+                try {
+                    //update state immediately after settings change. we are interested in api url change, but it will
+                    // do no harm to call it on any settings change
+                    checkForNewerVersions()
+                } catch (e: CancellationException) {
+                    Log.debugWithException(logger, e, "Exception in checkForNewerVersions")
+                } catch (e: Throwable) {
+                    Log.debugWithException(logger, e, "Exception in checkForNewerVersions {}", ExceptionUtils.getNonEmptyMessage(e))
+                    ErrorReporter.getInstance().reportError("UpdatesService.settingsChanged", e)
+                }
             }
 
         }, this)
@@ -114,6 +129,7 @@ class UpdatesService(private val project: Project) : Disposable {
         //nothing to do , used as parent disposable
     }
 
+    //this method may throw exception, always catch and report
     private fun checkForNewerVersions() {
 
         Log.log(logger::trace, "checking for new versions")