force observability with DIGMA_OBSERVABILITY

Author: shalom938

jvm-common/src/main/kotlin/org/digma/intellij/plugin/idea/execution/constants.kt

@@ -24,13 +24,16 @@ to force a different instrumentation flavor add INSTRUMENTATION_FLAVOR environme
  org.digma.intellij.plugin.idea.execution.flavor.InstrumentationFlavorType.
 examples:
 if running a task called myTask that we don't support:
-DIGMA_OBSERVABILITY or DIGMA_OBSERVABILITY=app -> will be treated as regula application with the default flavor
-DIGMA_OBSERVABILITY=test -> will be treated as a test execution.
+DIGMA_OBSERVABILITY or DIGMA_OBSERVABILITY=app -> will be treated as regular application with the default flavor.
+DIGMA_OBSERVABILITY=test -> will be treated as a test execution with the default flavor.
 
 together with
 DIGMA_OBSERVABILITY=test
 INSTRUMENTATION_FLAVOR=Quarkus
 will be treated as Quarkus flavor and a test execution.
+
+don't add DIGMA_OBSERVABILITY if it's not necessary, it may confuse the instrumentation flavor.
+
 */
 const val DIGMA_OBSERVABILITY = "DIGMA_OBSERVABILITY"
 

jvm-common/src/main/kotlin/org/digma/intellij/plugin/idea/execution/services/BaseJvmRunConfigurationInstrumentationService.kt

@@ -67,7 +67,7 @@ abstract class BaseJvmRunConfigurationInstrumentationService : RunConfigurationI
                 ?: return null
 
             //if DIGMA_OBSERVABILITY exists force observability with InstrumentationFlavorType.Default.
-            //no need to check if INSTRUMENTATION_FLAVOR exists, if it did InstrumentationFlavor.get would return something.
+            //no need to check if INSTRUMENTATION_FLAVOR exists, if it existed InstrumentationFlavor.get would return something.
             //InstrumentationFlavor.getByType must return something, or we have a bug. it will throw an exception
             // if not. the exception will be caught and reported.
             instrumentationFlavor = InstrumentationFlavor.getByType(InstrumentationFlavorType.Default)