Skip to content

Commit 8d69b1b

Browse files
committed
compare deice lists instead of just size
1 parent 5435b61 commit 8d69b1b

File tree

5 files changed

+18
-20
lines changed

5 files changed

+18
-20
lines changed

ide-common/src/main/kotlin/org/digma/intellij/plugin/reload/ReloadObserver.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import java.beans.PropertyChangeListener
2323
import java.util.Queue
2424
import java.util.concurrent.ConcurrentLinkedQueue
2525
import javax.swing.JComponent
26-
import javax.swing.JPanel
2726
import kotlin.time.Duration.Companion.seconds
2827

2928

@@ -73,7 +72,7 @@ class ReloadObserver(cs: CoroutineScope) {
7372
}
7473

7574

76-
fun register(project: Project, jcefWrapperPanel: JPanel, jcefUiComponent: JComponent, parentDisposable: Disposable) {
75+
fun register(project: Project, appName: String, jcefUiComponent: JComponent, parentDisposable: Disposable) {
7776

7877
if (GraphicsEnvironment.isHeadless()) {
7978
Log.log(logger::trace, "GraphicsEnvironment is headless, not registering components")
@@ -86,7 +85,7 @@ class ReloadObserver(cs: CoroutineScope) {
8685
}
8786

8887
val jcefPropertyChangeListener =
89-
MyPropertyChangeListener(project, jcefUiComponent, "${jcefWrapperPanel.javaClass.simpleName}.jcefUiComponent")
88+
MyPropertyChangeListener(project, jcefUiComponent, "$appName.jcefUiComponent")
9089
jcefUiComponent.addPropertyChangeListener(jcefPropertyChangeListener)
9190

9291
Disposer.register(parentDisposable) {

ide-common/src/main/kotlin/org/digma/intellij/plugin/reload/ReloadService.kt

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import org.digma.intellij.plugin.log.Log
1616
import org.digma.intellij.plugin.recentactivity.RecentActivityToolWindowShower
1717
import org.digma.intellij.plugin.ui.MainToolWindowCardsController
1818
import org.digma.intellij.plugin.ui.ToolWindowShower
19-
import org.digma.intellij.plugin.ui.panels.ReloadablePanel
2019
import java.util.concurrent.locks.ReentrantLock
2120
import kotlin.concurrent.withLock
2221
import kotlin.time.Duration.Companion.seconds
@@ -26,22 +25,22 @@ class ReloadService : DisposableAdaptor {
2625

2726
private val logger = Logger.getInstance(ReloadService::class.java)
2827

29-
private val reloadables = mutableListOf<ReloadablePanel>()
28+
private val reloadables = mutableListOf<ReloadableJCefContainer>()
3029

3130
private val latestReloadForProject = mutableMapOf<String, Instant>()
3231

3332
private val myReloadLock = ReentrantLock(true)
3433

3534

36-
fun register(reloadablePanel: ReloadablePanel, parentDisposable: Disposable) {
37-
reloadables.add(reloadablePanel)
35+
fun register(reloadableJCefContainer: ReloadableJCefContainer, parentDisposable: Disposable) {
36+
reloadables.add(reloadableJCefContainer)
3837
Disposer.register(parentDisposable) {
39-
remove(reloadablePanel)
38+
remove(reloadableJCefContainer)
4039
}
4140
}
4241

43-
fun remove(reloadablePanel: ReloadablePanel) {
44-
reloadables.remove(reloadablePanel)
42+
fun remove(reloadableJCefContainer: ReloadableJCefContainer) {
43+
reloadables.remove(reloadableJCefContainer)
4544
}
4645

4746

ide-common/src/main/kotlin/org/digma/intellij/plugin/ui/panels/ReloadablePanel.kt renamed to ide-common/src/main/kotlin/org/digma/intellij/plugin/reload/ReloadableJCefContainer.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
package org.digma.intellij.plugin.ui.panels
1+
package org.digma.intellij.plugin.reload
22

33
import com.intellij.openapi.project.Project
44

5-
interface ReloadablePanel {
5+
interface ReloadableJCefContainer {
66
fun reload()
77
fun getProject(): Project
88
}

src/main/kotlin/org/digma/intellij/plugin/ui/mainapp/MainAppPanel.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@ import org.digma.intellij.plugin.ui.list.listBackground
1414
import org.digma.intellij.plugin.ui.navigation.CodeButtonCaretContextService
1515
import org.digma.intellij.plugin.ui.navigation.NavigationService
1616
import org.digma.intellij.plugin.ui.panels.DisposablePanel
17-
import org.digma.intellij.plugin.ui.panels.ReloadablePanel
17+
import org.digma.intellij.plugin.reload.ReloadableJCefContainer
1818
import org.digma.intellij.plugin.ui.tests.TestsUpdater
1919
import java.awt.BorderLayout
2020
import java.awt.Insets
2121
import javax.swing.JComponent
2222
import javax.swing.JLabel
2323

24-
class MainAppPanel(private val project: Project) : DisposablePanel(), ReloadablePanel {
24+
class MainAppPanel(private val project: Project) : DisposablePanel(), ReloadableJCefContainer {
2525

2626
private var jCefComponent: JCefComponent? = null
2727

@@ -31,7 +31,7 @@ class MainAppPanel(private val project: Project) : DisposablePanel(), Reloadable
3131
jCefComponent = build()
3232
jCefComponent?.let {
3333
service<ReloadService>().register(this, parentDisposable)
34-
service<ReloadObserver>().register(project, this, it.getComponent(), parentDisposable)
34+
service<ReloadObserver>().register(project, "MainApp", it.getComponent(), parentDisposable)
3535
}
3636
Disposer.register(MainAppService.getInstance(project)) {
3737
dispose()
@@ -69,7 +69,7 @@ class MainAppPanel(private val project: Project) : DisposablePanel(), Reloadable
6969
jCefComponent = build()
7070
jCefComponent?.let {
7171
service<ReloadService>().register(this, parentDisposable)
72-
service<ReloadObserver>().register(project, this, it.getComponent(), parentDisposable)
72+
service<ReloadObserver>().register(project, "MainApp", it.getComponent(), parentDisposable)
7373
}
7474
}
7575

src/main/kotlin/org/digma/intellij/plugin/ui/recentactivity/RecentActivityPanel.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ import org.digma.intellij.plugin.ui.jcef.JCefComponent
1111
import org.digma.intellij.plugin.ui.jcef.JCefComponent.JCefComponentBuilder
1212
import org.digma.intellij.plugin.ui.list.listBackground
1313
import org.digma.intellij.plugin.ui.panels.DisposablePanel
14-
import org.digma.intellij.plugin.ui.panels.ReloadablePanel
14+
import org.digma.intellij.plugin.reload.ReloadableJCefContainer
1515
import java.awt.BorderLayout
1616
import java.awt.Insets
1717
import javax.swing.JComponent
1818
import javax.swing.JLabel
1919

20-
class RecentActivityPanel(private val project: Project) : DisposablePanel(), ReloadablePanel {
20+
class RecentActivityPanel(private val project: Project) : DisposablePanel(), ReloadableJCefContainer {
2121

2222
private var jCefComponent: JCefComponent? = null
2323

@@ -27,7 +27,7 @@ class RecentActivityPanel(private val project: Project) : DisposablePanel(), Rel
2727
jCefComponent = build()
2828
jCefComponent?.let {
2929
service<ReloadService>().register(this, parentDisposable)
30-
service<ReloadObserver>().register(project, this, it.getComponent(), parentDisposable)
30+
service<ReloadObserver>().register(project, "RecentActivity", it.getComponent(), parentDisposable)
3131
}
3232
Disposer.register(project.service<RecentActivityService>()) {
3333
dispose()
@@ -64,7 +64,7 @@ class RecentActivityPanel(private val project: Project) : DisposablePanel(), Rel
6464
jCefComponent = build()
6565
jCefComponent?.let {
6666
service<ReloadService>().register(this, parentDisposable)
67-
service<ReloadObserver>().register(project, this, it.getComponent(), parentDisposable)
67+
service<ReloadObserver>().register(project, "RecentActivity", it.getComponent(), parentDisposable)
6868
}
6969
}
7070

0 commit comments

Comments
 (0)