app names constants

Author: shalom938

ide-common/src/main/kotlin/org/digma/intellij/plugin/posthog/ActivityMonitor.kt

@@ -719,15 +719,6 @@ class ActivityMonitor(private val project: Project, cs: CoroutineScope) : Dispos
         postHog?.capture(UniqueGeneratedUserId.userId, "plugin first-init")
     }
 
-    fun registerUIUpdate(eventName: String, details: Map<String, Any>) {
-        //here use postHog.capture directly, this event is called from UIVersioningService while its initializing,
-        // it cannot call the common capture method because it may cause a circular dependency between UIVersioningService
-        // and ActivityMonitor because the capture method will call UIVersioningService.getInstance().getCurrentUiVersion().
-        //although UIVersioningService initialize fast enough, there may be a race condition if the capture method calls
-        // UIVersioningService.getInstance().getCurrentUiVersion() before UIVersioningService constructor completes.
-        // also, this event doesn't need all the common properties.
-        postHog?.capture(UniqueGeneratedUserId.userId, eventName,details)
-    }
 
     fun registerProjectOpened(openProjects: Int) {
         capture("project opened", mapOf("open.projects" to openProjects))
@@ -1138,5 +1129,34 @@ class ActivityMonitor(private val project: Project, cs: CoroutineScope) : Dispos
 
     }
 
+    fun registerUIUpdate(
+        bundledVersion: String,
+        currentVersion: String,
+        latestDownloadedUiVersion: String,
+        updateToVersion: String,
+        isOnStartup: Boolean,
+        isForceUpdate: Boolean
+    ) {
+
+        //here use postHog.capture directly, this event is called from UIVersioningService while its initializing,
+        // it cannot call the common capture method because it may cause a circular dependency between UIVersioningService
+        // and ActivityMonitor because the capture method will call UIVersioningService.getInstance().getCurrentUiVersion().
+        //although UIVersioningService initialize fast enough, there may be a race condition if the capture method calls
+        // UIVersioningService.getInstance().getCurrentUiVersion() before UIVersioningService constructor completes.
+        // also, this event doesn't need all the common properties.
+
+        val details = mapOf(
+            "bundledVersion" to bundledVersion,
+            "currentVersion" to currentVersion,
+            "latestDownloadedUiVersion" to latestDownloadedUiVersion,
+            "updateToVersion" to updateToVersion,
+            "isOnStartup" to isOnStartup,
+            "isForceUpdate" to isForceUpdate
+        )
+
+        postHog?.capture(UniqueGeneratedUserId.userId, "ui update", details)
+
+    }
+
 
 }

ide-common/src/main/kotlin/org/digma/intellij/plugin/updates/ui/UIVersioningService.kt

@@ -174,12 +174,12 @@ class UIVersioningService(val cs: CoroutineScope) : DisposableAdaptor {
 
                     findActiveProject()?.let {
                         ActivityMonitor.getInstance(it).registerUIUpdate(
-                            "ui update on startup", mapOf(
-                                "update to version" to latestDownloadedUiVersion,
-                                "current ui version" to getCurrentUiVersion(),
-                                "latest downloaded version" to latestDownloadedUiVersion,
-                                "bundled version" to bundledUiVersion
-                            )
+                            bundledUiVersion,
+                            getCurrentUiVersion(),
+                            latestDownloadedUiVersion,
+                            latestDownloadedUiVersion,
+                            isOnStartup = true,
+                            isForceUpdate = false
                         )
                     }
 
@@ -331,7 +331,8 @@ class UIVersioningService(val cs: CoroutineScope) : DisposableAdaptor {
     }
 
     private fun fireNewUIVersionAvailable() {
-        ApplicationManager.getApplication().messageBus.syncPublisher(NewUIVersionAvailableEvent.NEW_UI_VERSION_AVAILABLE_EVENT_TOPIC).newUIVersionAvailable()
+        ApplicationManager.getApplication().messageBus.syncPublisher(NewUIVersionAvailableEvent.NEW_UI_VERSION_AVAILABLE_EVENT_TOPIC)
+            .newUIVersionAvailable()
     }
 
 
@@ -360,7 +361,7 @@ class UIVersioningService(val cs: CoroutineScope) : DisposableAdaptor {
                 )
                 setLatestDownloadedVersion(null)
             }
-        }else{
+        } else {
             ErrorReporter.getInstance().reportError(
                 "UIVersioningService.updateToLatestDownloaded",
                 "updateToLatestDownloaded called but latestDownloadedUiVersion property is null", mapOf(
@@ -399,20 +400,19 @@ class UIVersioningService(val cs: CoroutineScope) : DisposableAdaptor {
 
             findActiveProject()?.let {
                 ActivityMonitor.getInstance(it).registerUIUpdate(
-                    "ui update", mapOf(
-                        "update to version" to uiVersion,
-                        "current ui version" to getCurrentUiVersion(),
-                        "latest downloaded version" to getLatestDownloadedVersion().toString(),
-                        "bundled version" to bundledUiVersion,
-                        "isForceUpdate" to isForceUpdate
-                    )
+                    bundledUiVersion,
+                    getCurrentUiVersion(),
+                    getLatestDownloadedVersion().toString(),
+                    uiVersion,
+                    false,
+                    isForceUpdate
                 )
             }
 
             deleteUiBundle(getCurrentUiVersion())
             setCurrentUiVersion(uiVersion)
             service<ReloadService>().reloadAllProjects(ReloadSource.UI_UPDATE)
-        }else{
+        } else {
             ErrorReporter.getInstance().reportError(
                 "UIVersioningService.updateToDownloadedVersion", "updateToDownloadedVersion called but ui bundle file does not exist",
                 mapOf(