Skip to content

Commit 9cf8403

Browse files
committed
Review Fixes
1 parent 1e2b10f commit 9cf8403

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

ide-common/src/main/java/org/digma/intellij/plugin/insights/view/GroupListViewItemBuilder.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import org.jetbrains.annotations.NotNull;
1414

1515
import java.util.ArrayList;
16-
import java.util.Collection;
1716
import java.util.List;
1817
import java.util.function.Function;
1918
import java.util.stream.Collectors;
@@ -91,25 +90,25 @@ private List<String> getCodeObjectIds(SpanUsagesInsight insight) {
9190
private List<String> getCodeObjectIds(SpanScalingRootCauseInsight insight) {
9291
return insight.getAffectedEndpoints().stream().filter(it -> it.getCodeObjectId() != null)
9392
.map(it -> it.getCodeObjectId())
94-
.collect(Collectors.toList());
93+
.toList();
9594
}
9695

9796
private List<String> getCodeObjectIds(SpanSlowEndpointsInsight insight) {
9897
return insight.getSlowEndpoints().stream().filter(it -> it.getEndpointInfo().getCodeObjectId() != null)
9998
.map(it -> it.getEndpointInfo().getCodeObjectId())
100-
.collect(Collectors.toList());
99+
.toList();
101100
}
102101

103102
private List<String> getSpanIds(SpanScalingInsight insight) {
104103
return insight.getRootCauseSpans().stream()
105104
.map(it -> CodeObjectsUtil.createSpanId(it.getInstrumentationLibrary(), it.getName()))
106-
.collect(Collectors.toList());
105+
.toList();
107106
}
108107

109108
private List<String> getSpanIds(SlowestSpansInsight insight) {
110109
return insight.getSpans().stream()
111110
.map(it -> CodeObjectsUtil.createSpanId(it.getSpanInfo().getInstrumentationLibrary(), it.getSpanInfo().getName()))
112-
.collect(Collectors.toList());
111+
.toList();
113112
}
114113

115114
private List<String> getSpanIds(SpanDurationBreakdownInsight insight) {

model/src/main/kotlin/org/digma/intellij/plugin/model/rest/insights/SpanScalingRootCauseInsight.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ package org.digma.intellij.plugin.model.rest.insights
33
import com.fasterxml.jackson.annotation.JsonCreator
44
import org.digma.intellij.plugin.model.InsightType
55
import java.beans.ConstructorProperties
6-
import java.util.*
6+
import java.util.Date
7+
import kotlin.collections.ArrayList
78

89

910
data class SpanScalingRootCauseInsight

src/main/kotlin/org/digma/intellij/plugin/ui/list/insights/ScalingListViewItemsPanel.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import com.intellij.util.ui.JBUI.Borders.emptyBottom
99
import org.apache.commons.lang3.StringUtils
1010
import org.digma.intellij.plugin.analytics.AnalyticsService
1111
import org.digma.intellij.plugin.document.CodeObjectsUtil
12-
import org.digma.intellij.plugin.model.rest.insights.*
12+
import org.digma.intellij.plugin.model.rest.insights.RootCauseSpan
13+
import org.digma.intellij.plugin.model.rest.insights.SpanScalingInsight
1314
import org.digma.intellij.plugin.ui.common.*
1415
import org.digma.intellij.plugin.ui.list.ListItemActionButton
1516
import org.digma.intellij.plugin.ui.list.openWorkspaceFileForSpan

0 commit comments

Comments
 (0)