ui error handling

Author: shaykeren

ide-common/src/main/kotlin/org/digma/intellij/plugin/errorreporting/ErrorReporter.kt

@@ -116,22 +116,24 @@ open class ErrorReporter {
         )
     }
 
-    private fun isTooFrequent(message: String, stackTrace: String ?): Boolean{
-        if(!stackTrace.isNullOrEmpty()){
+    private fun isTooFrequent(message: String, stackTrace: String?): Boolean {
+        if (!stackTrace.isNullOrEmpty()) {
             return frequencyDetector.isTooFrequentStackTrace(message, stackTrace);
         }
-        return frequencyDetector.isTooFrequentError(message,"");
+        return frequencyDetector.isTooFrequentError(message, "");
     }
-    open fun reportError(message: String, stackTrace: String ?, details: Map<String, Any>, project: Project?, useFrequencyDetector: Boolean = true) {
-        if(message.isNullOrEmpty() && stackTrace.isNullOrEmpty())
-        {
-            reportError(project, "At least one of the following properties must be set: [message] or [stackTrace].","reportError",
+
+    open fun reportError(message: String, stackTrace: String?, details: Map<String, Any>, project: Project?, useFrequencyDetector: Boolean = true) {
+        if (message.isNullOrEmpty() && stackTrace.isNullOrEmpty()) {
+            reportError(
+                project, "At least one of the following properties must be set: [message] or [stackTrace].", "reportError",
                 mapOf(
                     SEVERITY_PROP_NAME to SEVERITY_HIGH_TRY_FIX
-                ))
+                )
+            )
             return
         }
-        if(useFrequencyDetector && isTooFrequent(message, stackTrace)) {
+        if (useFrequencyDetector && isTooFrequent(message, stackTrace)) {
             return
         }
         val projectToUse = project ?: findActiveProject()
@@ -141,7 +143,8 @@ open class ErrorReporter {
             ActivityMonitor.getInstance(it).registerError(null, message, details)
         }
     }
-        //this method is used to report an error that is not an exception. it should contain some details to say what the error is
+
+    //this method is used to report an error that is not an exception. it should contain some details to say what the error is
     open fun reportError(project: Project?, message: String, action: String, details: Map<String, String>) {
 
 
@@ -203,7 +206,6 @@ open class ErrorReporter {
     }
 
 
-
     open fun reportAnalyticsServiceError(
         project: Project,
         message: String,

ide-common/src/main/kotlin/org/digma/intellij/plugin/posthog/ActivityMonitor.kt

@@ -128,8 +128,6 @@ class ActivityMonitor(private val project: Project) : Disposable {
     }
 
 
-
-
     override fun dispose() {
         //nothing to do, used as parent disposable
     }
@@ -327,7 +325,7 @@ class ActivityMonitor(private val project: Project) : Disposable {
 
             //Don't call directly, use ErrorReporter.reportError
 
-            val details = mutableMapOf<String,Any>(
+            val details = mutableMapOf<String, Any>(
                 "error.source" to "plugin",
                 "action" to "unknown",
                 "message" to message,
@@ -644,8 +642,6 @@ class ActivityMonitor(private val project: Project) : Disposable {
     }
 
 
-
-
     //todo: remove at some point
     fun registerFirstTimePluginLoaded() {
         postHog?.capture(userId, "plugin first-loaded")
@@ -822,7 +818,6 @@ class ActivityMonitor(private val project: Project) : Disposable {
     }
 
 
-
     private fun registerSessionDetails() {
 
         SessionMetadataProperties.getInstance().put(CURRENT_INSTALL_STATUS_KEY, InstallStatus.Active)
@@ -925,7 +920,6 @@ class ActivityMonitor(private val project: Project) : Disposable {
     }
 
 
-
     fun registerJiraFieldCopied(eventName: String, details: Map<String, Any>) {
 
         PersistenceService.getInstance().setJiraFieldCopiedTimestamp()
@@ -991,7 +985,7 @@ class ActivityMonitor(private val project: Project) : Disposable {
 
     fun reportApiPerformanceIssue(details: MutableMap<String, Any>) {
         capture(
-            "api-performance-issue",details
+            "api-performance-issue", details
         )
     }
 

src/main/kotlin/org/digma/intellij/plugin/ui/jcef/BaseMessageRouterHandler.kt

@@ -146,14 +146,13 @@ abstract class BaseMessageRouterHandler(protected val project: Project) : Common
                         val trackingRequest = jsonToObject(request, SendTrackingEventRequest::class.java)
                         trackingRequest.let {
                             it.payload?.let { pl ->
-                                if(pl.eventName == "error"){
+                                if (pl.eventName == "error") {
                                     pl.data?.let {
-                                        val stackTrace = pl.data["exception.stack-trace"] as String ?
-                                        val message = pl.data["message"]as String
-                                        ErrorReporter.getInstance().reportError(message,stackTrace,pl.data, project, false)
+                                        val stackTrace = pl.data["exception.stack-trace"] as String?
+                                        val message = pl.data["message"] as String
+                                        ErrorReporter.getInstance().reportError(message, stackTrace, pl.data, project, false)
                                     }
-                                }
-                                else{
+                                } else {
                                     if (pl.data == null) {
                                         ActivityMonitor.getInstance(project).registerCustomEvent(pl.eventName)
                                     } else {