prevent parallel and multiple engine installation and start

Author: shalom938

ide-common/src/main/kotlin/org/digma/intellij/plugin/docker/DockerService.kt

@@ -38,7 +38,6 @@ class DockerService {
 
     private val engine = Engine()
     private val downloader = Downloader()
-    private var installationInProgress: Boolean = false
 
     companion object {
 
@@ -76,10 +75,6 @@ class DockerService {
     }
 
 
-    fun isInstallationInProgress(): Boolean {
-        return installationInProgress
-    }
-
     fun isDockerInstalled(): Boolean {
         return isInstalled(DOCKER_COMMAND)
     }
@@ -138,12 +133,6 @@ class DockerService {
 
     @Internal
     fun installEngine(project: Project, resultTask: Consumer<String>) {
-        installationInProgress = true
-
-
-        val onCompleted = Consumer { _: String ->
-            installationInProgress = false
-        }.andThen(resultTask)
 
         ActivityMonitor.getInstance(project).registerDigmaEngineEventStart("installEngine", mapOf())
 
@@ -167,23 +156,23 @@ class DockerService {
                             }
                         }
 
-                        notifyResult(exitValue, onCompleted)
+                        notifyResult(exitValue, resultTask)
                     } else {
                         ActivityMonitor.getInstance(project).registerDigmaEngineEventError("installEngine", "could not find docker compose command")
                         Log.log(logger::warn, "could not find docker compose command")
-                        notifyResult(NO_DOCKER_COMPOSE_COMMAND, onCompleted)
+                        notifyResult(NO_DOCKER_COMPOSE_COMMAND, resultTask)
                     }
                 } else {
                     ActivityMonitor.getInstance(project).registerDigmaEngineEventError("installEngine", "Failed to download compose file")
                     Log.log(logger::warn, "Failed to download compose file")
-                    notifyResult("Failed to download compose file", onCompleted)
+                    notifyResult("Failed to download compose file", resultTask)
                 }
 
             } catch (e: Throwable) {
                 ErrorReporter.getInstance().reportError(project, "DockerService.installEngine", e)
                 ActivityMonitor.getInstance(project).registerDigmaEngineEventError("installEngine", "Failed in installEngine $e")
                 Log.warnWithException(logger, e, "Failed install docker engine {}", e)
-                notifyResult("Failed to install docker engine: $e", onCompleted)
+                notifyResult("Failed to install docker engine: $e", resultTask)
             } finally {
                 ActivityMonitor.getInstance(project).registerDigmaEngineEventEnd("installEngine", mapOf())
             }

ide-common/src/main/kotlin/org/digma/intellij/plugin/docker/LocalInstallationFacade.kt

@@ -1,6 +1,7 @@
 package org.digma.intellij.plugin.docker
 
 import com.intellij.openapi.components.Service
+import com.intellij.openapi.components.service
 import com.intellij.openapi.diagnostic.Logger
 import com.intellij.openapi.project.Project
 import org.digma.intellij.plugin.log.Log
@@ -25,6 +26,15 @@ class LocalInstallationFacade {
 
     private val myResultTask = MyResultTask()
 
+
+    companion object {
+        @JvmStatic
+        fun getInstance(): LocalInstallationFacade {
+            return service<LocalInstallationFacade>()
+        }
+    }
+
+
     /*
         for any operation that is requested the flow is:
         * if nothing is running start the operation and add resultTask as consumer to the result.
@@ -114,6 +124,16 @@ class LocalInstallationFacade {
     }
 
 
+    fun isInstallationInProgress(): Boolean {
+        return operationInProgress.get() == OP.INSTALL
+    }
+
+
+
+
+
+
+
     private inner class MyResultTask : Consumer<String> {
 
         private val myConsumers = mutableListOf<Consumer<String>>()

src/main/java/org/digma/intellij/plugin/toolwindow/DigmaToolWindowsListener.java

@@ -5,7 +5,7 @@
 import com.intellij.openapi.wm.*;
 import com.intellij.openapi.wm.ex.ToolWindowManagerListener;
 import org.digma.intellij.plugin.PluginId;
-import org.digma.intellij.plugin.docker.DockerService;
+import org.digma.intellij.plugin.docker.*;
 import org.digma.intellij.plugin.posthog.ActivityMonitor;
 import org.digma.intellij.plugin.ui.notificationcenter.AppNotificationCenter;
 import org.jetbrains.annotations.NotNull;
@@ -52,7 +52,7 @@ public void stateChanged(@NotNull ToolWindowManager toolWindowManager, @NotNull
     private void onMainToolWindowClose() {
         ActivityMonitor.getInstance(project).registerSidePanelClosed();
 
-        if (DockerService.getInstance().isInstallationInProgress()) {
+        if (LocalInstallationFacade.getInstance().isInstallationInProgress()) {
             ApplicationManager.getApplication().getService(AppNotificationCenter.class).showInstallationInProgressNotification(project);
         }
     }