fix possible NPE in JavaCodeVisionProvider

Author: shalom938

ide-common/src/main/java/org/digma/intellij/plugin/psi/PsiUtils.java

@@ -8,30 +8,32 @@
 import com.intellij.psi.PsiManager;
 import org.jetbrains.annotations.NotNull;
 
-/**
- * Query and navigate PSI elements.
- * This is the only class dealing with language specific services.
- */
+
 public class PsiUtils {
 
     private PsiUtils() {
     }
 
-//    @Nullable
-//    public static MethodUnderCaret detectMethodUnderCaret(Project project, LanguageService languageService, int caretOffset, VirtualFile file) {
-//        PsiFile psiFile = PsiManager.getInstance(project).findFile(file);
-//        return languageService.detectMethodUnderCaret(project, psiFile, caretOffset);
-//    }
 
 
     /*
-    Note: our DocumentInfo object has a fileUri which is a uri including the 'file:' schema and is used to convert PsiFile
-    to and from string. it is mainly used to store the file uri that the document belongs to and when necessary file the
-    PsiFile.
+    Note: our DocumentInfo object has a fileUri which is an uri including the 'file:' schema and is used to convert PsiFile
+    to and from string. it is mainly used to store the file uri that the document belongs to and to find the file when
+    necessary.
      */
 
     @NotNull
     public static String psiFileToUri(@NotNull PsiFile psiFile) {
+
+        //usually this method should only be called for source files in the project and then
+        //psiFile.getVirtualFile() will never return null.
+        //this is a fallback to protect against NPE in case we have some bug somewhere, psiFile.getName
+        //will never help us, but we will probably discover the bug in some other way because things will not work
+        //correctly with psiFile.getName.
+        if (psiFile.getVirtualFile() == null){
+            return psiFile.getName();
+        }
+
         return psiFile.getVirtualFile().getUrl();
     }
 

java/src/main/kotlin/org/digma/intellij/plugin/idea/psi/java/JavaCodeVisionProvider.kt

@@ -9,6 +9,9 @@ import com.intellij.psi.*
 abstract class JavaCodeVisionProvider: JavaCodeVisionProviderBase() {
 
 
+    internal val empty: List<Pair<TextRange, CodeVisionEntry>> = listOf()
+
+
     override val defaultAnchor: CodeVisionAnchorKind
         get() = CodeVisionAnchorKind.Top
 
@@ -33,6 +36,11 @@ abstract class JavaCodeVisionProvider: JavaCodeVisionProviderBase() {
             get() = listOf(CodeVisionRelativeOrdering.CodeVisionRelativeOrderingFirst)
 
         override fun computeLenses(editor: Editor, psiFile: PsiFile): List<Pair<TextRange, CodeVisionEntry>> {
+
+            if (psiFile.virtualFile == null){
+                return empty
+            }
+
             editor.project?.let {
                 val javaCodeLensService = editor.project!!.getService(JavaCodeLensService::class.java)
                 return javaCodeLensService.getErrorHotspotCodeLens(psiFile)
@@ -63,6 +71,11 @@ abstract class JavaCodeVisionProvider: JavaCodeVisionProviderBase() {
             get() = listOf(CodeVisionRelativeOrdering.CodeVisionRelativeOrderingAfter(ErrorHotspot.ID))
 
         override fun computeLenses(editor: Editor, psiFile: PsiFile): List<Pair<TextRange, CodeVisionEntry>> {
+
+            if (psiFile.virtualFile == null){
+                return empty
+            }
+
             editor.project?.let {
                 val javaCodeLensService = editor.project!!.getService(JavaCodeLensService::class.java)
                 return javaCodeLensService.getHighUsageCodeLens(psiFile)
@@ -92,6 +105,11 @@ abstract class JavaCodeVisionProvider: JavaCodeVisionProviderBase() {
             get() = listOf(CodeVisionRelativeOrdering.CodeVisionRelativeOrderingAfter(HighUsage.ID))
 
         override fun computeLenses(editor: Editor, psiFile: PsiFile): List<Pair<TextRange, CodeVisionEntry>> {
+
+            if (psiFile.virtualFile == null){
+                return empty
+            }
+
             editor.project?.let {
                 val javaCodeLensService = editor.project!!.getService(JavaCodeLensService::class.java)
                 return javaCodeLensService.getLowUsageCodeLens(psiFile)