remove refresh events

Author: shalom938

build.gradle.kts

@@ -301,6 +301,9 @@ tasks {
             "kotlinx.coroutines.debug" to "",
             "org.digma.plugin.report.all.errors" to "true",
 
+            //to debug AuthManager
+            //"org.digma.plugin.auth.debug" to "true",
+
 //            "idea.ProcessCanceledException" to "disabled"
 
 

ide-common/src/main/kotlin/org/digma/intellij/plugin/auth/AuthManager.kt

@@ -395,11 +395,13 @@ class AuthManager(private val cs: CoroutineScope) : Disposable {
 
                 Log.log(logger::trace, "in fireChange, auth info changed , firing event {}", myLatestAuthInfo)
 
-                reportAuthPosthogEvent(
-                    "fire auth info changed",
-                    this.javaClass.simpleName,
-                    mapOf("user.id" to myLatestAuthInfo.userId.toString(), "listeners" to listeners.size)
-                )
+                withAuthManagerDebug {
+                    reportAuthPosthogEvent(
+                        "fire auth info changed",
+                        this.javaClass.simpleName,
+                        mapOf("user.id" to myLatestAuthInfo.userId.toString(), "listeners" to listeners.size)
+                    )
+                }
 
                 Log.log(
                     logger::trace, "firing authInfoChanged, default account {}, analytics url {}",

ide-common/src/main/kotlin/org/digma/intellij/plugin/auth/AuthUtils.kt

@@ -11,3 +11,12 @@ fun reportAuthPosthogEvent(evenName: String, caller: String, details: Map<String
         ActivityMonitor.getInstance(project).registerAuthEvent(evenName, detailsToSend)
     }
 }
+
+
+//if we want to debug issues in auth manager wrap some code that will run only if debug is on.
+//set the property in runIde task
+fun withAuthManagerDebug(block: () -> Unit) {
+    if (System.getProperty("org.digma.plugin.auth.debug") != null) {
+        block.invoke()
+    }
+}

ide-common/src/main/kotlin/org/digma/intellij/plugin/auth/account/AbstractLoginHandler.kt

@@ -7,6 +7,7 @@ import org.digma.intellij.plugin.analytics.RestAnalyticsProvider
 import org.digma.intellij.plugin.auth.AuthApiClient
 import org.digma.intellij.plugin.auth.credentials.DigmaCredentials
 import org.digma.intellij.plugin.auth.reportAuthPosthogEvent
+import org.digma.intellij.plugin.auth.withAuthManagerDebug
 import org.digma.intellij.plugin.common.ExceptionUtils
 import org.digma.intellij.plugin.errorreporting.ErrorReporter
 import kotlin.coroutines.coroutineContext
@@ -84,14 +85,18 @@ abstract class AbstractLoginHandler(protected val analyticsProvider: RestAnalyti
 
             trace("refresh called for url {},trigger {}", analyticsProvider.apiUrl, trigger)
 
-            reportAuthPosthogEvent("refresh token", this.javaClass.simpleName, mapOf("refresh trigger" to trigger))
+            withAuthManagerDebug {
+                reportAuthPosthogEvent("refresh token", this.javaClass.simpleName, mapOf("refresh trigger" to trigger))
+            }
 
             val newCredentials = authApiClient.refreshToken(account, credentials)
             SingletonAccountUpdater.updateAccount(account, newCredentials)
 
             trace("refresh success for url {}, updated account {},trigger {}", analyticsProvider.apiUrl, getDefaultAccount(), trigger)
 
-            reportAuthPosthogEvent("refresh token success", this.javaClass.simpleName, mapOf("refresh trigger" to trigger))
+            withAuthManagerDebug {
+                reportAuthPosthogEvent("refresh token success", this.javaClass.simpleName, mapOf("refresh trigger" to trigger))
+            }
 
             true
 

ide-common/src/main/kotlin/org/digma/intellij/plugin/auth/account/CentralizedLoginHandler.kt

@@ -2,6 +2,7 @@ package org.digma.intellij.plugin.auth.account
 
 import org.digma.intellij.plugin.analytics.RestAnalyticsProvider
 import org.digma.intellij.plugin.auth.reportAuthPosthogEvent
+import org.digma.intellij.plugin.auth.withAuthManagerDebug
 import org.digma.intellij.plugin.common.ExceptionUtils
 import org.digma.intellij.plugin.errorreporting.ErrorReporter
 import kotlin.time.Duration.Companion.seconds
@@ -16,7 +17,9 @@ class CentralizedLoginHandler(analyticsProvider: RestAnalyticsProvider) : Abstra
 
             trace("loginOrRefresh called, url: {},trigger {}", analyticsProvider.apiUrl, trigger)
 
-            reportAuthPosthogEvent("loginOrRefresh", this.javaClass.simpleName, mapOf("loginOrRefresh trigger" to trigger))
+            withAuthManagerDebug {
+                reportAuthPosthogEvent("loginOrRefresh", this.javaClass.simpleName, mapOf("loginOrRefresh trigger" to trigger))
+            }
 
             val digmaAccount = getDefaultAccount()
 
@@ -103,7 +106,9 @@ class CentralizedLoginHandler(analyticsProvider: RestAnalyticsProvider) : Abstra
             logout("${this.javaClass.simpleName}: error in loginOrRefresh $e")
             throw e
         } finally {
-            reportAuthPosthogEvent("loginOrRefresh completed", this.javaClass.simpleName, mapOf("loginOrRefresh trigger" to trigger))
+            withAuthManagerDebug {
+                reportAuthPosthogEvent("loginOrRefresh completed", this.javaClass.simpleName, mapOf("loginOrRefresh trigger" to trigger))
+            }
         }
 
     }

ide-common/src/main/kotlin/org/digma/intellij/plugin/auth/account/LocalLoginHandler.kt

@@ -3,6 +3,7 @@ package org.digma.intellij.plugin.auth.account
 import kotlinx.coroutines.CoroutineName
 import org.digma.intellij.plugin.analytics.RestAnalyticsProvider
 import org.digma.intellij.plugin.auth.reportAuthPosthogEvent
+import org.digma.intellij.plugin.auth.withAuthManagerDebug
 import org.digma.intellij.plugin.common.ExceptionUtils
 import org.digma.intellij.plugin.errorreporting.ErrorReporter
 import kotlin.coroutines.coroutineContext
@@ -21,7 +22,9 @@ class LocalLoginHandler(analyticsProvider: RestAnalyticsProvider) : AbstractLogi
 
             trace("loginOrRefresh called, url: {},trigger {}", analyticsProvider.apiUrl, trigger)
 
-            reportAuthPosthogEvent("loginOrRefresh", this.javaClass.simpleName, mapOf("loginOrRefresh trigger" to trigger))
+            withAuthManagerDebug {
+                reportAuthPosthogEvent("loginOrRefresh", this.javaClass.simpleName, mapOf("loginOrRefresh trigger" to trigger))
+            }
 
             val digmaAccount = getDefaultAccount()
 
@@ -139,7 +142,9 @@ class LocalLoginHandler(analyticsProvider: RestAnalyticsProvider) : AbstractLogi
 
             false
         } finally {
-            reportAuthPosthogEvent("loginOrRefresh completed", this.javaClass.simpleName, mapOf("loginOrRefresh trigger" to trigger))
+            withAuthManagerDebug {
+                reportAuthPosthogEvent("loginOrRefresh completed", this.javaClass.simpleName, mapOf("loginOrRefresh trigger" to trigger))
+            }
         }
 
     }