fix fatal error check off screen rendering mode enabled (#1988)

shalom938 · web-flow · commit bb5c4479944c · 2024-03-24T11:57:02.000+02:00
diff --git a/src/main/kotlin/org/digma/intellij/plugin/ui/jcef/JBCefBrowserBuilderCreator.kt b/src/main/kotlin/org/digma/intellij/plugin/ui/jcef/JBCefBrowserBuilderCreator.kt
@@ -9,7 +9,7 @@ object JBCefBrowserBuilderCreator {
     fun create(): JBCefBrowserBuilder {
 
         val jbCefBrowserBuilder = JBCefBrowserBuilder()
-        if (SystemInfo.isLinux) {
+        if (SystemInfo.isLinux && isOffScreenRenderingModeEnabled()) {
             jbCefBrowserBuilder.setOffScreenRendering(true) // setting it to false may cause focus issues on some linux os
         }
 
@@ -18,4 +18,9 @@ object JBCefBrowserBuilderCreator {
 
         return jbCefBrowserBuilder
     }
+
+
+    private fun isOffScreenRenderingModeEnabled(): Boolean {
+        return java.lang.Boolean.getBoolean("ide.browser.jcef.osr.enabled")
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ object JBCefBrowserBuilderCreator {`
`9`	`9`	`fun create(): JBCefBrowserBuilder {`
`10`	`10`
`11`	`11`	`val jbCefBrowserBuilder = JBCefBrowserBuilder()`
`12`		`- if (SystemInfo.isLinux) {`
	`12`	`+ if (SystemInfo.isLinux && isOffScreenRenderingModeEnabled()) {`
`13`	`13`	`jbCefBrowserBuilder.setOffScreenRendering(true) // setting it to false may cause focus issues on some linux os`
`14`	`14`	`}`
`15`	`15`
`@@ -18,4 +18,9 @@ object JBCefBrowserBuilderCreator {`
`18`	`18`
`19`	`19`	`return jbCefBrowserBuilder`
`20`	`20`	`}`
	`21`	`+`
	`22`	`+`
	`23`	`+ private fun isOffScreenRenderingModeEnabled(): Boolean {`
	`24`	`+ return java.lang.Boolean.getBoolean("ide.browser.jcef.osr.enabled")`
	`25`	`+ }`
`21`	`26`	`}`