better pause AuthManager

better pause AuthManager

Author: shalom938

ide-common/src/main/java/org/digma/intellij/plugin/analytics/AnalyticsService.java

@@ -107,7 +107,7 @@ public AnalyticsService(@NotNull Project project) {
             if (shouldReplaceClient) {
                 Log.log(LOGGER::debug, "api url changed to {}, calling replace client", myApiUrl);
                 AuthManager.getInstance().logout();
-                AuthManager.getInstance().pauseCurrentProxy();
+                AuthManager.getInstance().pauseBeforeClientChange();
                 replaceClient(myApiUrl);
             }
 

ide-common/src/main/kotlin/org/digma/intellij/plugin/auth/AuthManager.kt

@@ -45,7 +45,7 @@ class AuthManager {
     private var analyticsProvider: RestAnalyticsProvider? = null
 
     private val loginOrRefreshLock = ReentrantLock()
-    private val isProxyPaused: AtomicBoolean = AtomicBoolean(true)
+    private val isPaused: AtomicBoolean = AtomicBoolean(true)
 
     companion object {
         @JvmStatic
@@ -96,7 +96,7 @@ class AuthManager {
         )
 
         Log.log(logger::info, "resuming current proxy, analytics url {}", analyticsProvider?.apiUrl)
-        isProxyPaused.set(false)
+        isPaused.set(false)
         return proxy
     }
 
@@ -281,6 +281,10 @@ class AuthManager {
 
     private fun fireChange() {
 
+        if (isPaused.get()) {
+            return
+        }
+
         Log.log(
             logger::trace, "firing authInfoChanged, default account {}, analytics url {}",
             DigmaDefaultAccountHolder.getInstance().account,
@@ -298,10 +302,12 @@ class AuthManager {
     }
 
 
-    fun pauseCurrentProxy() {
+    //pause the AuthManager before replacing the analytics provider.
+    //can be resumed only from this class after a new client is set
+    fun pauseBeforeClientChange() {
         Log.log(logger::info, "pausing current proxy, analytics url {}", analyticsProvider?.apiUrl)
         analyticsProvider = null
-        isProxyPaused.set(true)
+        isPaused.set(true)
     }
 
 
@@ -467,7 +473,7 @@ class AuthManager {
             } catch (e: InvocationTargetException) {
 
                 Log.debugWithException(logger, e, "Exception in proxy {}", ExceptionUtils.getNonEmptyMessage(e))
-                if (isProxyPaused.get()) {
+                if (isPaused.get()) {
                     Log.log(logger::trace, "got Exception in proxy but proxy is paused, rethrowing")
                     throw e
                 }