Fix logic for CodeObjectsHighlighter

Author: shalom938

rider/Digma.Rider.Plugin/Digma.Rider/Highlighting/CodeLensProviderFactory.cs

@@ -16,7 +16,6 @@ public class CodeLensProviderFactory
         private readonly CodeLensMethodInsightsProvider3 _codeLensMethodInsightsProvider3;
         private readonly CodeLensMethodInsightsProvider4 _codeLensMethodInsightsProvider4;
         private readonly CodeLensMethodInsightsProvider5 _codeLensMethodInsightsProvider5;
-        private readonly List<string> _registeredProviders = new();
         private readonly Dictionary<string, BaseMethodInsightsProvider> _genericProvidersMap = new();
 
         public CodeLensProviderFactory(
@@ -43,7 +42,7 @@ CodeLensMethodInsightsProvider5 codeLensMethodInsightsProvider5
             InitializeGenericProvidersMap();
         }
 
-        public BaseMethodInsightsProvider GetFactory(string lensTitle)
+        public BaseMethodInsightsProvider GetProvider(string lensTitle, List<string> usedGenericProviders)
         {
             if (lensTitle != null)
             {
@@ -64,17 +63,22 @@ public BaseMethodInsightsProvider GetFactory(string lensTitle)
                     return _slowEndpointMethodInsightsProvider;
                 }
             }
-            return GetNotUsedGenericMethodInsightsProvider(); 
+            return GetNotUsedGenericMethodInsightsProvider(usedGenericProviders); 
         }
 
-        private BaseMethodInsightsProvider GetNotUsedGenericMethodInsightsProvider()
+        private BaseMethodInsightsProvider GetNotUsedGenericMethodInsightsProvider(ICollection<string> usedGenericProviders)
         {
             var availableProvidersKeys = _genericProvidersMap.Where(p => 
-                _registeredProviders.All(p2 => !p2.Equals(p.Key)))
+                    usedGenericProviders.All(p2 => !p2.Equals(p.Key)))
                 .Select(x => x.Key).ToList();
 
+            if (availableProvidersKeys.Count == 0)
+            {
+                // skip the code lens if all 5 generic available providers are used already
+                return null;
+            }
             var availableProviderKey = availableProvidersKeys.Count > 0 ? availableProvidersKeys[0] : _genericProvidersMap.First().Key;
-            _registeredProviders.Add(availableProviderKey);
+            usedGenericProviders.Add(availableProviderKey);
             return _genericProvidersMap[availableProviderKey];
         }
 

rider/Digma.Rider.Plugin/Digma.Rider/Highlighting/CodeObjectsHighlighter.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using Digma.Rider.Discovery;
 using Digma.Rider.Protocol;
 using JetBrains.ProjectModel;
@@ -42,12 +43,14 @@ protected override void Run(ICSharpFunctionDeclaration functionDeclaration,
             var methodCodeLenses = _codeObjectsHost.GetRiderCodeLensInfo(methodFqn);
             if (methodCodeLenses is { Count: > 0 })
             {
+                
+                List<string> usedGenericProviders = new();
                 Log(_logger, "Found {0} code lens for method {1}", methodCodeLenses.Count, methodFqn);
                 foreach (var riderCodeLensInfo in methodCodeLenses)
                 {
                     Log(_logger, "Installing code lens for code method {0}: {1}", methodFqn, riderCodeLensInfo);
                     var codeLensMethodInsightsProvider =
-                        _codeLensProviderFactory.GetFactory(riderCodeLensInfo.LensTitle);
+                        _codeLensProviderFactory.GetProvider(riderCodeLensInfo.LensTitle,usedGenericProviders);
 
                     highlightingConsumer.AddHighlighting(
                         new CodeInsightsHighlighting(