Merge pull request #2486 from digma-ai/fix-error-when-moving-traces-between-splits

fix error when moving dragging traces between splits

Author: shalom938

src/main/java/org/digma/intellij/plugin/dashboard/DashboardFileEditor.java

@@ -28,6 +28,7 @@ public class DashboardFileEditor extends UserDataHolderBase implements FileEdito
     private final VirtualFile file;
     private final JBCefBrowser jbCefBrowser;
     private final CefMessageRouter cefMessageRouter;
+    private boolean disposed = false;
 
     public DashboardFileEditor(Project project, VirtualFile file) {
         this.file = file;
@@ -109,7 +110,7 @@ public boolean isModified() {
 
     @Override
     public boolean isValid() {
-        return true;
+        return !disposed;
     }
 
     @Override
@@ -128,6 +129,7 @@ public void dispose() {
             Disposer.dispose(jbCefBrowser);
             cefMessageRouter.dispose();
         }
+        disposed = true;
     }
 
 }

src/main/java/org/digma/intellij/plugin/documentation/DocumentationFileEditor.java

@@ -2,7 +2,7 @@
 
 import com.intellij.openapi.fileEditor.*;
 import com.intellij.openapi.project.Project;
-import com.intellij.openapi.util.UserDataHolderBase;
+import com.intellij.openapi.util.*;
 import com.intellij.openapi.vfs.VirtualFile;
 import com.intellij.ui.jcef.JBCefApp;
 import org.digma.intellij.plugin.ui.jcef.*;
@@ -101,11 +101,10 @@ public void removePropertyChangeListener(@NotNull PropertyChangeListener listene
     @Override
     public void dispose() {
         if (jCefComponent != null) {
-            jCefComponent.dispose();
+            Disposer.dispose(jCefComponent);
             jCefComponent = null;
         }
         disposed = true;
-        file.setValid(false);
     }
 
 }

src/main/java/org/digma/intellij/plugin/jaegerui/JaegerUIFileEditor.java

@@ -108,7 +108,6 @@ public void dispose() {
             jCefComponent = null;
         }
         disposed = true;
-        file.setValid(false);
     }
 
 }