Merge pull request #2490 from digma-ai/remove-unused-jcef-messages

remove deprecated jcef messages Closes #2488

Author: shalom938

build.gradle.kts

@@ -331,7 +331,6 @@ tasks {
 
         val filesToFilter = listOf(
             "webview/recentactivity/recentActivityTemplate.ftl",
-            "webview/navigation/navigationtemplate.ftl",
             "webview/jaegerui/jaegeruitemplate.ftl",
             "webview/documentation/documentation.ftl",
             "webview/main/maintemplate.ftl"

ide-common/src/main/java/org/digma/intellij/plugin/navigation/ViewChangedEvent.java

@@ -225,7 +225,7 @@ class CodeLensService(private val project: Project) : Disposable {
                 Backgroundable.ensurePooledThreadWithoutReadAccess {
                     val contextPayload = objectToJsonNode(ChangeScopeMessagePayload(lens))
                     val scopeContext = ScopeContext("IDE/CODE_LENS_CLICKED", contextPayload)
-                    ScopeManager.getInstance(project).changeScope(SpanScope(lens.scopeCodeObjectId), false, null, scopeContext, null)
+                    ScopeManager.getInstance(project).changeScope(SpanScope(lens.scopeCodeObjectId), scopeContext, null)
                 }
 
             } catch (e: Exception) {

ide-common/src/main/kotlin/org/digma/intellij/plugin/codelens/CodeLensService.kt

@@ -304,11 +304,6 @@ class ActivityMonitor(private val project: Project, cs: CoroutineScope) : Dispos
 
     }
 
-    fun registerSpanLinkClicked(spanId: String, origin: UserActionOrigin) {
-        registerUserActionWithOrigin(
-            "span link clicked", origin, mapOf("span id" to spanId)
-        )
-    }
 
 
     fun registerLensClicked(lens: String) {

ide-common/src/main/kotlin/org/digma/intellij/plugin/navigation/MainContentViewSwitcher.kt

@@ -10,8 +10,6 @@ import org.digma.intellij.plugin.common.CodeObjectsUtil
 import org.digma.intellij.plugin.common.EDT
 import org.digma.intellij.plugin.errorreporting.ErrorReporter
 import org.digma.intellij.plugin.model.rest.navigation.CodeLocation
-import org.digma.intellij.plugin.navigation.MainContentViewSwitcher
-import org.digma.intellij.plugin.navigation.View
 import org.digma.intellij.plugin.navigation.codenavigation.CodeNavigator
 import org.digma.intellij.plugin.persistence.PersistenceService
 import org.digma.intellij.plugin.ui.MainToolWindowCardsController
@@ -31,7 +29,6 @@ class ScopeManager(private val project: Project) {
 
     fun changeToHome(
         isCalledFromReact: Boolean = false,
-        forceNavigation: Boolean = false,
         scopeContext: ScopeContext? = null,
         environmentId: String? = null
     ) {
@@ -45,14 +42,6 @@ class ScopeManager(private val project: Project) {
 
         fireScopeChangedEvent(null, CodeLocation(listOf(), listOf()), false, scopeContext,environmentId)
 
-        if (!forceNavigation) {
-            val contentViewSwitcher = MainContentViewSwitcher.getInstance(project)
-            if (contentViewSwitcher.getSelectedView() != View.Assets) {
-                contentViewSwitcher.showInsights()
-            }
-        }
-
-
         EDT.ensureEDT {
             //don't do that on first wizard launch to let user complete the installation wizard.
             if (!PersistenceService.getInstance().isFirstWizardLaunch()) {
@@ -70,8 +59,6 @@ class ScopeManager(private val project: Project) {
     //preferredView is the preferred view to show after changing scope.
     fun changeScope(
         scope: Scope,
-        changeView: Boolean = true,
-        preferredView: View? = null,
         scopeContext: ScopeContext? = null,
         environmentId: String? = null
     ) {
@@ -81,7 +68,7 @@ class ScopeManager(private val project: Project) {
 
         try {
             when (scope) {
-                is SpanScope -> changeToSpanScope(scope, changeView, preferredView, scopeContext, environmentId)
+                is SpanScope -> changeToSpanScope(scope, scopeContext, environmentId)
 
                 else -> {
                     ErrorReporter.getInstance().reportError(
@@ -99,8 +86,6 @@ class ScopeManager(private val project: Project) {
 
     private fun changeToSpanScope(
         scope: SpanScope,
-        changeView: Boolean = true,
-        preferredView: View? = null,
         scopeContext: ScopeContext? = null,
         environmentId: String? = null
     ) {
@@ -141,10 +126,6 @@ class ScopeManager(private val project: Project) {
 
         fireScopeChangedEvent(scope, codeLocation, hasErrors, scopeContext, environmentId)
 
-        if (changeView) {
-            changeViewAfterScopeChange(scope, preferredView)
-        }
-
         EDT.ensureEDT {
             MainToolWindowCardsController.getInstance(project).closeCoveringViewsIfNecessary()
             ToolWindowShower.getInstance(project).showToolWindow()
@@ -163,22 +144,6 @@ class ScopeManager(private val project: Project) {
     }
 
 
-    private fun changeViewAfterScopeChange(scope: SpanScope, preferredView: View?) {
-
-        //in both these cases, if there are no insights, show analytics
-        if (preferredView == null || preferredView == View.Insights) {
-            val insightsStats = AnalyticsService.getInstance(project).getInsightsStats(scope.spanCodeObjectId, null, null)
-            if (insightsStats.issuesInsightsCount == 0) {
-                MainContentViewSwitcher.getInstance(project).showAnalytics()
-            } else {
-                MainContentViewSwitcher.getInstance(project).showInsights()
-            }
-        } else {
-            MainContentViewSwitcher.getInstance(project).showView(preferredView)
-        }
-    }
-
-
     private fun tryGetMethodIdForSpan(spanCodeObjectId: String): String? {
         return CodeNavigator.getInstance(project).findMethodCodeObjectId(spanCodeObjectId)
     }

ide-common/src/main/kotlin/org/digma/intellij/plugin/posthog/ActivityMonitor.kt

@@ -7,7 +7,6 @@
 import com.intellij.openapi.project.Project;
 import org.cef.browser.*;
 import org.digma.intellij.plugin.analytics.*;
-import org.digma.intellij.plugin.dashboard.incoming.GoToSpan;
 import org.digma.intellij.plugin.dashboard.outgoing.*;
 import org.digma.intellij.plugin.errorreporting.ErrorReporter;
 import org.digma.intellij.plugin.log.Log;
@@ -21,7 +20,7 @@
 
 import static org.digma.intellij.plugin.common.JsonUtilsKt.objectNodeToMap;
 import static org.digma.intellij.plugin.ui.jcef.JCEFUtilsKt.getMapFromNode;
-import static org.digma.intellij.plugin.ui.jcef.JCefBrowserUtilsKt.*;
+import static org.digma.intellij.plugin.ui.jcef.JCefBrowserUtilsKt.serializeAndExecuteWindowPostMessageJavaScript;
 
 public class DashboardMessageRouterHandler extends BaseMessageRouterHandler {
 
@@ -47,10 +46,6 @@ public boolean doOnQuery(@NotNull Project project, @NotNull CefBrowser browser,
 
             case "DASHBOARD/GET_DATA" -> getData(browser, requestJsonNode);
 
-            case "DASHBOARD/GO_TO_SPAN" -> {
-                GoToSpan goToSpan = jsonToObject(requestJsonNode, GoToSpan.class);
-                DashboardService.getInstance(project).goToSpan(goToSpan);
-            }
             case "DASHBOARD/GET_SERVICES" -> {
                 pushServices(browser, requestJsonNode);
             }

ide-common/src/main/kotlin/org/digma/intellij/plugin/scope/ScopeManager.kt

@@ -8,11 +8,7 @@
 import com.intellij.openapi.project.Project;
 import org.digma.intellij.plugin.analytics.*;
 import org.digma.intellij.plugin.common.EDT;
-import org.digma.intellij.plugin.dashboard.incoming.GoToSpan;
-import org.digma.intellij.plugin.log.Log;
-import org.digma.intellij.plugin.posthog.*;
 import org.digma.intellij.plugin.reload.*;
-import org.digma.intellij.plugin.scope.*;
 import org.jetbrains.annotations.NotNull;
 
 import java.io.InputStream;
@@ -101,16 +97,7 @@ public String getDashboard(@NotNull Map<String, String> queryParams) throws Anal
         return AnalyticsService.getInstance(project).getDashboard(queryParams);
     }
 
-    public void goToSpan(GoToSpan goToSpan) {
 
-        Log.log(logger::debug, project, "goToSpan request {}", goToSpan);
-
-        ActivityMonitor.getInstance(project).registerSpanLinkClicked(goToSpan.payload().spanCodeObjectId(), UserActionOrigin.Dashboard);
-
-        var span = goToSpan.payload();
-
-        ScopeManager.getInstance(project).changeScope(new SpanScope(span.spanCodeObjectId()), false, null, null, span.environment());
-    }
 
 
     @Override