Merge pull request #2420 from digma-ai/fix-first-connection-event

fix first time connection established event

Author: shalom938

ide-common/src/main/java/org/digma/intellij/plugin/analytics/AnalyticsService.java

@@ -617,10 +617,15 @@ public Object invoke(Object proxy, Method method, Object[] args) throws Throwabl
                 }
 
 
-                //todo: not thread safe so the block may be invoked more then once
                 if (!PersistenceService.getInstance().isFirstTimeConnectionEstablished()) {
-                    ActivityMonitor.getInstance(project).registerFirstConnectionEstablished();
-                    PersistenceService.getInstance().setFirstTimeConnectionEstablished();
+                    //if this block is not synchronized the event may be sent more than once.
+                    //synchronization only happens on first time because of double check
+                    synchronized (this) {
+                        if (!PersistenceService.getInstance().isFirstTimeConnectionEstablished()) {
+                            ActivityMonitor.getInstance(project).registerFirstConnectionEstablished();
+                            PersistenceService.getInstance().setFirstTimeConnectionEstablished();
+                        }
+                    }
                 }
 
                 PersistenceService.getInstance().updateLastConnectionTimestamp();

ide-common/src/main/kotlin/org/digma/intellij/plugin/persistence/PersistenceState.kt

@@ -33,7 +33,11 @@ internal open class PersistenceState : PersistentStateComponent<PersistenceData>
 
         //todo: backwards compatibility, remove firstTimeConnectionEstablishedTimestampNew in January 2025
         // renamed without the new suffix
-        myPersistenceData.firstTimeConnectionEstablishedTimestamp = myPersistenceData.firstTimeConnectionEstablishedTimestampNew
+        if (myPersistenceData.firstTimeConnectionEstablishedTimestampNew != null &&
+            myPersistenceData.firstTimeConnectionEstablishedTimestamp == null
+        ) {
+            myPersistenceData.firstTimeConnectionEstablishedTimestamp = myPersistenceData.firstTimeConnectionEstablishedTimestampNew
+        }
     }