ui error handling

Author: shaykeren

ide-common/src/main/kotlin/org/digma/intellij/plugin/common/FrequencyDetector.kt

@@ -18,10 +18,12 @@ class FrequencyDetector(cacheExpirationTime: java.time.Duration) {
         val occurrences = counter.incrementAndGet()
         return occurrences > 1
     }
-
-
-
-
+    fun isTooFrequentStackTrace(message: String, stacktrace: String): Boolean {
+        val hash = stacktrace.hashCode()
+        val counter = myCache.getOrCreate(message, hash.toString())
+        val occurrences = counter.incrementAndGet()
+        return occurrences > 1
+    }
     fun isTooFrequentError(message: String, action: String): Boolean {
         val counter = myCache.getOrCreate(message, action)
         val occurrences = counter.incrementAndGet()

ide-common/src/main/kotlin/org/digma/intellij/plugin/errorreporting/ErrorReporter.kt

@@ -116,7 +116,32 @@ open class ErrorReporter {
         )
     }
 
-    //this method is used to report an error that is not an exception. it should contain some details to say what the error is
+    private fun isTooFrequent(message: String, stackTrace: String ?): Boolean{
+        if(!stackTrace.isNullOrEmpty()){
+            return frequencyDetector.isTooFrequentStackTrace(message, stackTrace);
+        }
+        return frequencyDetector.isTooFrequentError(message,"");
+    }
+    open fun reportError(message: String, stackTrace: String ?, details: Map<String, Any>, project: Project?) {
+        if(message.isNullOrEmpty() && stackTrace.isNullOrEmpty())
+        {
+            reportError(project, "At least one of the following properties must be set: [message] or [stackTrace].","reportError",
+                mapOf(
+                    SEVERITY_PROP_NAME to SEVERITY_HIGH_TRY_FIX
+                ))
+            return
+        }
+        if(isTooFrequent(message, stackTrace)) {
+            return
+        }
+        val projectToUse = project ?: findActiveProject()
+
+        projectToUse?.let {
+            if (it.isDisposed) return
+            ActivityMonitor.getInstance(it).registerError(null, message, details)
+        }
+    }
+        //this method is used to report an error that is not an exception. it should contain some details to say what the error is
     open fun reportError(project: Project?, message: String, action: String, details: Map<String, String>) {
 
 

ide-common/src/main/kotlin/org/digma/intellij/plugin/posthog/ActivityMonitor.kt

@@ -315,7 +315,7 @@ class ActivityMonitor(private val project: Project) : Disposable {
     }
 
 
-    fun registerError(exception: Throwable?, message: String, extraDetails: Map<String, String> = mapOf()) {
+    fun registerError(exception: Throwable?, message: String, extraDetails: Map<String, Any> = mapOf()) {
 
         try {
             val osType = System.getProperty("os.name")
@@ -327,7 +327,7 @@ class ActivityMonitor(private val project: Project) : Disposable {
 
             //Don't call directly, use ErrorReporter.reportError
 
-            val details = mutableMapOf(
+            val details = mutableMapOf<String,Any>(
                 "error.source" to "plugin",
                 "action" to "unknown",
                 "message" to message,

src/main/kotlin/org/digma/intellij/plugin/ui/jcef/BaseMessageRouterHandler.kt

@@ -146,11 +146,21 @@ abstract class BaseMessageRouterHandler(protected val project: Project) : Common
                         val trackingRequest = jsonToObject(request, SendTrackingEventRequest::class.java)
                         trackingRequest.let {
                             it.payload?.let { pl ->
-                                if (pl.data == null) {
-                                    ActivityMonitor.getInstance(project).registerCustomEvent(pl.eventName)
-                                } else {
-                                    ActivityMonitor.getInstance(project).registerCustomEvent(pl.eventName, pl.data)
+                                if(pl.eventName == "error"){
+                                    pl.data?.let {
+                                        val stackTrace = pl.data["exception.stack-trace"] as String
+                                        val message = pl.data["message"]as String
+                                        ErrorReporter.getInstance().reportError(message,stackTrace,pl.data, project)
+                                    }
                                 }
+                                else{
+                                    if (pl.data == null) {
+                                        ActivityMonitor.getInstance(project).registerCustomEvent(pl.eventName)
+                                    } else {
+                                        ActivityMonitor.getInstance(project).registerCustomEvent(pl.eventName, pl.data)
+                                    }
+                                }
+
                             }
                         }
                     }