Support new action GoToError in the REST Plugin API

Author: shalom938

ide-common/src/main/java/org/digma/intellij/plugin/analytics/AnalyticsService.java

@@ -5,7 +5,6 @@
 import com.intellij.openapi.project.Project;
 import com.intellij.ui.JBColor;
 import org.apache.commons.lang3.time.StopWatch;
-import org.apache.maven.artifact.versioning.ComparableVersion;
 import org.digma.intellij.plugin.auth.AuthManager;
 import org.digma.intellij.plugin.common.*;
 import org.digma.intellij.plugin.errorreporting.ErrorReporter;
@@ -42,12 +41,12 @@
 import java.util.concurrent.TimeUnit;
 import java.util.function.*;
 
+import static org.digma.intellij.plugin.analytics.BackendUtilsKt.backendVersionOlderThen;
 import static org.digma.intellij.plugin.analytics.EnvUtilsKt.getAllEnvironmentsIds;
 import static org.digma.intellij.plugin.analytics.EnvironmentRefreshSchedulerKt.scheduleEnvironmentRefresh;
 import static org.digma.intellij.plugin.common.JsonUtilsKt.objectToJsonNoException;
 import static org.digma.intellij.plugin.common.StringUtilsKt.argsToString;
 import static org.digma.intellij.plugin.log.Log.API_LOGGER_NAME;
-import static org.digma.intellij.plugin.model.rest.AboutResultKt.UNKNOWN_APPLICATION_VERSION;
 
 
 public class AnalyticsService implements Disposable {
@@ -566,7 +565,7 @@ public HttpResponse proxyCall(HttpRequest request) throws AnalyticsServiceExcept
     @Nullable
     public SpanInfoByUid resolveSpanByUid(@NotNull String uid) throws AnalyticsServiceException {
 
-        if (backendVersionOlderThen("0.3.155")) {
+        if (backendVersionOlderThen(project,"0.3.155")) {
             return null;
         }
 
@@ -576,29 +575,14 @@ public SpanInfoByUid resolveSpanByUid(@NotNull String uid) throws AnalyticsServi
 
     @Nullable
     public EnvironmentInfoByErrorId resolveEnvironmentByErrorId(@NotNull String errorId) throws AnalyticsServiceException {
-        if (backendVersionOlderThen("0.3.318")) {
+        if (backendVersionOlderThen(project,"0.3.155")) {
             return null;
         }
 
         return executeCatching(() -> analyticsProviderProxy.resolveEnvironmentByErrorId(errorId));
     }
 
 
-    private boolean backendVersionOlderThen(String version) {
-        String backendVersion = BackendInfoHolder.getInstance(project).getAbout().getApplicationVersion();
-
-        //dev environment may return unknown
-        if (UNKNOWN_APPLICATION_VERSION.equalsIgnoreCase(backendVersion)) {
-            return false;
-        }
-
-        ComparableVersion currentBackendVersion = new ComparableVersion(backendVersion);
-        ComparableVersion requiredBackendVersion = new ComparableVersion(version);
-
-        return currentBackendVersion.compareTo(requiredBackendVersion) < 0;
-    }
-
-
     @Override
     public void dispose() {
         try {

ide-common/src/main/kotlin/org/digma/intellij/plugin/analytics/BackendUtils.kt

@@ -1,6 +1,7 @@
 package org.digma.intellij.plugin.analytics
 
 import com.intellij.openapi.project.Project
+import org.apache.maven.artifact.versioning.ComparableVersion
 import org.digma.intellij.plugin.auth.account.DigmaDefaultAccountHolder
 import org.digma.intellij.plugin.common.findActiveProject
 import org.digma.intellij.plugin.model.rest.UNKNOWN_APPLICATION_VERSION
@@ -32,10 +33,24 @@ fun isCentralized(): Boolean {
     val project = findActiveProject()
     return project?.let {
         BackendInfoHolder.getInstance(it).isCentralized()
-    } ?:false
+    } ?: false
 }
 
 
-fun isNoAccountInCentralized():Boolean{
+fun isNoAccountInCentralized(): Boolean {
     return isCentralized() && DigmaDefaultAccountHolder.getInstance().account == null
+}
+
+fun backendVersionOlderThen(project: Project, version: String): Boolean {
+    val backendVersion = BackendInfoHolder.getInstance(project).getAbout().applicationVersion
+
+    //dev environment may return unknown
+    if (UNKNOWN_APPLICATION_VERSION.equals(backendVersion, true)) {
+        return false;
+    }
+
+    val currentBackendVersion = ComparableVersion(backendVersion);
+    val requiredBackendVersion = ComparableVersion(version);
+
+    return currentBackendVersion < requiredBackendVersion;
 }

ide-common/src/main/kotlin/org/digma/intellij/plugin/api/GoToErrorCommand.kt

@@ -3,6 +3,7 @@ package org.digma.intellij.plugin.api
 import com.intellij.openapi.project.Project
 import io.netty.handler.codec.http.QueryStringDecoder
 import org.digma.intellij.plugin.analytics.AnalyticsService
+import org.digma.intellij.plugin.analytics.backendVersionOlderThen
 import org.digma.intellij.plugin.common.objectToJsonNode
 import org.digma.intellij.plugin.log.Log
 import org.digma.intellij.plugin.scope.ScopeContext
@@ -12,7 +13,12 @@ import java.util.Objects
 
 class GoToErrorCommand : AbstractApiCommand() {
 
-    override fun execute(project: Project, urlDecoder: QueryStringDecoder) {
+    override suspend fun execute(project: Project, urlDecoder: QueryStringDecoder) {
+
+        if (backendVersionOlderThen(project,"0.3.318")){
+            throw RuntimeException("This api is not supported in this version of backend")
+        }
+
         val errorId = getStringParameter(ERROR_ID_PARAM_NAME, urlDecoder)
         Objects.requireNonNull(errorId, "errorId parameter must not be null")