Skip to content

Commit fea154b

Browse files
authored
Merge pull request #2133 from digma-ai/fix/dashboards
Fix dashboards
2 parents 82100f9 + fcb4ec2 commit fea154b

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

src/main/java/org/digma/intellij/plugin/dashboard/DashboardIndexTemplateBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import java.nio.charset.StandardCharsets;
1616
import java.util.HashMap;
1717

18-
import static org.digma.intellij.plugin.analytics.EnvUtilsKt.getCurrentEnvironmentName;
18+
import static org.digma.intellij.plugin.analytics.EnvUtilsKt.getCurrentEnvironmentId;
1919

2020
public class DashboardIndexTemplateBuilder {
2121
private final Logger logger = Logger.getInstance(DashboardIndexTemplateBuilder.class);
@@ -61,7 +61,7 @@ public InputStream build(Project project, DashboardVirtualFile dashboardVirtualF
6161
data.put(DIGMA_API_URL, SettingsState.getInstance().apiUrl);
6262

6363
data.put(DASHBOARD_REFRESH_INTERVAL, 10*1000);
64-
data.put(DASHBOARD_ENVIRONMENT, getCurrentEnvironmentName(project));
64+
data.put(DASHBOARD_ENVIRONMENT, getCurrentEnvironmentId(project));
6565

6666
Template template = freemarketConfiguration.getTemplate(INDEX_TEMPLATE_NAME);
6767
StringWriter stringWriter = new StringWriter();

src/main/java/org/digma/intellij/plugin/dashboard/DashboardService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ private boolean showExisting(@NotNull String dashboardName) {
6363
var file = editor.getFile();
6464
if (file != null && DashboardVirtualFile.isDashboardVirtualFile(file)) {
6565
DashboardVirtualFile openFile = (DashboardVirtualFile) file;
66-
if (Objects.equals(openFile.getDashboardEnvId(), dashboardName)) {
66+
if (Objects.equals(openFile.getDashboardName(), dashboardName)) {
6767
EDT.ensureEDT(() -> FileEditorManager.getInstance(project).openFile(file, true, true));
6868
return true;
6969
}

src/main/java/org/digma/intellij/plugin/dashboard/DashboardVirtualFile.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
public class DashboardVirtualFile extends LightVirtualFile implements DigmaVirtualFileMarker {
1111

1212
public static final Key<String> DASHBOARD_EDITOR_KEY = Key.create("Digma.DASHBOARD_EDITOR_KEY");
13-
private String dashboardEnvId;
13+
private String dashboardName;
1414
public DashboardVirtualFile(String myTitle) {
1515
super(myTitle);
1616
setFileType(DashboardFileType.INSTANCE);
@@ -25,16 +25,16 @@ public static boolean isDashboardVirtualFile(@NotNull VirtualFile file) {
2525
@NotNull
2626
public static VirtualFile createVirtualFile(@NotNull String dashboardName) {
2727
var file = new DashboardVirtualFile(dashboardName);
28-
file.setDashboardEnvId(dashboardName);
28+
file.setDashboardName(dashboardName);
2929
DASHBOARD_EDITOR_KEY.set(file, DashboardFileEditorProvider.DASHBOARD_EDITOR_TYPE);
3030
return file;
3131
}
3232

33-
public void setDashboardEnvId(String documentationPage) {
34-
this.dashboardEnvId = documentationPage;
33+
public void setDashboardName(String documentationPage) {
34+
this.dashboardName = documentationPage;
3535
}
3636

37-
public String getDashboardEnvId() {
38-
return dashboardEnvId;
37+
public String getDashboardName() {
38+
return dashboardName;
3939
}
4040
}

src/main/kotlin/org/digma/intellij/plugin/ui/jcef/BaseMessageRouterHandler.kt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import org.cef.handler.CefMessageRouterHandlerAdapter
1414
import org.digma.intellij.plugin.analytics.AnalyticsService
1515
import org.digma.intellij.plugin.analytics.InsightStatsChangedEvent
1616
import org.digma.intellij.plugin.analytics.getAllEnvironments
17-
import org.digma.intellij.plugin.analytics.getEnvironmentNameById
17+
import org.digma.intellij.plugin.analytics.getEnvironmentById
1818
import org.digma.intellij.plugin.analytics.setCurrentEnvironmentById
1919
import org.digma.intellij.plugin.auth.AuthManager
2020
import org.digma.intellij.plugin.auth.LoginResult
@@ -166,8 +166,9 @@ abstract class BaseMessageRouterHandler(protected val project: Project) : Common
166166
JCEFGlobalConstants.GLOBAL_OPEN_DASHBOARD -> {
167167
val envId = getEnvironmentIdFromPayload(requestJsonNode)
168168
envId?.let { env ->
169-
val envName = getEnvironmentNameById(project, env)
170-
DashboardService.getInstance(project).openDashboard("Dashboard Panel - $envName")
169+
getEnvironmentById(project, env)?.let {
170+
DashboardService.getInstance(project).openDashboard("Dashboard Panel - ${it.name} - ${it.type}")
171+
}
171172
}
172173
}
173174

0 commit comments

Comments
 (0)