Skip to content

Commit 213bae0

Browse files
kshmidt-digmakshmidt-digma
committed
Move DaysFilter to common
1 parent 5aa9f63 commit 213bae0

File tree

8 files changed

+22
-22
lines changed

8 files changed

+22
-22
lines changed

‎src/components/Errors/GlobalErrorsList/index.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import { FeatureFlag, ScopeChangeEvent } from "../../../types";
2020
import { changeScope } from "../../../utils/actions/changeScope";
2121
import { sendUserActionTrackingEvent } from "../../../utils/actions/sendUserActionTrackingEvent";
2222
import { formatUnit } from "../../../utils/formatUnit";
23+
import { DaysFilter } from "../../common/DaysFilter";
2324
import { OppositeArrowsIcon } from "../../common/icons/12px/OppositeArrowsIcon";
2425
import { ChevronIcon } from "../../common/icons/16px/ChevronIcon";
2526
import { Direction } from "../../common/icons/types";
@@ -34,7 +35,6 @@ import { actions } from "../actions";
3435
import { EmptyState } from "../EmptyState";
3536
import { NewErrorCard } from "../NewErrorCard";
3637
import { trackingEvents } from "../tracking";
37-
import { DaysFilter } from "./DaysFilter";
3838
import { GlobalErrorsFilters } from "./GlobalErrorsFilters";
3939
import * as s from "./styles";
4040
import type {

‎src/components/Insights/InsightsCatalog/index.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import { isUndefined } from "../../../typeGuards/isUndefined";
2020
import { FeatureFlag } from "../../../types";
2121
import { sendUserActionTrackingEvent } from "../../../utils/actions/sendUserActionTrackingEvent";
2222
import { formatUnit } from "../../../utils/formatUnit";
23+
import { DaysFilter } from "../../common/DaysFilter";
2324
import { ChevronIcon } from "../../common/icons/16px/ChevronIcon";
2425
import { EyeIcon } from "../../common/icons/16px/EyeIcon";
2526
import { RefreshIcon } from "../../common/icons/16px/RefreshIcon";
@@ -34,7 +35,6 @@ import type {
3435
import { NewButton } from "../../common/v3/NewButton";
3536
import { NewIconButton } from "../../common/v3/NewIconButton";
3637
import { Tooltip } from "../../common/v3/Tooltip";
37-
import { DaysFilter } from "../../Errors/GlobalErrorsList/DaysFilter";
3838
import { PAGE_SIZE } from "../hooks/useInsightsData";
3939
import { useInsightsStats } from "../hooks/useInsightsStats";
4040
import { trackingEvents } from "../tracking";
@@ -141,7 +141,7 @@ export const InsightsCatalog = ({
141141
const [markScopeInsightsRead] = useMarkScopeInsightsReadMutation();
142142
const [isFiltersToolbarVisible, setIsFiltersToolbarVisible] = useState(false);
143143
const { data: insightStats } = useInsightsStats({
144-
spanCodeObjectId: scopeSpanCodeObjectId ?? "",
144+
spanCodeObjectId: scopeSpanCodeObjectId,
145145
environmentId: environment?.id,
146146
services: selectedServices ?? undefined
147147
});

src/components/Errors/GlobalErrorsList/DaysFilter/DaysFilter.stories.tsx renamed to src/components/common/DaysFilter/DaysFilter.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { DaysFilter } from ".";
44

55
// More on how to set up stories at: https://storybook.js.org/docs/react/writing-stories/introduction
66
const meta: Meta<typeof DaysFilter> = {
7-
title: "Errors/GlobalErrorsList/DaysFilter",
7+
title: "common/DaysFilter",
88
component: DaysFilter,
99
parameters: {
1010
// More on how to position stories at: https://storybook.js.org/docs/react/configure/story-layout

src/components/Errors/GlobalErrorsList/DaysFilter/index.tsx renamed to src/components/common/DaysFilter/index.tsx

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import type { ChangeEvent } from "react";
22
import { useCallback, useEffect, useMemo, useState } from "react";
3-
import { usePrevious } from "../../../../hooks/usePrevious";
4-
import { isUndefined } from "../../../../typeGuards/isUndefined";
5-
import { sendUserActionTrackingEvent } from "../../../../utils/actions/sendUserActionTrackingEvent";
6-
import { addPrefix } from "../../../../utils/addPrefix";
7-
import { formatUnit } from "../../../../utils/formatUnit";
8-
import { CalendarIcon } from "../../../common/icons/12px/CalendarIcon";
9-
import { MinusIcon } from "../../../common/icons/MinusIcon";
10-
import { PlusIcon } from "../../../common/icons/PlusIcon";
11-
import { NewPopover } from "../../../common/NewPopover";
12-
import { NewIconButton } from "../../../common/v3/NewIconButton";
13-
import { MenuList } from "../../../Navigation/common/MenuList";
3+
import { usePrevious } from "../../../hooks/usePrevious";
4+
import { isUndefined } from "../../../typeGuards/isUndefined";
5+
import { sendUserActionTrackingEvent } from "../../../utils/actions/sendUserActionTrackingEvent";
6+
import { addPrefix } from "../../../utils/addPrefix";
7+
import { formatUnit } from "../../../utils/formatUnit";
8+
import { MenuList } from "../../Navigation/common/MenuList";
9+
import { CalendarIcon } from "../icons/12px/CalendarIcon";
10+
import { MinusIcon } from "../icons/MinusIcon";
11+
import { PlusIcon } from "../icons/PlusIcon";
12+
import { NewPopover } from "../NewPopover";
13+
import { NewIconButton } from "../v3/NewIconButton";
1414
import * as s from "./styles";
1515
import { trackingEvents } from "./tracking";
1616
import type { DaysFilterProps } from "./types";

src/components/Errors/GlobalErrorsList/DaysFilter/styles.ts renamed to src/components/common/DaysFilter/styles.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import styled, { css } from "styled-components";
2+
import { Popup } from "../../Navigation/common/Popup";
23
import {
34
bodyRegularTypography,
45
footnoteRegularTypography
5-
} from "../../../common/App/typographies";
6-
import { NewButton } from "../../../common/v3/NewButton";
7-
import { TextField } from "../../../common/v3/TextField";
8-
import { Popup } from "../../../Navigation/common/Popup";
6+
} from "../App/typographies";
7+
import { NewButton } from "../v3/NewButton";
8+
import { TextField } from "../v3/TextField";
99
import type { CounterInputProps, DaysButtonProps } from "./types";
1010

1111
export const ButtonIconContainer = styled.div`

src/components/Errors/GlobalErrorsList/DaysFilter/tracking.ts renamed to src/components/common/DaysFilter/tracking.ts

File renamed without changes.

src/components/Errors/GlobalErrorsList/DaysFilter/types.ts renamed to src/components/common/DaysFilter/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import type { ErrorFilter } from "../../../../store/errors/errorsSlice";
2-
import type { ButtonProps } from "../../../common/v3/NewButton/types";
1+
import type { ErrorFilter } from "../../../store/errors/errorsSlice";
2+
import type { ButtonProps } from "../v3/NewButton/types";
33

44
export interface GetGlobalErrorsFiltersDataPayload {
55
environment: string;

‎src/featureFlags.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export const featureFlagMinBackendVersions: Record<FeatureFlag, string> = {
3434
[FeatureFlag.IsUserIdEnabled]: "0.3.212",
3535
[FeatureFlag.IsIssuesCriticalityLevelsFilterEnabled]: "0.3.214",
3636
[FeatureFlag.IsNewBehaviorForMetricsTimeModesEnabled]: "0.3.274",
37-
[FeatureFlag.IsIssuesLastDaysFilterEnabled]: "0.3.274"
37+
[FeatureFlag.IsIssuesLastDaysFilterEnabled]: "0.3.277-alpha.3"
3838
};
3939

4040
export const getFeatureFlagValue = (

0 commit comments

Comments
 (0)