Merge pull request #1328 from digma-ai/feature/vs-assets-tab

Enable Assets tab for Visual Studio

Author: kshmidt-digma

src/components/Main/index.tsx

@@ -206,12 +206,11 @@ export const Main = () => {
 
       if (scope?.context) {
         switch (scope.context.event) {
-          case ScopeChangeEvent.HistoryNavigated: {
+          case ScopeChangeEvent.HistoryNavigated:
             updateBrowserLocation(
               scope.context.payload?.location as HistoryEntryLocation
             );
             break;
-          }
           case ScopeChangeEvent.HistoryCleared:
             goTo(`/${TAB_IDS.ISSUES}`, {
               state: {
@@ -227,6 +226,10 @@ export const Main = () => {
             break;
           case ScopeChangeEvent.JaegerSpanLinkClicked:
           case ScopeChangeEvent.AssetsAssetCardTitleLinkClicked:
+            if (platform === "Visual Studio") {
+              goTo(`/${TAB_IDS.ISSUES}`, { state });
+              break;
+            }
             goTo(`/${TAB_IDS.HIGHLIGHTS}`, { state });
             break;
           case ScopeChangeEvent.HighlightsTopIssuesCardItemClicked:
@@ -248,10 +251,9 @@ export const Main = () => {
             goTo(`/${TAB_IDS.ASSETS}`, { state });
             break;
           case ScopeChangeEvent.MetricsServiceSelected:
-          case ScopeChangeEvent.MetricsEndpointSelected: {
+          case ScopeChangeEvent.MetricsEndpointSelected:
             goTo(`/${TAB_IDS.ISSUES}`, { state });
             break;
-          }
           case ScopeChangeEvent.IdeCodeLensClicked: {
             const url = getURLToNavigateOnCodeLensClick(scope);
             if (url) {

src/components/Navigation/Tabs/index.tsx

@@ -22,12 +22,12 @@ const tabs: BaseTabData[] = [
   {
     title: "Issues",
     id: TAB_IDS.ISSUES,
-    platforms: ["JetBrains", "Web"]
+    platforms: ["JetBrains", "Visual Studio", "Web"]
   },
   {
     title: "Assets",
     id: TAB_IDS.ASSETS,
-    platforms: ["JetBrains", "Web"]
+    platforms: ["JetBrains", "Visual Studio", "Web"]
   },
   {
     title: "Analytics",

src/components/Navigation/index.tsx

@@ -462,19 +462,17 @@ export const Navigation = () => {
           )}
         </Tooltip>
       </s.Row> */}
-      {platform === "JetBrains" && (
-        <s.TabsContainer>
-          <Tabs
-            onTabSelect={handleTabSelect}
-            selectedTabId={selectedTabId}
-            spanCodeObjectId={scope?.span?.spanCodeObjectId}
-            environmentId={environment?.id}
-            unreadInsightsCount={scope?.unreadInsightsCount}
-            hasErrors={scope?.hasErrors}
-            services={selectedServices ?? undefined}
-          />
-        </s.TabsContainer>
-      )}
+      <s.TabsContainer>
+        <Tabs
+          onTabSelect={handleTabSelect}
+          selectedTabId={selectedTabId}
+          spanCodeObjectId={scope?.span?.spanCodeObjectId}
+          environmentId={environment?.id}
+          unreadInsightsCount={scope?.unreadInsightsCount}
+          hasErrors={scope?.hasErrors}
+          services={selectedServices ?? undefined}
+        />
+      </s.TabsContainer>
     </s.Container>
   );
 };

src/containers/Main/router.tsx

@@ -28,18 +28,18 @@ export const routes: RouteObject[] = [
         path: TAB_IDS.ISSUES,
         element: <Insights insightViewType={"Issues"} key={"issues"} />
       },
+      {
+        path: TAB_IDS.ASSETS,
+        element: <Assets />,
+        children: [
+          {
+            path: ":typeId",
+            element: <Assets />
+          }
+        ]
+      },
       ...(platform === "JetBrains"
         ? [
-            {
-              path: TAB_IDS.ASSETS,
-              element: <Assets />,
-              children: [
-                {
-                  path: ":typeId",
-                  element: <Assets />
-                }
-              ]
-            },
             {
               path: TAB_IDS.ANALYTICS,
               element: (