Skip to content

Commit db83d98

Browse files
Merge pull request #1342 from digma-ai/fix/metrics-tab-name
Rename Changes tab in Metrics Report
2 parents e44ea06 + e5a3a3b commit db83d98

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

src/components/common/IssuesReport/Header/index.tsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,14 @@ export const Header = ({
181181
const titleSuffix = viewLevel === "endpoints" ? " Endpoints" : "";
182182
const tooltipTitle = `${title} ${titleSuffix}`;
183183

184+
const isNewBehaviorForMetricsTimeModesEnabled = getFeatureFlagValue(
185+
backendInfo,
186+
FeatureFlag.IsNewBehaviorForMetricsTimeModesEnabled
187+
);
188+
const changesTimeModeTitle = isNewBehaviorForMetricsTimeModesEnabled
189+
? "New"
190+
: "Changes";
191+
184192
return (
185193
<s.Container>
186194
<s.Row>
@@ -206,10 +214,10 @@ export const Header = ({
206214
<s.Title>{title}</s.Title>
207215
)}
208216
</s.TitleContainer>
209-
<s.TimeModeToggle
217+
<s.TimeModeToggle<IssuesReportTimeMode>
210218
options={[
211219
{ value: "baseline", label: "Baseline" },
212-
{ value: "changes", label: "Changes" }
220+
{ value: "changes", label: changesTimeModeTitle }
213221
]}
214222
value={timeMode}
215223
onValueChange={handleTimeModeChange}

src/featureFlags.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ export const featureFlagMinBackendVersions: Record<FeatureFlag, string> = {
3232
[FeatureFlag.IsHttpGetMethodSpanPercentilesHistogramEnabled]: "0.3.199",
3333
[FeatureFlag.IsInsightSeveritySortingEnabled]: "0.3.204",
3434
[FeatureFlag.IsUserIdEnabled]: "0.3.212",
35-
[FeatureFlag.IsIssuesCriticalityLevelsFilterEnabled]: "0.3.214"
35+
[FeatureFlag.IsIssuesCriticalityLevelsFilterEnabled]: "0.3.214",
36+
[FeatureFlag.IsNewBehaviorForMetricsTimeModesEnabled]: "0.3.274"
3637
};
3738

3839
export const getFeatureFlagValue = (

src/types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ export enum FeatureFlag {
2929
IsInsightSeveritySortingEnabled,
3030
IsHttpGetMethodSpanPercentilesHistogramEnabled,
3131
IsUserIdEnabled,
32-
IsIssuesCriticalityLevelsFilterEnabled
32+
IsIssuesCriticalityLevelsFilterEnabled,
33+
IsNewBehaviorForMetricsTimeModesEnabled
3334
}
3435

3536
export enum InsightType {

0 commit comments

Comments
 (0)